Comments (7)
After reading this I still stand by using Jellyfin v10. Major version and even program name can be read from the core program to be robust against version changes and even rebranding, the goal being to write code that lasts a long time :)
from jellyfin-plugin-opensubtitles.
Isn't it better to go with jellyfin v10, the smaller version numbers shouldn't matter that much and it has to try tracking the main program.. Maybe the core can provide the plugins with an appropriate user agent? :)
from jellyfin-plugin-opensubtitles.
Can we register a User-Agent per RFC 2616? The value Jellyfin/10.2
would be more appropriate.
from jellyfin-plugin-opensubtitles.
It’s not a useragent in the traditional sense. This is an OpenSubtitles required construct, it’s how they identify that we are an authorized program.
They require it to be in the format AppName vXY.Z
, where leading zeroes can be omitted if desired, and the Z can be removed if desired.
from jellyfin-plugin-opensubtitles.
See here for details: http://trac.opensubtitles.org/projects/opensubtitles/wiki/DevReadFirst
from jellyfin-plugin-opensubtitles.
I suppose like Emby before us, we could omit version entirely.
from jellyfin-plugin-opensubtitles.
@hawken93 That’s fine. It sounds good to me.
from jellyfin-plugin-opensubtitles.
Related Issues (20)
- Can't sign in HOT 10
- OpenSubs API Key ServiceUnavailable HOT 1
- API rate limit exceeded HOT 3
- Service Unavailable Error HOT 2
- Open Subtitles 18.0.0.0.0 - Status: Malfunctioned HOT 2
- [Issue]: Subtitles added to queue but are not downloaded HOT 5
- Cannot download subtitles for .strm files HOT 5
- Can't save authentication credentials HOT 2
- Subtitle download fails HOT 2
- [opensubtitles] Contact us HOT 3
- [Issue]: ServiceUnavailable error when download subtitles HOT 2
- Unable to sign into the opensubtitles plugin HOT 11
- Can't download subtitles HOT 1
- Refresh the view when a subtitle track has finished downloading HOT 2
- Can't Sign in to plugin: Request failed - BadGateway HOT 1
- Plugin doesn't find subtitles - but they do exist on the website HOT 6
- [BUG]: Jellyfin.Api.Middleware.ExceptionMiddleware: Error processing request. HOT 8
- [BUG]: `System.NullReferenceException: Object reference not set to an instance of an object.` HOT 12
- Force subtitles download for individual show or season HOT 1
- Trying to download deleted subtitles misses relevant log information HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jellyfin-plugin-opensubtitles.