jeremycole / flipper Goto Github PK

If both read and write IPs are on the same node, the status command
complains that MySQL on the node with the read IP is writable, which is of
course very desirable in this case! 

The warning shouldn't be generated.

flipper doesn't have Makefile.PL (or Build.PL), so I can't install by cpanm or 
typical perl installation "perl Makefile.Pl && make install".

I attached minimal Makefile.PL for flipper. Could you merge this patch?

We should check for duplicate IPs, interfaces, etc. and refuse to continue
during the config-reading step.

The behaviour of the swap command when an IP is not up on either host is
accidentally fixed to taking it down on the second of the two nodes in the
masterpair (which will of course fail, as it's not up on that node) and
bringing it up on the first of the two nodes.

Correct behaviour should be to do nothing with that IP, and potentially
print a warning. 

What steps will reproduce the problem?

./flipper developer status
MASTERPAIR: developer
Connection to 192.168.2.181 closed.
NODE: beta181 has write IP, is writable, replication running, 0s delay
Connection to 192.168.2.187 closed.
NODE: alpha187 has read IP, is read-only, replication running, 0s delay


What is the expected output? What do you see instead?

./flipper developer status 2>/dev/null
MASTERPAIR: developer
NODE: beta181 has write IP, is writable, replication running, 0s delay
NODE: alpha187 has read IP, is read-only, replication running, 0s delay


What version of the product are you using? On what operating system?

$ ./flipper --version
./flipper version 0.2.1
(Getopt::Long::GetOptions version 2.35; Perl version 5.8.8)

Ubuntu 8.04
$ uname -a
Linux ronald 2.6.24-19-xen #1 SMP Wed Aug 20 21:08:51 UTC 2008 x86_64 GNU/Linux

Please provide any additional information below.

When using MySQL 4.0 nodes, display the replication delay causes an error. 

The Seconds_Behind_Master variable is used to determine replication delay,
and this is only present in MySQL 4.1.1 and newer.

If this is not present in the output that Flipper receives from SHOW SLAVE
STATUS, it should instead look at the Time column in the output of SHOW
PROCESSLIST for the slave SQL thread. 

LGPL Licence Text needs adding to documentation, the code and pre-packaged
distributions of the software.

When all IPs are moved away from a node, the node should revert to being
read-only.

Currently the read-only / writable state is undefined.

We should do all the usual work to deal with write_ip, but ignore work for
read_ip if read_ip does not exist in the config table, or is set to e.g.
"none".