GithubHelp home page GithubHelp logo

jeremyenglert / jointswp-css Goto Github PK

View Code? Open in Web Editor NEW
75.0 75.0 23.0 9.67 MB

A blank WordPress theme built with Foundation 6, giving you all the power and flexibility you need to build complex, mobile friendly websites without having to start from scratch.

Home Page: http://jointswp.com

PHP 71.65% CSS 13.73% JavaScript 0.91% Modelica 13.71%

jointswp-css's People

Contributors

alexanderstott avatar joshmedeski avatar szepeviktor avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

jointswp-css's Issues

joints_top_nav not firing for custom post types

I have set up several custom post types and some via plugins (eg news and events). Unfortunately the drop down menu for medium up doesn't load within nav-offcanvas-topbar.php here's the relevant function:

`


`

Interestingly the joints_top_nav loads wrapped in top-bar-right (the mobile hamburger menu) from within nav-title-bar.php

Update to Foundation 6.4.0

Updated framework brings fixes and some simplifications and new features; keep your project users happy with updated parts, thanks for it

Link to jQuery in joints.php is incorrect

Hi there. Great Foundation 5 based theme thus far. However, the link to jQuery in joints.php is broken. It's looking inside of 'bower_components' (presumably from the SASS version).

Line 128 should be:
wp_enqueue_script( 'jquery', get_template_directory_uri() . '/foundation/js/vendor/jquery.js', array(), '2.1.0', false );

instead of the current:
wp_enqueue_script( 'jquery', get_template_directory_uri() . '/bower_components/foundation/js/vendor/jquery.js', array(), '2.1.0', false );

Missing function for foundation.css

Hi,

The joints.php file is missing the function to register the default Foundation stylesheet.

Thanks for creating the WP integration though, very helpful.

Thanks

script.js not loaded on admin pages ?

Hi there!

First of all, thanks a lot for your theme! I'm having a lot of fun reading through you huge blocks of welcoming comments, thus improving my Wordpress skills and creating cool designs for different people: life is cool.
Furthermore, I have been looking for that kind of theme for ages! I ended up tossing SCSS which causes more issues than solutions in my situation, so I'm glad you provided both versions.

Still, I am surprised to see that you only load /library/js/script.js in the non admin pages. This is written the function joints_scripts_and_styles() in /library/joints.php. I can understand that you don't really need Foundation in admin pages, but what about Gravatar ? Plus your comment in script.js says we have to (well, can) add our js code here. I wanted to add jQuery UI datepicker for a custom type in the admin section, and spent a little time figuring it out (finding the right if statement... Don't blame me it's late!).

No big deal, though, I'm mostly being curious.
Thanks again for the theme!
Adrien

joints_register_sidebars not found or invalid function name

We have a site using joints_wp version 3.0. I know that this is an old version, but I'm reaching out in spite of that because we are in a pickle since we cannot upgrade to the latest version at this time.

Our error logs are blowing up with this error.

call_user_func_array() expects parameter 1 to be a valid callback, function 'joints_register_sidebars' not found or invalid function name in /var/www.supportuw.org/wp-includes/class-wp-hook.php.

What can we do to fix this error?

The version of wordpress we are using is 4.9.4.

The code in /assets/functions/sidebar.php is

`<?php
// SIDEBARS AND WIDGETIZED AREAS
function joints_register_sidebars() {
register_sidebar(array(
'id' => 'sidebar1',
'name' => __('Sidebar 1', 'jointswp'),
'description' => __('The first (primary) sidebar.', 'jointswp'),
'before_widget' => '

',
'after_widget' => '
',
'before_title' => '

',
'after_title' => '

',
));

register_sidebar(array(
	'id' => 'offcanvas',
	'name' => __('Offcanvas', 'jointswp'),
	'description' => __('The offcanvas sidebar.', 'jointswp'),
	'before_widget' => '<div id="%1$s" class="widget %2$s">',
	'after_widget' => '</div>',
	'before_title' => '<h4 class="widgettitle">',
	'after_title' => '</h4>',
));

/*
to add more sidebars or widgetized areas, just copy
and edit the above sidebar code. In order to call
your new sidebar just use the following code:

Just change the name to whatever your new
sidebar's id is, for example:

register_sidebar(array(
	'id' => 'sidebar2',
	'name' => __('Sidebar 2', 'jointswp'),
	'description' => __('The second (secondary) sidebar.', 'jointswp'),
	'before_widget' => '<div id="%1$s" class="widget %2$s">',
	'after_widget' => '</div>',
	'before_title' => '<h4 class="widgettitle">',
	'after_title' => '</h4>',
));

To call the sidebar in your template, you can just copy
the sidebar.php file and rename it to your sidebar's name.
So using the above example, it would be:
sidebar-sidebar2.php

*/

} // don't remove this bracket!`

JointsWP - Pagination Issue

Hello,

On my loop-archive template, upon clicking the pagination at the bottom I am getting the same results as page 1 on page 2 and page 3.

Please advise. I haven't changed anything from out the box. I am using V5. I've already done a ton of customization and I've read that there were some pagination issues worked out in V6. Is there anything I can do short of starting over to get the pagination to work?

Thanks.

Default Gravatar

I noticed that when I enabled the default wordpress icon for comments, the theme shows it as a broken image link. The theme can however display an image if the user has gravatar hosted with gravatar.com.

close html

Hi, I can't see you close the html tag, the last one in the footer is the closing body tag.

Dropdown doesn't work

Hi,
dropdownn list in menu doesn't work :( Guess because of wrong jquery file address in joints.php. Can't fix it, can you help me please?

:)

Kind regards,
Anna

Pagination issues with category postname permalink structure

Not really sure if this is JointsWP related but think it is.

I'm running into an issue with the pagination after setting up my permalink structure as %category%%postname%. This breaks the default pagination when using the category.php template as it returns a 404.

Managed to solved this with a custom query

` 'post', 'category_name' => 'nen-2767-kennisbank', 'posts_per_page' => 5, 'paged' => $paged ); // create a new instance of WP_Query $the_query = new WP_Query( $query_args ); ?>

have_posts() ) : while ( $the_query->have_posts() ) : $the_query->the_post(); // run the loop ?> max_num_pages > 1) { // check if the max number of pages is greater than 1 ?> `

And using a plugin https://wordpress.org/plugins/category-pagination-fix/

Now the 404 issues are solved but the pagination is not listing the correct page as active. It always shows '1' as active page but you can navigate when clicking the pagination numbers and 'next' / 'prev' links.

Could this be caused with the custom pagination that JointsWP uses?

JointsWP - Adding analytics tracking code to top nav help

I was hoping someone could help me add analytics tracking code to the top nav. I've looked at the functions/menu.php file but it only addressed the <ul> portion and not the <li><a> portion that I need to add the tracking code to.

For example, I'd like something like this:
<li><a href="/gallery" onClick="ga('send', 'event', 'TopNav', 'Click', 'Gallery');">Gallery</a></li>

Then of course I'd like Gallery to change to Homepage, News, etc depending on what the link was pointing to.

Any solutions would be really helpful! Thank you.

(PS: Love JointsWP, I've been using it for developing sites like http://marketstreetprototyping.org/, http://groundplaysf.org, http://www.rentsfnow.com (redesign coming) - definitely my go-to wordpress theme!!)

normalize.css should be loaded before foundation.css

Eyh, it's me again !

Foundation recommends including normalize.css before foundation.css, and I saw that it was for good reasons : normalize overrides foundation's textarea markup if you set it second. It makes a text input and a textarea have different fonts, which is not cool.

Swapping lines 127 and 130 of joints.php seems to do the job.

Regards,
Adrien

Grid not displaying correctly on large-screen Safari

grid

As can be seen in the attached screenshot, the 4th "large-3 medium-3 small-6 columns" element in a "row" div got pushed down. The issue only comes up for Safari when the screen width is above the "large" threshold (e.g. one that runs on iMac or Macbook). Smaller-screen Safari (e.g. ones that run on iPad and iPhone) other browsers such as Chrome, Firefox, Edge don't seem to have the same issue. Any ideas what might be the cause of this?

What happened to the different media sizes in CSS?

Hi Jeremy,

I haven't been paying attention, but you removed the media queries for small, medium etc in assets/css/style.css. How are we supposed to style only for medium up, for example?

Thanks,
Adrien

iPad and iPad Mini Media Queries with Top-Bar Menu

Hello, I was wondering how you could display the main menu with off-canvas support used on the mobile screen (e.g. iPhone) for both the iPad and iPad mini. I tried editing foundations.css line 5909 /*Medium Display */ @media to something like @media only screen and (min-width: 48.0625em) but it only gets me half way there. Is there a better way to go about doing this?

Thanks,
Jack

WordPress email Your Site is Experiencing a Technical Issue

Hi,

Love JointsWP and have been using it for a few years now as my go-to theme.

However, with a recently launched site, I am getting an email saying the site is experiencing technical issues - the website itself seems fine, but the error is pointing to line 32 in /functions/admin.php which is
$limit = $feed->get_item_quantity(5);

Here are the details:
WordPress version 5.7
Current theme: JointsWP - CSS (version 5.0)
Current plugin: (version )
PHP version 7.3.26

Error Details

An error of type E_ERROR was caused in line 32 of the file /home/sites/10a/c/c6b572b4fc/public_html/wp-content/themes/goldnuggetdesigns/functions/admin.php. Error message: Uncaught Error: Call to undefined method WP_Error::get_item_quantity() in /home/sites/10a/c/c6b572b4fc/public_html/wp-content/themes/goldnuggetdesigns/functions/admin.php:32
Stack trace:
#0 /home/sites/10a/c/c6b572b4fc/public_html/wp-admin/includes/template.php(1389): joints_rss_dashboard_widget('', Array)
#1 /home/sites/10a/c/c6b572b4fc/public_html/wp-admin/includes/dashboard.php(256): do_meta_boxes(Object(WP_Screen), 'normal', '')
#2 /home/sites/10a/c/c6b572b4fc/public_html/wp-admin/index.php(181): wp_dashboard()
#3 {main}
thrown

understand this could be a plugin conflict or similar but any help appreciated

Foundation 4.0 JS

Hi Jeremy, I just tried updating your theme with the latest version of foundation.min.js (http://foundation.zurb.com/develop/download.html) and noticed while most everything seems to work fine the mobile menus don't seem to work as before. Example: when I scale the browser down to display the mobile menus, the menus no longer slide out/appear when I click on the hamburger icons.

How to include more jquery based scripts to the CSS version

Hi,

I am adding waypoints.js and owl.carousel.js to my site http://wawewiwowu.com .
So the only way to make these work is to repeat the jQuery link in the footer.php before the js I need to make it work.

<script src="/vendor/jquery/dist/jquery.min.js"></script> <script src="/assets/owl-carousel/owl.carousel.js"></script> <script src="/assets/js/owl-carousel-custom.js"></script> <script src="/assets/js/waypoints.js"></script> <script src="/assets/js/jquery.countTo.js"></script> <script src="/assets/js/waypoints-animate-custom.js"></script>

Anything I do in enqueue-scripts.php does nothing.
Now I have a problem with some plugins because of that jquery in the footer.

What can I do?
Which is the right place to load and order the scripts?

Modal functionality breaks when MotionUI animations are specified

Tested on the latest JointsWP-CSS (Foundation 6.4.3) on a fresh install of Wordpress 4.9.4 with no plugins.

Without animations specified, the modal works:

<button class="button" data-toggle="modal">This modal works</button>

<div class="reveal" id="modal" data-reveal data-close-on-click="true">
  <h1>This modal works.</h1>
  <button class="close-button" data-close aria-label="Close reveal" type="button">
    <span aria-hidden="true">&times;</span>
  </button>
</div>

When animations are specified, the modal doesn't animate and won't close after opening:

<button class="button" data-toggle="animatedModal">This modal doesn't work</button>

<div class="reveal" id="animatedModal" data-reveal data-animation-in="fade-in" data-animation-out="fade-out" data-close-on-click="true">
  <h1>This modal doesn't work.</h1>
  <button class="close-button" data-close aria-label="Close reveal" type="button">
    <span aria-hidden="true">&times;</span>
  </button>
</div>

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.