jetbrains / sbt-idea-plugin Goto Github PK

Develop IntelliJ plugins with Scala and SBT

License: Apache License 2.0

Scala 97.81% Java 2.19%

intellij sbt-plugin intellij-plugin plugin-sbt intellij-platform intellij-ide sbt

sbt-idea-plugin's Issues

ideaExternalPlugins should install plugins to `plugins` folder as well

While external plugins' classes must be added to compilation classpath during build, to be able to run/debug IDEA those plugins have to be excluded from initial root classpath(IDEA will load them using its own classloading mechanism from plugins folder).

This is especially important for IDEA plugins that depend on other IDEA plugins.

At the moment manual intervention is required, since necessary external plugins have to be manually copied to plugins dir.

Use downloaded JBR in generated run configuration

NumberFormatException in updateIntellij

How to reproduce

sbt raises NumberForatException on startup after successfull intellijExternalPlugins installation.

$> sbt
(For the first time, IdeaIC and plugin are successfully downloaded)
(Then shutdown sbt and rerun)
$> sbt
[info] Loading settings for project sbt-idea-plugin-issue-build from plugins.sbt ...
[info] Loading project definition from /home/vagrant/IdeaProjects/sbt-idea-plugin-issue/project
[info] Loading settings for project myAwesomePlugin from build.sbt ...
[info] Set current project to my-awesome-plugin (in build file:/home/vagrant/IdeaProjects/sbt-idea-plugin-issue/)
[error] java.lang.NumberFormatException: For input string: "*"
[error]         at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)

Configuration

openjdk 11.0.4 2019-07-16

project/build.properties

sbt.version=1.3.2

project/plugins.sbt

addSbtPlugin("org.jetbrains" % "sbt-idea-plugin" % "3.3.0")

build.sbt

intellijPluginName in ThisBuild := "my-awesome-plugin"
intellijBuild in ThisBuild := "192.6817.14"
intellijDownloadSources in ThisBuild := true
intellijInternalPlugins += "java"
intellijExternalPlugins += "PsiViewer".toPlugin

lazy val myAwesomePlugin = (project in file("."))
  .enablePlugins(SbtIdeaPlugin)
  .settings(
    name := "my-awesome-plugin",
    version := "0.1.0",
    scalaVersion := "2.13.1"
  )

idea-runner/run return "Could not find installation home path"

[info] Done packaging.
[info] Running com.intellij.idea.Main

Start Failed: Internal error. Please report to http://jb.gg/ide/critical-startup-errors

java.lang.RuntimeException: Could not find installation home path. Please reinstall the software.
	at com.intellij.openapi.application.PathManager.getHomePath(PathManager.java:93)
	at com.intellij.openapi.application.PathManager.getHomePath(PathManager.java:72)
	at com.intellij.openapi.application.PathManager.loadProperties(PathManager.java:409)
	at com.intellij.ide.Bootstrap.main(Bootstrap.java:17)
	at com.intellij.idea.Main.main(Main.java:61)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at sbt.Run.invokeMain(Run.scala:98)
	at sbt.Run.run0(Run.scala:92)
	at sbt.Run.execute$1(Run.scala:68)
	at sbt.Run.$anonfun$run$4(Run.scala:80)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:12)
	at sbt.util.InterfaceUtil$$anon$1.get(InterfaceUtil.scala:10)
	at sbt.TrapExit$App.run(TrapExit.scala:253)
	at java.lang.Thread.run(Thread.java:745)

Add IDEA log display to generated run configurations

IDEA run configurations have additional option for displaying log files in a dedicated toolwindow.

Would be useful to make use of it for IDEA log files

Ignore .DS_Store file

A .DS_store file gets created when opening a directory with Mac using the Finder app. This seems to cause some error messages until I manually delete that file. Maybe we can ignore a .DS_store file instead?

[error] Failed to build plugin index from /Users/tle/.IntelliJ-Scala-Pants-ReplPluginIC/sdk/192.7142.36/plugins/.DS_Store: Couldn't find plugin.xml in /Users/tle/.IntelliJ-Scala-Pants-ReplPluginIC/sdk/192.7142.36/plugins/.DS_Store
[info] Writing structure to /private/var/folders/9m/r6q8f2fn24xbnq5j67f9gthr0000gp/T/sbt-structure.xml...
[info] Done.
[success] Total time: 1 s, completed Nov 5, 2019 1:35:17 PM
[info] Reapplying settings...
[info] Set current project to plugin (in build file:/Users/tle/github/intellij-scala-repl/)
[error] Failed to build plugin index from /Users/tle/.IntelliJ-Scala-Pants-ReplPluginIC/sdk/192.7142.36/plugins/.DS_Store: Couldn't find plugin.xml in /Users/tle/.IntelliJ-Scala-Pants-ReplPluginIC/sdk/192.7142.36/plugins/.DS_Store
[success] Total time: 0 s, completed Nov 5, 2019 1:35:17 PM
[info] Defining Global / ideaPort
[info] The new value will be used by Compile / compile, Test / compile and 1 others.
[info] 	Run `last` for details.
[info] Reapplying settings...
[info] Set current project to plugin (in build file:/Users/tle/github/intellij-scala-repl/)
[error] Failed to build plugin index from /Users/tle/.IntelliJ-Scala-Pants-ReplPluginIC/sdk/192.7142.36/plugins/.DS_Store: Couldn't find plugin.xml in /Users/tle/.IntelliJ-Scala-Pants-ReplPluginIC/sdk/192.7142.36/plugins/.DS_Store```

Scala major version should be set automatically when depending on Scala plugin

Due to Scala's binary incompatibility between major release versions, a situation may occur when the user sets project's scalaVersion to a different major version from the one used in Scala plugin for IJ.
While the compilation may succeed user plugin project will fail to run with cryptic classloading errors because due to IJ classloading mechanism scala-library from parent's classloader will be used and the version won't match.
See #11

Auto download and\or enable IDEA plugin dependencies

If some plugin specified by ideaInternalPlugins or ideaExternalPlugins has dependencies,
these dependencies should also be downloaded and installed if necessary and enabled automatically.

IDEA sdk added to all project's unmanagedJars

Regardless of whether the plugin is enabled for the project or not

ideaExternalPlugins doesn't work as expected

Hey!

I am not sure but seems mechanics of ideaExternalPlugins is broken. At least I can't find a proper way to compile a project that depends on external idea plugins without manual intervention.

In my project I have:

ideaExternalPlugins in ThisProject +=                                                                                       
    IdeaPlugin.Zip("scala-plugin", url("https://plugins.jetbrains.com/files/1347/65894/scala-intellij-bin-2019.2.14.zip")),

During updateIdea it downloads jar:

[info] Installed plugin 'scala-plugin to /home/unencrypted/univision/macrame-idea-scala-plugin/idea/sdk/192.5728.98/externalPlugins/scala-plugin.jar

but not unpacking it.

And then:

> show ideaExternalPluginsJars
[info] *

As a result, the sbt doesn't add external idea plugin to the classpath and I can't compile the project. From what I see in
https://github.com/JetBrains/sbt-idea-plugin/blob/master/src/main/scala/org/jetbrains/sbtidea/tasks/CreatePluginsClasspath.scala you expect external plugins to be unpacked.

If I manually unpack scala-plugin.jar to the scala-plugin folder then all start working as expected.

ability to specify `ideaInternalPlugins` for Test scope

For now, the value of ideaInternalPlugins sbt key can only be specified for Global scope.
It would be nice to be able to refine it for Test scope only.
For example, I want to add "Kotlin" plugin to test the integration of some Scala plugin and Kotlin plugin modules (e.g. to test https://youtrack.jetbrains.com/issue/SCL-16093). I would like it to be added to tests classpath and I wouldn't like to pollute the Global scope, due to Kotlin classes are not required during compilation AFAIK.

NOTE: this is probably actual for other sbt keys:

ideaInternalPlugins
ideaExternalPlugins
ideaInternalPluginsJars
ideaExternalPluginsJars

IDEA plugins are added to runner project classpath

Since IDEA 192.x bundled plugins are not loaded automatically from plugins dir even if they're missing from classpath

External plugins' version and compatibility isn't checked

External plugins are only downloaded from the repository once and then re-used regardless of whether there is a newer version(if installed from channel) or the plugin is no longer compatible with current IDEA version.

The plugin downloader must be able to resolve these cases and update external plugins if needed or notify the user that there is an unresolvable incompatibility with the external plugins.

Add bundled plugin dependencies via plugin id instead of folder name

Bundled plugin folders are sometimes renamed in the platform which results in "cannot find bundled plugin: check plugin name" error, while the plugin itself is still there.
Since plugins tend to have stable plugin ids it would be reasonable to use them instead of relying on folder structure.

Add external plugin with IntellijPlugin.Url can throw MissingPluginRootException

I believe the problem is at this line:

sbt-idea-plugin/ideaSupport/src/main/scala/org/jetbrains/sbtidea/download/LocalPluginRegistry.scala

Line 87 in 4a49cbf

if (!index.containsKey(key))

index is a HashMap[String, String], but key can be a URL type.

transforming the key/url to a string seems to fix the issue:

Attempt downloading external plugin sources

Some plugins on the IJ plugin marketplace provide a link to their sources in the plugin's description.
It would be very useful to be able to automatically download and attach them when using external plugin dependencies

idea-runner undefined setting with v3.0.0

lazy val ideaRunner: Project =
  createRunnerProject(plugin, "idea-runner")

[error] Reference to undefined setting: 
[error] 
[error]   idea-runner / ideaMainJars from idea-runner / Compile / unmanagedJars (Utils.scala:22)
[error]  
[error] Use 'last' for the full log.

IDEA version compatibility checks incorrectly handles * wildcard

Plugin publishing should use token based authentication

plugins.jetbrains.com doesn't support basic username\password auth

createRunnerProject does not work

Hi, I added a createRunnerProject call to my build.sbt but the idea-runner module does not get generated.

Related part looks like this:

lazy val macroPlugin = (project in file("plugin"))
.settings(commonSettings)
.settings(ideaSettings)
.settings(packagingSettings)
.settings(
name := "macroannotation-idea"
)
.enablePlugins(SbtIdeaPlugin)

lazy val ideaRunner: Project =
createRunnerProject(macroPlugin, "idea-runner")

IDEA eap builds cannot be resolved

IDEA eap builds and snapshots have been extracted to a separate repository, namely
https://www.jetbrains.com/intellij-repository/snapshots

The plugin currently detects usage of this repo by looking at "-SNAPSHOT" suffix, which EAP builds don't have.

Scala library added to classpath when not actually required

Scala library shouldn't be bundled and included in generated artifact or module structure if current IDEA plugin already depends on another one with scala-library already included in distribution.

This creates classloading conflict because scala-library classes are loaded both in parent and child plugin classloaders.

One particular example would be depending on Scala plugin, which breaks IDEA run configurations.

Possible JBR issues when using runIDE?

We're developing an IntelliJ plugin using Scala which is currently using gradle-intellij-plugin, but we want to migrate it over to SBT using this plugin but I'm seeing errors like this when using the runIDE task:

java.lang.NoClassDefFoundError: com/apple/eawt/AppEvent$AboutEvent
	at com.intellij.ui.mac.MacOSApplicationProvider$Worker.initMacApplication(MacOSApplicationProvider.java:57)
	at com.intellij.ui.mac.MacOSApplicationProvider.initApplication(MacOSApplicationProvider.java:42)
	at com.intellij.idea.ApplicationLoader.startApp(ApplicationLoader.kt:159)
	at com.intellij.idea.ApplicationLoader.executeInitAppInEdt(ApplicationLoader.kt:93)
	at com.intellij.idea.ApplicationLoader.access$executeInitAppInEdt(ApplicationLoader.kt:1)
	at com.intellij.idea.ApplicationLoader$initApplication$1$1.run(ApplicationLoader.kt:355)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:313)
	...

From what I can tell this is because JBR isn't being used. When I manually set JAVA_HOME to point to JBR before running SBT, everything works as expected:

export JAVA_HOME="/Users/reibitto/Library/Preferences/IntelliJIdea2019.3/jdks/jbrsdk-11_0_5-osx-x64-b630.1/jbrsdk/Contents/Home"

Should this be handled automatically by sbt-idea-plugin? Or maybe expose an option of some kind? For example, gradle-intellj-plugin exposes a jbrVersion setting:
https://github.com/JetBrains/gradle-intellij-plugin#configuration

Or is there a different way of resolving the issue that I'm seeing? FWIW, I tried runIDE on some other IntelliJ plugins based on sbt-idea-plugin that I found publicly on GitHub and I ran into the same NoClassDefFoundErrors for macOS. If it helps, this is what our current build.sbt looks like:
https://github.com/reibitto/zio-intellij/blob/1247caf840f4d52c6f49fc5e19b02e2eef86cd69/build.sbt

Merge strategies support

With current implementation if there are multiple files mapped to the same path, the latter would just overwrite the former.
This can be worked around by using additionalFileMappings setting, but having a more generic solution would be better.
In sbt-assembly plugin this is solved by introducing a MergeStrategy concept which takes care of resolving conflicts.

Implementing similar concept would prove useful, although coherency with IDEA readable artifacts must still be obeyed

Can we make baseUrl for JBIdeaRepoArtifactResolver a configurable setting?

sbt-idea-plugin/ideaSupport/src/main/scala/org/jetbrains/sbtidea/download/JBIdeaRepoArtifactResolver.scala

Line 38 in 7411333

val baseUrl = s"https://www.jetbrains.com/intellij-repository/$repo/$groupId"

I'm building a plugin on CI at work and I have to go through a proxy to download the SDK zip.

i.e.

sbt-idea-plugin is hardcoded to download from https://www.jetbrains.com/intellij-repository/releases/com/jetbrains/intellij/idea/ideaIC/192.7142.36/ideaIC-192.7142.36.zip

I need to change the url to this:
https://artifactory.twitter.biz/intellij-repository/releases/com/jetbrains/intellij/idea/ideaIC/192.7142.36/ideaIC-192.7142.36.zip

thanks!

Plugin downloading fails with FileAlreadyExistsException after interrupted installations

NPE in dumpDependencyStructure

java.lang.NullPointerException
[20:27:57]	at org.jetbrains.sbtidea.tasks.packaging.StructureBuilder$$anonfun$2.apply(StructureBuilder.scala:24)
[20:27:57]	at org.jetbrains.sbtidea.tasks.packaging.StructureBuilder$$anonfun$2.apply(StructureBuilder.scala:24)
[20:27:57]	at scala.collection.Iterator$$anon$11.next(Iterator.scala:328)
[20:27:57]	at scala.collection.Iterator$class.foreach(Iterator.scala:727)
[20:27:57]	at scala.collection.AbstractIterator.foreach(Iterator.scala:1157)
[20:27:57]	at scala.collection.TraversableOnce$class.toMap(TraversableOnce.scala:279)
[20:27:57]	at scala.collection.AbstractIterator.toMap(Iterator.scala:1157)
[20:27:57]	at org.jetbrains.sbtidea.tasks.packaging.StructureBuilder.artifactMappings(StructureBuilder.scala:24)
[20:27:57]	at org.jetbrains.sbtidea.Keys$$anonfun$projectSettings$29$$anonfun$apply$15.apply(Keys.scala:349)
[20:27:57]	at org.jetbrains.sbtidea.Keys$$anonfun$projectSettings$29$$anonfun$apply$15.apply(Keys.scala:349)

Compile errors because package name conflicts in SDK jars

SDK jars contains libraries with package names which are conflicting.

The IntelliJ-Haskell plugin uses the CompileContextImpl of package com.intellij.compiler.impl. sbt compile gives this error:

[error] /home/rik/idea/intellij-haskell/src/main/scala/intellij/haskell/external/execution/StackCommandLine.scala:21:30: object impl is not a member of package com.intellij.compiler
[error] import com.intellij.compiler.impl._

That is because also library javac2.jar exports package com.intellij.compiler. It should use library java-impl.jar

How to prevent this compile error? Is it possible to exclude javac2.jar?

Also this error:

[error] /home/rik/idea/intellij-haskell/src/main/scala/intellij/haskell/external/execution/CommandLine.scala:28:26: object incremental is not a member of package org.jetbrains.jps
[error] import org.jetbrains.jps.incremental.messages.BuildMessage

Btw, in the past this wasn't issue.

Compiling the plugin in IntelliJ gives no errors.

Using version 2.4.1 of sbt-idea-plugin and IntelliJ version 192.6603.28

Runner project shouldn't have hard dependency on `ideaExternalPlugins`

? operator should be used on the task instead

cannot resolve ascii-graphs dependency

I tried to develop a new sbt-based intellij idea plugin and I cannot find any repository containing org.jetbrains ascii-graphs.

Download and install JBR from bintray

IJ ide distributions downloaded from IJ repository do not bundle JBR which is required for ide to run correctly on some operating systems. See #44

Add blocking mode to `runIDE` task

[tobias.kahlert]
hmm, but I need it blocking. Basically I want to start the compiled plugin/intellij with some parameter, so that it generates some files, then idea will exit, and then I want to copy one of the created files to another folder (namely the created index-xml for searchable settings) (edited)

Add plugin.xml dsl

Common plugin configuration options should be possible to define within the sbt build.

since-build and until-build could be inferred from ideaVersion
version can be shared with sbt's version setting key
changeNotes

Sreenshots

patched plugin.xml file not being included in jar

I just updated from plugin version 2.3.2 to version 3.6.3, and implemented the new patchPluginXml settings. After running packageArtifactZip, I checked to see if everything was correct, but the plugin.xml included in the jar was the original, unpatched file.

I did check that the file output to target/scala-2.12/classes/META-INF/plugin.xml DID get the patched values correctly, it just seems that the jar after bundling is using the original.

--- scala-2.12/classes/META-INF/plugin.xml	2020-04-13 14:47:04.000000000 -0400
+++ plugin-jar-unpacked/lib/META-INF/plugin.xml	2020-04-13 14:46:44.000000000 -0400
@@ -1,10 +1,10 @@
 <idea-plugin url="http://www.jetbrains.com/idea">
     <id>com.codmettle.plugin</id>
     <name>Plugin Name</name>
-    <version>1.5</version>
+    <version>1.4</version>
     <vendor url="http://www.codemettle.com">CodeMettle</vendor>
     <description>IntelliJ IDEA plugin to support Product Development</description>
-    <idea-version since-build="201.6668.121"/>
+    <idea-version since-build="183.0"/>
     <depends>org.intellij.scala</depends>
     <application-components>
         <!-- TODO put your components here -->

PsiClass not found in 2019.x

Thanks for this plugin!

I'm trying to get the example project working for Intellij 2019.2.2 Community but I'm running into this compile error:

[error] C:\Users\WilliamCarter\workspace\ijext-sample-project\ijext\src\main\scala\org\jetbrains\scala\libextensions\test\MacroDynamicSupport.scala:12:89: Symbol 'type com.intellij.psi.PsiAnnotationMemberValue' is missing from the classpath.
[error] This symbol is required by 'trait org.jetbrains.plugins.scala.lang.psi.api.expr.ScExpression'.
[error] Make sure that type PsiAnnotationMemberValue is in your classpath and check for conflicting dependencies with `-Ylog-classpath`.
[error] A full rebuild may help if 'ScExpression.class' was compiled against an incompatible version of com.intellij.psi.
[error]   override def expandMacro(macros: ScFunction, context: MacroInvocationContext): Option[ScExpression] = {
[error]                                                                                         ^
[error] C:\Users\WilliamCarter\workspace\ijext-sample-project\ijext\src\main\scala\org\jetbrains\scala\libextensions\test\MacroFooableSupport.scala:14:17: object ScParameterizedType is not a case class, nor does it have an unapply/unapplySeq member
[error]       case Some(ScParameterizedType(_, Seq(tp))) => tp.canonicalText
[error]                 ^
[error] C:\Users\WilliamCarter\workspace\ijext-sample-project\ijext\src\main\scala\org\jetbrains\scala\libextensions\test\MySampleInjector.scala:8:9: Class com.intellij.psi.PsiClass not found - continuing with a stub.
[error]     if (source.findAnnotationNoAliases("org.jetbrains.scala.libextensions.test.MySampleAnnotation") != null) {
[error]         ^
[error] three errors found
[error] (support / Compile / compileIncremental) Compilation failed
[error] Total time: 14 s, completed 11-Sep-2019 14:36:26

We can ignore the error about ScParameterizedType no longer having an unapply because it doesn't but the other errors are more suprising because I would expect the Scala plugin jar to provide these implementations. I've checked my classpath as the error suggests and it does include the scala plugin jars:

  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\bcel-6.0.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\bsp4j-2.0.0-M4.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\commons-lang-2.6.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\compiler-shared.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\config-1.2.0.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\evo-inflector-1.2.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\fastparse_2.12-0.4.3.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\ipcsocket-1.0.0.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\ivy-2.4.0.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\jamm-0.3.1.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\org.eclipse.lsp4j.generator-0.5.0.jar,None)

  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\org.eclipse.lsp4j.jsonrpc-0.5.0.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\org.eclipse.xtend.lib-2.19.0.M2.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\org.eclipse.xtend.lib.macro-2.19.0.M2.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\org.eclipse.xtext.xbase.lib-2.19.0.M2.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\runners.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\sbt-structure-core_2.12-2018.2.1+4-88400d3f.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\scala-compiler-indices-protocol_2.12-0.1.1.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\scala-nailgun-runner.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\scala-parser-combinators_2.12-1.0.6.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\scala-play-2-jps-plugin.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\scala-reflect.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\scala-xml.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\scalameta.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\scalap.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\scalariform_2.12-0.2.2.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\scalastyle_2.12-1.0.0.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\scalatest-finders-patched-0.9.9.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\scalaUltimate.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\sourcecode_2.12-0.1.3.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\spray-json_2.12-1.3.4.jar,None)
  ZipArchiveClassPath(C:\Users\WilliamCarter\.library-test-ijextPluginIC\sdk\192.6603.28\externalPlugins\Scala\lib\util-interface-1.1.2.jar,None)

The changes I've made to the example project can be found here: CarterWilliam/ijext-sample-project@1988606.

Fine tune plugin dependency resolution

Plugin resolution mechanism is currently hardcoded and cannot be fine-tuned to support following scenarios:

disabling transitive plugin resolution
disabling resolution of optional plugin dependencies
excluding some plugin dependencies from transitive lookup

generated run configuration should build the artifact first

At the moment run configuration generated by createIDEARunConfiguration doesn't include "Build artifact" step in "Before launch ...".
Thus the artifact is not automatically built before running debug IDEA.

-XX:+UseConcMarkSweepGC is deprecated

The plugin encodes "-XX:+UseConcMarkSweepGC" as default in org.jetbrains.sbtidea.runIdea.IntellijVMOptions. When running under JDK11, this results in error messages:

[error] OpenJDK 64-Bit Server VM warning: Option UseConcMarkSweepGC was deprecated in version 9.0 and will likely be removed in a future release.

Support SDKs other than IntelliJ IDEA

Still NumberFormatException in updateIntellij

#37 is resolved in b1e825d and released in version 3.3.1,
but now the below error shows up when rebooting sbt after successful installation.

(ThisBuild / updateIntellij) java.lang.NumberFormatException: For input string: "192-2147483647"

External plugins not attached

trying to update an internal plugin (just support some fields generated with scala macros) for 2019.1-beta.

have tried sbt-idea-plugin 2.1.3, 2.3.0, and 2.3.1. My only external dependency is the Scala plugin. This dependency doesn't work, because:

it is extracted into the plugins directory instead of the externalPlugins directory, meaning ideaExternalPluginsJars doesn't pick up any jars
the scala plugin is extracted into a Scala directory, even though it already has a top-level Scala directory in the zip - so there's nothing in Scala/lib for ideaExternalPluginsJars to find - it's in Scala/Scala/lib

@codingismy11to7

IDEA installation isn't invalidated when edition is changed

Plugin doesn't re-download IDEA sdk when ideaEdition setting is changed and sdk with the same version is already installed.

Warn on excessive plugin dependencies declaration

When adding a plugin dependency which is already transitively included by some other plugin dependency a warning should be printed.
This should be only done for non-optional dependencies.

Generated run configuration has wrong -Dplugin.path path

The path is taken from runner project, not the actual plugin project

Options search index generation

https://youtrack.jetbrains.com/issue/SCL-16414

Where does sbt-idea-plugin put source code for external plugins?

My build.sbt file looks like the following:

intellijPluginName in ThisBuild := "my-plugin"
intellijBuild in ThisBuild := "2019.3.3"
intellijExternalPlugins += "org.intellij.scala:2019.3.720:Nightly".toPlugin

name := "my-plugin"

version := "0.1"

scalaVersion := "2.13.1"

plugins.sbt:

resolvers += Resolver.url("jetbrains-sbt", url(s"https://dl.bintray.com/jetbrains/sbt-plugins"))(Resolver.ivyStylePatterns)

addSbtPlugin("org.jetbrains" % "sbt-idea-plugin" % "3.5.0")

sbt-idea-plugin was able to download the IntelliJ Platform SDK and Scala plugin.

Unfortunately, I was only able to find source code for the IntelliJ Platform SDK (it was downloaded to /home/my-plugin/sdk/2019.3.3/sources.zip and I had to manually set this folder as a source folder inside the IDE) but not for the Scala plugin.

Right now it looks like sbt-idea-plugin doesn't download source code for external plugins.

Add helper task to search for plugin id from a plugin name

Searching for a plugin id to provide as a dependency manually may be a time consuming task.
A decent alternative would be to implement a task that would search bundled and remote plugins for a plugin name(or maybe even description) and show plugin ids

updateIdea NullPointerException

with something like

lazy val ideaSettings = Def.settings(
  ThisBuild / ideaPluginName := "name",
  ThisBuild / ideaEdition := IdeaEdition.Community,
  ThisBuild / ideaBuild := "192.6603.28",
  ideaInternalPlugins := Seq("java"),
  ideaExternalPlugins += "org.intellij.scala::Nightly".toPlugin
)

[info] Resolving IDEA dependency for BuildInfo(192.6603.28,org.jetbrains.sbtidea.Defns$IdeaEdition$Community$@5a3428de)
[info] Downloading 2 IDEA artifacts
[error] java.lang.NullPointerException
[error]         at org.jetbrains.sbtidea.download.FileDownloader.$anonfun$getRemoteMetaData$2(FileDownloader.scala:108)
[error]         at org.jetbrains.sbtidea.download.package$.withConnection(package.scala:25)
[error]         at org.jetbrains.sbtidea.download.FileDownloader.getRemoteMetaData(FileDownloader.scala:100)
[error]         at org.jetbrains.sbtidea.download.FileDownloader.downloadNative(FileDownloader.scala:66)
[error]         at org.jetbrains.sbtidea.download.FileDownloader.download(FileDownloader.scala:21)
[error]         at org.jetbrains.sbtidea.download.IdeaUpdater.$anonfun$updateIdea$3(IdeaUpdater.scala:39)
[error]         at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:237)
[error]         at scala.collection.immutable.List.foreach(List.scala:392)
[error]         at scala.collection.TraversableLike.map(TraversableLike.scala:237)
[error]         at scala.collection.TraversableLike.map$(TraversableLike.scala:230)
[error]         at scala.collection.immutable.List.map(List.scala:298)
[error]         at org.jetbrains.sbtidea.download.IdeaUpdater.updateIdea(IdeaUpdater.scala:39)
[error]         at org.jetbrains.sbtidea.download.IdeaUpdater.updateIdeaAndPlugins(IdeaUpdater.scala:27)
[error]         at org.jetbrains.sbtidea.Init.$anonfun$buildSettings$12(Init.scala:53)
[error]         at org.jetbrains.sbtidea.Init.$anonfun$buildSettings$12$adapted(Init.scala:44)
[error]         at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error]         at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:62)
[error]         at sbt.std.Transform$$anon$4.work(Transform.scala:67)
[error]         at sbt.Execute.$anonfun$submit$2(Execute.scala:280)
[error]         at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:19)
[error]         at sbt.Execute.work(Execute.scala:289)
[error]         at sbt.Execute.$anonfun$submit$1(Execute.scala:280)
[error]         at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:178)
[error]         at sbt.CompletionService$$anon$2.call(CompletionService.scala:37)
[error]         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error]         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[error]         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[error]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[error]         at java.lang.Thread.run(Thread.java:745)
[error] (ThisBuild / updateIdea) java.lang.NullPointerException

No error reported when packaging a library mapping if the library itself is missing

When defining a mapping via packageLibraryMappings as key -> value and the moduleId defined by key is not resolved in the project's classpath(the library dependency is missing) no error is reported during artifact assembly and the mapping is just skipped.

@semkagtn

jetbrains / sbt-idea-plugin Goto Github PK

sbt-idea-plugin's Issues

How to reproduce

Configuration

Recommend Projects

Recommend Topics

Recommend Org

Jobs