jfrog / artifactory-orb

Artifactory Orb

JFrog Artifactory orb created in partnership with CircleCI.

Features

This orb supports the major features of the JFrog CLI, including uploading artifacts, build integration (collecting environment info, etc.), and publishing Docker images.

To limit the permutations of variables, advanced users may pass a File Spec.

Examples

For usage examples, see the src/examples directory or the listing in the orb registry.

Parameters/Configuration

See orb registry listing for complete parameters information.

Contributing

Issues and pull requests welcome!

This orb follows the general integration testing guidelines shown in this example and outlined in the following blog posts:

• https://circleci.com/blog/creating-automated-build-test-and-deploy-workflows-for-orbs
• https://circleci.com/blog/creating-automated-build-test-and-deploy-workflows-for-orbs-part-2

Orbs Authoring/Contributing

See Using Orbs and Creating Orbs to get started.

artifactory-orb's Issues

Build success but the status is "failure" without any navigating error

Orb version

What happened

I am using this orb for checking schema compatibility. I got the final result said "BUILD SUCCESS", but the status in "failure" without any error navigating. Could you help advise me how could I check the error detail or this is related to orb?

Expected behavior

If the build is success, the status supposes to be success as well or there's other possible issue which couldn't be shown in the log?

The orb examples do not pass validation

Orb version

Orb version 1.0.1

What happened

While looking at the examples I noticed that none of them pass validation.

❯ for f in $(ls) ; do
echo "Validating config $f"
circleci config validate $f
done
Validating config build-integration-command.yml
Error: ERROR IN CONFIG FILE:
[#] required key [jobs] not found
Validating config publish-docker-custom-build.yml
Error: ERROR IN CONFIG FILE:
[#] required key [jobs] not found
Validating config publish-docker-simple.yml
Error: ERROR IN CONFIG FILE:
[#] required key [jobs] not found
Validating config upload-job.yml
Error: ERROR IN CONFIG FILE:
[#] required key [jobs] not found

Expected behavior

It's possible i'm missing something but i would expect that all of the configs in the examples folder to be valid configurations.

Examples link to wrong orb

The examples link to the old orb name circleci/[email protected] but the proper orb name (i believe) would be jfrog/[email protected]

Jfrog artifactory orb documentation and misleading examples

Orb version

1.0.1

What happened

Jira orb documentation and examples dont match https://circleci.com/developer/orbs/orb/jfrog/artifactory-orb. Or simply if we follow documentation and then examples then the pipeline will fail.

Expected behavior

Orb should be able to help upload artifacts successfully to Artifactory without any errors

Replace deprecated image

Orb version

1.0.1

What happened

We use artifactory-orb/upload job, and CircleCI warns about using a deprecated image.

References:

• https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034
• https://circleci.com/blog/announcing-our-next-generation-convenience-images-smaller-faster-more-deterministic/
• https://circleci.com/docs/next-gen-migration-guide
• https://github.com/CircleCI-Public/cimg-base

Expected behavior

tl;dr I think we can switch to any of the new CircleCI images, e.g cimg/base, as we don't use the JDK or Java.

It doesn't seem we're building the tool from source, and the shell script used here (i.e https://getcli.jfrog.io , see source) does a good job at finding the correct binary distribution to use based on system architecture.

The link to the orb registry has the wrong orb name

The links in the README point to https://circleci.com/orbs/registry/orb/jfrog/artifactory but the actual link is https://circleci.com/orbs/registry/orb/jfrog/artifactory-orb.

Machine Executor Needs to be Updated by 5/31/22 per Circle CI

Orb version

1.0.1

What happened

Per https://circleci.com/docs/2.0/images/linux-vm/14.04-to-20.04-migration/, an executor with machine: true needs to be migrated to machine: image: ubuntu-2004:current (or some other version) by 5/31/22.
We use the orb in our projects and received emails from Circle CI that our builds were affected by this change.

Expected behavior

update the executor to use the new image.