jh3y / ep

enhance your HTML5 progress bars with minimal effort!

Hi! 👋

I'm Jhey.

For enquiries, reach out @ [email protected] or over on Twitter.

Stay awesome!

ep's Issues

Fix demo value update

Issue summary

If I set a value on either the spread style bar or standard style bar in the demo by first deleting the input value and then changing it, the value in the code sample won't update again

Expected behavior

No matter what I do with the input, the code sample should update if I input a valid number

Steps to reproduce

Delete the input value then input some valid value

@jh3y

Implement tests for optional JS helper

Issue summary

There are currently no tests in place for the optional JS helper.

Expected behavior

It would be ideal to have tests in place that ensure attributes/classes are applied/removed when necessary using particular methods. Also, the ability to test that callbacks are being properly applied.

Requirements

• Create testing bundle config for webpack.
• Use mocha and chai along with js-dom for testing.

@jh3y

Add CI for testing PR

Issue summary

Add support for CI in order to test incoming pull requests

@jh3y

Fixed position bottom styling makes bar invisible

Issue summary

When the bar is fixed-bottom in the demo, it disappears.

Expected behavior

Should see it fixed to the bottom of the page.

Browser used

Any.

Steps to reproduce

Check the demo, and change the positional demo to fixed-bottom.

Resolution

Instead of setting to bottom: 0, the bar position should be set to bottom: 6px or whatever the height of the bar is.

@jh3y

add a small js helper

It seems that a very small js helper could be added as an optional extra for mocking progress meters.

Something as simple as being able to provide (where progrecss is a variable instance of a progrecss);

  progrecss.start();

And

  progrecss.stop();

Can't see this being particularly hard to be honest.

@jh3y

Restructure src folder to be more intuitive

Issue summary

src folder structure is not intuitive. For example; style source living within src/script/entries. Instead, have things like script, style under relative entries.

Will require paths across src file imports and webpack config updates.

@jh3y

Title of demo page error

In the title of the demo page, there's no r, like there should be in progre(c)ss, so it says proge(c)ss. A quick look at the heading on the page tells me that there is an r in it.

Broken code samples in demo when changing value

Issue summary

When changing the value in the demo for a mock, staggered-mock or timer by deleting the value and then entering a new value, the entire code block becomes mangled.

Expected behavior

Value in code should updated to number value in input if necessary.

Steps to reproduce

Delete value in a number input, then input a number on demo.

@jh3y

Stop timer at certain percentage

Could you add a method that stop a timer at certain percentage? It might be helpful when someone will be creating an online test/survey —for example— and want the users to hurry up, then, as soon as they press a button, the timer will stop. Or maybe, like my case, if someone wants to show how much of something remains for the next step and timer is just perfect.

Fix background/foreground color issue in IE

Issue summary

In IE, some of the progress bars are two toned as if the foreground doesn't match the background

Expected behavior

Bars are colored properly?

Browser used

IE

@jh3y

give an example of AJAX extensions and prefiltering in docs.

I'm not 100% sure without having a look around but I am pretty sure you can write a prefilter for AJAX requests which means you can make a custom update progress function be run everytime an AJAX request is made.

Thomas Davis does something similar in backbone for cross domain requests in one of his examples.

I'll look into it unless anyone has an idea of it.

@jh3y

Please include dist...

Having to go into the ep folder after downloading it, and manually npm installing, and running make dist is a pain in the ass...

Not to mention, building needs additional configuration, as the Class EP element can't be converted to javascript properly out of the box (not using webpack, just bower / npm / node).

I had to make another .babelrc file with the following contents:

{
	"presets": ["es2015"]
}

in order to get make dist-script to work.

So please, for the love of god, for those who aren't using your exact development environment, or don't have any knowledge of debugging this kind of thing... please either include dist files of the latest build, or at the very least also include a .babelrc file so that make works without a webpack compiler.

Demo layout on small height screen

Issue summary

If I'm viewing the demo on desktop with the window at a small height. The intro and description for ep get cut.

Expected behavior

I should be able to scroll and see the rest of the content.

Browser used

Any.

Steps to reproduce

View the demo and resize the window to be a small height on desktop.

@jh3y

Staggered mock doesn't honour lower animation durations

Issue summary

On the demo, if I change the duration to <4, then the simulation doesn't show.

Expected behavior

I should see the simulation with the new animation duration specified from the input.

Steps to reproduce

Lower the value specified for duration in the demo.

@jh3y

add sass file.

Simply add a sass file for those using sass and not less.

@jh3y

basic mocking attribute

From feedback on HN it seems that the ability to be able to mock progre(c)ss easily out of the box would be appreciated.

This can be easily done with keyframes but I'd like to be able to do it with simply doing something like

     <div class="progrecss" data-progrecss="0" data-progrecss-mocking="32"></div>

This would create a progrecss bar that completes it's journey in 32 seconds from render.

This shouldn't be too much effort but I think a maximum of say 120 seconds should be put in unless people want to add their own after that's fine.

Could also add a class like staggered which would stagger the progrecss til completion time.

@jh3y

Align source version with package version + introduce yarn

Issue summary

• Source version 2.0.3 doesn't match package version 2.0.4, update to 2.0.5
• Dates in markup footer/license comment are out of date
• Introduce use of yarn

@jh3y

What are the browser requirements?

I love the idea, thanks for writing it ;)

I'm just curious - I didn't see on the website anywhere - What browsers does this require/work with?

README should mention relation to <progress> element

I'm surprised that the standard <progress> element isn't mentioned in your README.