Comments (13)
Your proposed change would instead conflict with D10: https://github.com/drupal/core-dev/blob/10.0.x/composer.json.
Do you really need drupal/core-dev? Are you running phpunit browser tests in the same environment? If not, you could drop the core-dev dependency and only require what you actually need.
from drupalextension.
Hmm, it is fairly common I think to run phpunit tests (based on core's base classes) in the same environments as Behat, so ideally we'd fix this conflict with drupal/core-dev
...
from drupalextension.
We could be compatible with two different versions of the same package, but we're talking about two different packages here, I don't think that's possible.
You can still explicitly require phpunit and other dependencies, just not the drupal/core-dev wrapper.
from drupalextension.
I think friends-of-behat/mink-browserkit-driver was forked to be compatible with PHP 8 and higher versions of Symfony, it could be deprecated, and should be changed on core-dev.
Maybe this is not the place.
from drupalextension.
Created PR on core-dev https://github.com/drupal/core-dev/pull/4/files, sorry for the noise.
from drupalextension.
It looks like from the comment on that PR you'll need to open an issue on drupal.org since the github repo is auto-generated.
from drupalextension.
Core isn't going to change this, it will not introduce possibly breaking changes in Drupal 9. The main point of drupal/core-dev is to be able to reliable run the same phpunit tests that core (and contrib) contains.
If you can't update to D10 yet then the only option is to not require drupal/core-dev but rely on the desired dependencies and versions directly. Might be worth mentioning this in the readme/release notes of 5.x
from drupalextension.
If the friends-of-behat
one is truly deprecated, wouldn't core update to the non-deprecated one? I'm having trouble finding documentation about the deprecations or preferred package though. This https://github.com/minkphp/MinkBrowserKitDriver seems more active than the friends one...
from drupalextension.
if the friends-of-behat one is truly deprecated, wouldn't core update to the non-deprecated one?
That's exactly what core did, but only in D10, as it was apparently considered a BC breaking change or maybe just not important enough. I wasn't involved in the issue and don't know the exact reason. But I can guarantee you that this will not be changed in a 9.5 patch release, so we just have to live with it.
from drupalextension.
ah, ok, I misunderstood.
from drupalextension.
Created issue on core https://www.drupal.org/project/drupal/issues/3343911
from drupalextension.
I'd like to summarise the above (after gathering information from the multiple sources):
-
Drupal Extension v5 is currently compatible with D9 and is tested to be compatible (in CI).
-
However, due to the issue described here it is not installable if the consumer site uses
drupal/core-dev
metapackage -
Currently, CI for Drupal Extension does not use
drupal/core-dev
, which "masks" this problem. -
@Berdir and @catch have discussed this on Slack and per @Berdir's comment in Slack:
Note that the mentioned incompatibility is with behat Drupal extension 5.x alpha. Committing this would in turn then cause the opposite conflict with the stable 4.x releases.
- It is now not clear what the intention of Drupal Extension to support D9 - supporting only sites that do not use
drupal/core-dev
is not a feasible option (https://github.com/drupal-composer/drupal-project prescribes it as a best practice).
@Berdir
Can we mark friends-of-behat/mink-browserkit-driver
(or whatever the conflict is) as a conflict for 9.5.x
branch and action the change for 9.6.x
branch (so that at least next minor D9 would support v5). The patch in https://www.drupal.org/project/drupal/issues/3343911 has passed CI, so technically it looks like it is stable.
I'm wondering if more considerations could be given by the core team.
from drupalextension.
There is no next minor Drupal 9 version, Drupal 9 is EOL in December. Either stick to using 3.x on Drupal 9 or don't use drupal/core-dev. And the medium/long-term fix that you have to do anyway this year is upgrading to Drupal 10.
from drupalextension.
Related Issues (20)
- Drop Drupal 7 support
- PHP 8.1 compatibility error: "$this" can no longer be used in a plain function or method since PHP 7.1
- Guzzle 7 issue HOT 3
- New step for press button in row HOT 1
- DrupalAuthenticationManager is confused about login state across scenario's
- Escaping in createNode() changed with PHP 8.1
- Test on PHP 8.2
- Creating a node with a certain URL alias HOT 1
- Disable automatic cleanup HOT 1
- Add a .readthedocs.yml configuration file HOT 4
- Fix failing D10 tests HOT 2
- Remove DrupalFinder HOT 2
- Write an upgrade guide to 5.x? HOT 1
- Drupal finder exception causes error - Cannot locate Drupal on a standalone behat installation. HOT 2
- PHP Fatal Error with PHP 8.2 when using `drupal` api driver HOT 3
- Content loaded via BigPipe is sometimes not available by the time steps are executed, leading to random failures
- Add step definition for dragging one element onto another
- behat/mink-goutte-driver is deprecated and getting this error on PHP 8.2 "Install MinkGoutteDriver in order to use goutte driver.".
- Drupal 11 support HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drupalextension.