GithubHelp home page GithubHelp logo

Remove DrupalFinder about drupalextension HOT 2 CLOSED

sylus avatar sylus commented on August 16, 2024
Remove DrupalFinder

from drupalextension.

Comments (2)

pfrenssen avatar pfrenssen commented on August 16, 2024 1

The dependency on DrupalFinder was introduced recently in #628.

For us it makes sense to use DrupalFinder rather than implement our own discovery mechanism. It is the standard way to find the root of a Drupal installation and the location of the vendor folder. Is very widely used (26 million installs) and since it is a hard dependency of Drush it can be found on the vast majority of Drupal projects.

The library is not perfect, and from the issues you linked it is clear that it is affected by some bugs that prevent the correct location from being found.

Would it be in any way possible to get these issues fixed upstream in the DrupalFinder project itself?

from drupalextension.

sylus avatar sylus commented on August 16, 2024 1

Yeah that makes sense to me ^_^

Thank you for the considered response I didn't even realize it was part of Drush.

For now I just reverted to 5.0.0-alpha1 and it allowed my behat tests to run successfully.

I'll look at the issues over in DrupalFinder and see if can find a way to ideally provide an override where you can specify the docroot path if there are competing composer.json files!

from drupalextension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.