jifalops / app-toast Goto Github PK

First of all a very superb component >>> paper toast.

Some of the things I would like to point out and fix if a PR is approved.

1. Why do you need the reset properties? it is redundant as properties are already set with their value.
2. From 1. this creates complications like setting properties via show method which is not how they should be set, instead they should be passed via individual property bindings or set on the element on declaration.
   e.g
   Setting on the element

<app-toast show-cancel></app-toast>

Hey, very nice web component! Are you interested in updating this for polymer 2? Or possibly making it a hybrid component to work with both Polymer 1 and 2? I would definitely be interested in helping with this update in my free time if you are open to it.

If starting a swipe but not completing it, the close/cancel icon on the toast stops working. Tested on Chrome. Workaround is to not use both swipe and the cancel icon at the same time.