GithubHelp home page GithubHelp logo

Comments (4)

jillesvangurp avatar jillesvangurp commented on May 29, 2024 1

I agree, this is the better fix. I changed this because I see uses for JsonDsl beyond the search client. But it is a bit error prone to deal with so I'm fixing this properly with a separate pull request.

from kt-search.

jillesvangurp avatar jillesvangurp commented on May 29, 2024

right, I'll have a look at that one. Thanks for reporting

from kt-search.

jillesvangurp avatar jillesvangurp commented on May 29, 2024

Wow, this was broken in a lot of places. I changed the naming convention to default to asIs at some point without realizing I had to fix this all over the DSL. Fixed by #28

from kt-search.

yassenb avatar yassenb commented on May 29, 2024

Thanks but why was the default switched to "asIs"? Look at the many places where you need to override it and potential future extensions will have to be careful to override as well. Why not default to snake case when this is the default for OpenSearch/ElasticSearch?

from kt-search.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.