jinjor / elm-contextmenu Goto Github PK

During my work on #6 I have seen that some of your code is never used. Please fix this:

1. src/Styles.elm line 95: The disabled flag is never used in your code.

   annotation : Color -> Float -> Float -> Bool -> Style msg
   annotation color annotationHeight fontSize disabled =
       [ style "margin-top" "-2px"
       , style "line-height" (px annotationHeight)
       , style "font-size" (px fontSize)
       , style "color" color
       ]

2. src/Styles.elm line 117: The borderWidth setting is never used.

   partition : Float -> Float -> Style msg
   partition borderWidth margin =
       [ style "border-bottom-style" "solid"
       , style "border-bottom-width" (px 1)
       , style "border-bottom-color" borderColor
       , style "border-top" "none"
       , style "margin" (px margin ++ " 0")
       ]

3. src/ContextMenu.elm line 42 and 49: The imports Browser and Process are never used in your code. You can safely remove them.

Great work, thank you !

I've had to modify you code in this line:
github.com/jinjor/elm-contextmenu/blob/master/src/ContextMenu.elm#L521

"contextmenu"-->"click"

Because I needed the menu to open on left click.

I needed to change the position: fixed style to position: absolute for it to work correctly.
Just so you know 😉 I think it has something to do with the scroll position?

PS. Thanks for this library!

Hey is there any way to make the context menu stay open until the cursor is moved off the menu?