jiridj / hugo-collapsible-code Goto Github PK

Hi thanks for the shortcode — it wasn't working for me and I finally figured out that in the "makeCollapsible" function, this line:

if (div.offsetHeight > height {

Needs to be changed to:

if (div.offsetHeight > parseInt(height, 10)) {

Because the maxHeight (max-height in CSS) property is not a number, it's a string with a 'px' at the end.

Likewise the var height at the top needs to be set to '300px' rather than just 300. Is this something that changed in the last few years since you made this? Possibly. Thanks!

Hi I am confused about what shortcode options are available to me. I ask because in code.html it shows that it can accept two different arguments.

Secondly, what syntax highlighting options are available for the shortcode?

Thirdly, and slightly unrelated, I would suggest a faq for the readme so I newbs at frontend (like me) can try to debug common problems. (For example, it took me a while to realize I had to reference the stylesheet and the script somewhere in my project's Hugo framework)

Great project btw. I got it to work. Will probably find more places to use it 👍