No Such Method Error when shading the plugin into my own plugin about npclib

[arnhav]

So, I should probably clarify. I was a bit of a noob and said "shade" when I didn't actually shade the API into my own plugin. I added the plugin version of NPCLib as a dependency. I just shaded (actually this time) the API into my own plugin (I use Maven and I use IntelliJ) and now I'm getting another error:

java.lang.NullPointerException: null
	at com.mc_atlas.atlasmachinationsaddon.npclib.NPCLib.createNPC(NPCLib.java:80) ~[?:?]
	at com.mc_atlas.atlasmachinationsaddon.npclib.NPCLib.createNPC(NPCLib.java:96) ~[?:?]
	at com.mc_atlas.atlasmachinationsaddon.util.NPCSpawner.spawnTownSteward(NPCSpawner.java:16) ~[?:?]
	at com.mc_atlas.atlasmachinationsaddon.util.DatabaseManager.loadCitizens(DatabaseManager.java:97) ~[?:?]
	at com.mc_atlas.atlasmachinationsaddon.AtlasMachinationsAddon.onEnable(AtlasMachinationsAddon.java:108) ~[?:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:265) ~[paperclip.jar:git-Paper-"c36f2062"]
	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:334) ~[paperclip.jar:git-Paper-"c36f2062"]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:412) ~[paperclip.jar:git-Paper-"c36f2062"]
	at org.bukkit.craftbukkit.v1_13_R2.CraftServer.enablePlugin(CraftServer.java:443) ~[paperclip.jar:git-Paper-"c36f2062"]
	at org.bukkit.craftbukkit.v1_13_R2.CraftServer.enablePlugins(CraftServer.java:357) ~[paperclip.jar:git-Paper-"c36f2062"]
	at net.minecraft.server.v1_13_R2.MinecraftServer.l(MinecraftServer.java:608) ~[paperclip.jar:git-Paper-"c36f2062"]
	at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:570) ~[paperclip.jar:git-Paper-"c36f2062"]
	at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:431) ~[paperclip.jar:git-Paper-"c36f2062"]
	at net.minecraft.server.v1_13_R2.DedicatedServer.init(DedicatedServer.java:316) ~[paperclip.jar:git-Paper-"c36f2062"]
	at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:787) ~[paperclip.jar:git-Paper-"c36f2062"]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_152]

EDIT:
So it looks like I was adding in an extra step... I just had to compile the plugin during the package phase of Maven. Marked as resolved.

[JitseB]

Hi there, thanks for opening this issue!

Could you first provide me with some information on what version of NPCLib you're using? And how you are shading the JAR?

[arnhav]

Latest version of NPCLib (1.4.1 I think)

I've simply added the plugin itself as a dependency. (This issue did not occur with version 1.3)

[arnhav]

Any updates on this?

I've ran into this same issue with NPCLib version 1.4.1 using Paper Spigot 582. The stack trace is identical, and does not reproduce when using NPCLib version 1.3.

[JitseB]

I might know how this occurred. Are you @arnhav11 (and @AvANight) creating the NPCLib instance before or after the onEnable method is called?

My apologies for my late reply. I've been incredibly busy with school.

[arnhav]

No worries.

I was instantiating the NPCLib in the onEnable() method. I'm not sure what you mean by before or after...

[EazyFTW]

Same issue. Looks to be something to do with TinyProtocol.

[EazyFTW]

Hm.. I still get the error using gradle, although it works fine using the 3.0 version of NPCLib.

[JitseB]

This is actually something that's caused by the support of 1.7 R4. It's actually frustrating me so much that I'll be porting 1.7 R4 support to a legacy branch of NPCLib.

Should soon be sorted!

[JitseB]

Will be solved in the same version as the fix for #17.

[JitseB]

Fixed in release 1.4.2!