jitseb / npclib Goto Github PK

text doesn't update, please fix it.

Fixed, just forgot to create the npc. I'm stupid x)

Describe the bug
The NPC's do not show after a respawn.

NPCLib usage option
2

NPCLib JAR name
npclib-plugin-2.5-SNAPSHOT.jar

Server version
Paper version git-Paper-172 (MC: 1.15.2) (Implementing API version 1.15.2-R0.1-SNAPSHOT)

To Reproduce
Steps to reproduce the behavior:

• at respawn event, i check if the npc is shown to the player.
• it says, that npc is shown to the player every time.
• after i fly out of the auto hide range, and fly back in again, the npcs show.

Expected behavior
I expected to see the npcs

Could you add Minecraft 1.15 compatibility? I could do a merge request but I don't really know about NMS D:

Describe the bug
When you try to join to a spigot server 1.8.8 using ViaVersion and minecraft client 1.14.4 you get kicked with the exception: ArrayOutOfBoundsException 6, im using the last version of ViaVersion.

NPCLib usage option
1

NPCLib JAR name
Lastest jar

Server version
This server is running CraftBukkit version git-Spigot-db6de12-18fbb24 (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)

Screenshots
Console log when i try to join and viaversion kicks me

[14:26:17 INFO]: UUID of player CleusGamer201 is bdb39cc3-7782-3a37-9f8f-20ee8de60fa0
[14:26:18 WARN]: [ViaVersion] Ignoring plugin channel in outgoing REGISTER: WECUI
[14:26:18 INFO]: CleusGamer201[/...:19668] logged in with entity id 16 at ([world]-1240.7532660643817, 17.0, -857.759500022689)
[14:26:23 INFO]: CleusGamer201 lost connection: Disconnected
[14:26:23 WARN]: handleDisconnection() called twice
[14:26:23 INFO]: CleusGamer201 left the game.

Describe the bug
In the spigotmc repository, you say, that it supports 1.14.4, but it doesnt Load

NPCLib usage option
3

NPCLib JAR name
npclib-api-2.0.1-SNAPSHOT.jar

Server version
This server is running CraftBukkit version git-Spigot-798ea6a-44d675a (MC: 1.14.4) (Implementing API version 1.14.4-R0.1-SNAPSHOT)

Describe the bug
the holograms are broke,
they change the item meta injection from what i read.

NPCLib usage option
last version available

NPCLib JAR name
npclib-plugin-2.4-SNAPSHOT

Server version
103 paper , 1.15.2

To Reproduce
Steps to reproduce the behavior:
u see the armor stand above the npc

Expected behavior
like before it shows hologram with text and not the armor stand.

Screenshots
https://imgur.com/a/S74Oo4w

Additional context
as i said from what i read:
https://www.spigotmc.org/threads/holograms-break-on-1-15.408675/
https://www.spigotmc.org/threads/entityarmorstand-doesnt-work.417113/

hope its help

Spawning the NPC works fine and everything but the skin is missing for some reason. I already tried with multiple skins, versions, and an added delay for showing the NPC.

No error messages and NPCLib loads correctly.

NMS Version: v1_8_R3
NPCLib Version: 2.0

@EventHandler
public void onJoin(PlayerJoinEvent e) {

    MineSkinFetcher.fetchSkinFromIdAsync(725954, skin -> {
        NPC npc = npcLib.createNPC(Arrays.asList(ChatColor.WHITE + "test")).
                setLocation(e.getPlayer().getLocation()).
                setSkin(skin).
                create();

        Bukkit.getScheduler().runTask(this, () -> npc.show(e.getPlayer()));
    });

}

Describe the bug
My NPCs spawn but if I remove the default skin and another MineSkin, they will disappear after a while. Then when I move away from them and come back they are back. Please help

NPCLib usage option
NPCLib can be used in multiple ways, please provide the number corresponding to your usage option.

NPCLib JAR name
npclib-plugin-2.5.1-SNAPSHOT.jar

Server version
1.8.8

Hello,

i want to suggest to add labymod support. I mean with labymod support the emote api.
For this feature you need the ability to change the uuid. (https://docs.labymod.net/pages/server/emote_api/) out of the docs the uuid needs to be " emotes can only be forced for players that have the second half of their UUID entirely being 0 (-> 64 least significant bits are 0, or the second long value equals 0)". You could add also the method for playing a emote.

I already done this on a fork (https://github.com/rexlManu/NPCLib/blob/master/api/src/main/java/net/jitse/npclib/internal/NPCBase.java#L58) but i just rushed it into the lib and i think its not really nice placed in the class, so i think its better when u add it to the lib in your way, i hope you know what i mean.

Hey! i saw this epic NPCLib api ur making here guys, tho i see Jitse really active -> credit to all if needed <3

im working on implementing this plugin of yours in one of mine, which will use your lib to create interactive inventory per arena/mini-game join - and all that logic of what inventory to show when and which game its belong to.

till now i handled all throe sign, which i dont like.

i also want to implement on top of ur code packets of entity move. tho i use protocol lib for that.
so my question is -> do you have any plan in the future to add custom random walk in radios of loc? or like watch an entity when it is close to him, stuff like that to make them more alive?
im talking about stuff like:
Entity Look And Relative Move packet or Entity Look packets send to all players who sees him.
so the npc can walk around and watch people like goalpathfinder -> just simpler.

i pretty much wanna use only ur lib to handle all my npc stuff explosively, as citizen2 is super heavy and its cost effective for what im looking for is not good... im looking to create alot of custom npc which will walk around the city and also handle quests in the further (beside joining a minigame)
at the end:
before i found this lib i thought to do the same as you guys and create customs npc by NMS or make one with pure packets, so im really happy to find this epic lib which is coded simple and powerful.

Thanks, i didn't know if i should open a ticket or just leave a msg in the discussion of this plugin in spigot. but any way -> keep up the good work.

org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:302)
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:528)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:513)
at net.minecraft.server.v1_8_R3.PlayerList.attemptLogin(PlayerList.java:506)
at net.minecraft.server.v1_8_R3.LoginListener.b(LoginListener.java:114)
at net.minecraft.server.v1_8_R3.LoginListener.c(LoginListener.java:50)
at net.minecraft.server.v1_8_R3.NetworkManager.a(NetworkManager.java:231)
at net.minecraft.server.v1_8_R3.ServerConnection.c(ServerConnection.java:167)
at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:1001)
at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:422)
at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:760)
at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:663)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NullPointerException
at sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57)
at sun.reflect.UnsafeQualifiedObjectFieldAccessorImpl.get(UnsafeQualifiedObjectFieldAccessorImpl.java:38)
at java.lang.reflect.Field.get(Field.java:393)
at com.comphenix.tinyprotocol.Reflection$1.get(Reflection.java:153)
at com.comphenix.tinyprotocol.TinyProtocol.getChannel(TinyProtocol.java:260)
at com.comphenix.tinyprotocol.TinyProtocol.access$800(TinyProtocol.java:29)
at com.comphenix.tinyprotocol.TinyProtocol$5.onPlayerLogin(TinyProtocol.java:156)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:300)
... 14 more

Describe the bug
I can see the NPCs but sometimes they randomly despawn although I'm in range.

NPCLib usage option
1

NPCLib JAR name
npclib-plugin-2.3-SNAPSHOT.jar

Server version
CraftBukkit version git-Spigot-db6de12-18fbb24 (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)

To Reproduce
Used this code:
` NPC pirateJoeNPC = Main.getInstance().getNpcLib().createNPC(Arrays.asList("§aPirate Joe", "§7¡Ven aquí todos los días", "§7y te daré recompensas!", "§e§lCLICK"));

    pirateJoeNPC.setLocation(new Location(Bukkit.getWorld("world"), -81, 62, 0, -90, 0));
    pirateJoeNPC.setSkin(new Skin("eyJ0aW1lc3RhbXAiOjE1NjM3NTA4MzkwNzksInByb2ZpbGVJZCI6ImIwZDRiMjhiYzFkNzQ4ODlhZjBlODY2MWNlZTk2YWFiIiwicHJvZmlsZU5hbWUiOiJ4RmFpaUxlUiIsInNpZ25hdHVyZVJlcXVpcmVkIjp0cnVlLCJ0ZXh0dXJlcyI6eyJTS0lOIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvYTk1NjMyMDQ2YjZjMjcxNGE2YzE2Yjk3NzNjODNjNjRjNDE5NTRkMWZkMjZlZGNhNzA0NjgyYjQ4Y2FlODlkMCJ9fX0=",
            "rAlrow/DYrJPcKvuEDvI3QrgcgDiez3pCeF//Oe+3kvBHFqv/OkLRbVZwaNpQRCdbw0cGxweqItSjkNiPOu4Y7rcQLM7YcTYYrcu9UvhK/kZTvFHfmJFjPD95foI0qwIKqAkccJuTvsQlLFTKZK1QYhrTDlsRo/0HuIwVCDsEkSY0tZ991w5OMGHa+DI5YFk93RvmsG1iOyjz9Ps+lZjKSIP1iHvnY45DfeJt1ouFH5O9QJyzIQJrlv9QvcfZDYRrB6A6+M1Qhp3diI0P0wIDFsn8a4210A4LhhfKeU+Rq6aCBuxL8Ac+DR5+6adBkhh13x+0RF/AKPgMgAixUISoLAPqP27qJol8YjmpNju8njnnPeWZTSS8fd0QXeGH9lj1gfd/GyTf5+ClQNn/QFhjpmvxrrd5UuRdYedla4vDSufEJ/wMgDZ5i2IrmKGatiK0iEqpwv0ZNqvhmGhwcBtYXmyVezthWQtjIDkzwGlOI8HIxIpvlsoQ4UQOkbn/UiSlpFPlKpQ0I+3YCOHcS8V75JfrmDkjFqlC3QfEpKpFwCXBH0jNRNmg0rXVUYMq+2D/t6G2ALo8JeUJhNBfccCdrWDt8TigD5GL5j4czOHj9VQ8e6fIhrwJmQYrD1qUKFP/Ss3hQiF3r8XowoQ71ib8ji/mN5RdiqsmcbHcnPYd6k="));
    pirateJoeNPC.setItem(NPCSlot.MAINHAND, new ItemStack(Material.GOLD_INGOT));
    pirateJoeNPC.create();`

To spawn the NPC
And whenever the player joins i use this:
for(NPC npc : Main.getInstance().getNpcManager().getNpcInteractions().keySet()) { npc.show(player); }
(which works cause i get to see the npcs, but they disappear randomly)

Expected behavior
They should not disappeaar if im in range and i havent used the .hide function.

Thanks for reading :)
If you want to join the server or any extra info add me on discord: HugoGamerStyle#0286

https://i.imgur.com/hPoggkV.png

Describe the bug
NPCInteractEvent is fired twice. (One time per hand) but NPCInteractEvent does not offer the EquipmentSlot to determine the hand of the interaction.
https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/EquipmentSlot.html

NPCLib usage option
https://github.com/JitseB/NPCLib#2

NPCLib JAR name
npclib-plugin-2.4-SNAPSHOT

Server version
CraftBukkit version git-Spigot-8faa8b4-fba9f48 (MC: 1.15.2) (Implementing API version 1.15.2-R0.1-SNAPSHOT)

To Reproduce
Listen to NPCInteractEvent, and print something in the console. It will print it twice.

Expected behavior
EquipmentSlot to be added to determine the hand of the interaction.

The autohide distance is not working. It defaults to around 12 blocks, even when setting the value. I tried setting it to 500, and it is still the same.

I found an error, the skinsrestorer from which I get the skin switched to bungeecord mode and there is no API for getting skins.

Describe the bug
When I work with BungeeCord and SkinsRestorer and NPCLib NPC skins doesn't work.
Everything worked well until I switched to bungeecord. For plugins such as Citzens, the NPC skin continues to display.

NPCLib usage option
NPCLib can be used in multiple ways, please provide the number corresponding to your usage option.

NPCLib JAR name
npclib-plugin-2.0.1-SNAPSHOT.jar

Server version
This server is running Paper version git-Paper-210 (MC: 1.14.4) (Implementing API version 1.14.4-R0.1-SNAPSHOT)
This server is running Waterfall version git:Waterfall-Bootstrap:1.14-SNAPSHOT:c354548:295 by md_5

To Reproduce

• On server start load NPC, skins etc..

Skin npcSkin = new Skin(property.getValue(), property.getSignature());
NPC.setSkin(npcSkin);

• On player join use async later task (20 ticks)
  getNPC().show(player);

Expected behavior
Alex skin will be displayed.

Describe the bug
i made a new class called NpcManager which implements Listener and handle all the npc i use with the plugin. as all 3 examples shows - on join event it create a personal npc on a specific location
and on left/right click - it opens an custom inventory of the player data.

NPCLib usage option
option 2

NPCLib JAR name
npclib-plugin-2.3.1-SNAPSHOT

Server version
This server is running Paper version git-Paper-226 (MC: 1.14.4) (Implementing API version 1.14.4-R0.1-SNAPSHOT)

To Reproduce
Steps to reproduce the behavior:

• Used code for join event: (all work - npc registered and showed per player)
  @eventhandler
  public void onPlayerJoinEvent(PlayerJoinEvent event) {
  Player p = event.getPlayer();
  //ADD a PLAYER SELF LOOK from the location (playerSelfLoc) which is saved while loading the data of the plugin.
  if(playerSelfLoc != null) {
  //SHOW THE NPCPLAYER TO PLAYER
  List textToNpc = new ArrayList<>();
  textToNpc.add(ChatColor.BLUE + " hey " + ChatColor.WHITE + p.getName());
  NPC playerNpc = npcManager.createNPC(textToNpc);
  privatePlayerNPC.put(p.getUniqueId(), playerNpc);
  playerNpc.setLocation(this.playerSelfLoc);
  playerNpc.create();
  playerNpc.show(p);
  }
  ....
  ....
  }

• Used code for interaction event: (NOT working - never get the string on console nor anything else)
  @eventhandler
  public void onNPCInteract(NPCInteractEvent event) {
  System.out.println("ITS A PLAYER INTERACTING WITH NPC!");
  Player player = event.getWhoClicked();
  ....
  ....
  ....
  }

Expected behavior
expetec behavior is to get the println on the console - but that never happen.

i didn't had the time to go into the source code and find why, but if i find a solution before
i will be sure to update here.

i dont think its an huge problem probably a missing step - tho i saw all 3 examples and its pretty much the same, also i dont get any error and beside the interaction everything else related and happen over that class -> is working as needed.

Cheers,
plutto.

for some reason beside 1.14 which i did manage to update and download...
rest of marven are broke even tho i checked on the site and updated marven according

org.spigotmc
spigot-api
1.X.X.X-SNAPSHOT
provided

the change was needed is on line:
spigot-api

using https://hub.spigotmc.org/nexus/#view-repositories;snapshots~browseindex

i cant believe i lost 1-2 hours trying to stackoverflow it and yet cant sit and try to update and implement the actual code for 1.15.2 lol

Hello,

i want to suggest to add slimeworldmanager support.
I already figured out what the problem is why armorstands cant be spawned. Thats because of the
worldserver class, you just need to get the superclass of it.

Custom skin not rendering correctly whilst respawning NPC.

Video by @MrMicky-FR:
https://youtu.be/NC5dDBX6pDA

Possible fix:
When the player isn't using the chunk's data sent by the server the NPC tends to mess up its skin. Therefor a possible fix for this issue would be to check if the NPC (to be spawned) is behind the player or whether the player is looking down.

It seems like the NPC's custom skin is not rendered properly if the entity is out of the field of view of the player.

Describe the bug
NPC's keep disappearing randomly when the player joins the server. If they rejoin they normally reappear.

NPCLib usage option
Code: https://hastebin.com/ixumoleyon.java

NPCLib JAR name
2.4, LATEST

Server version
Spigot 1.8.8 (Custom built, but no real changes from default BuildTools spigot except disabling /pl and /about)

To Reproduce
Steps to reproduce the behavior:

• Join the game and see the NPC not appear

Expected behavior
NPC to spawn + NPC nametag to spawn

Screenshots
https://photos.bghddevelopment.com/u/17.40.23-12.03.20.png

Additional context
This is completely random it can happen on some joins, and not on others. When the player who has the issue rejoins it normally works fine then.

Hey,

so a few days ago, I asked myself if its possible to edit a NPCs text even if he's already created and displayed to a player.
I didn't found any way to to that, so I hope to get some help on GitHub :)

fel1x

Hey there, will there ever be a way to change the NPC Entity type?
E.g: making the NPC a Zombie, Skeleton, etc

Thanks,
Rainnny

[00:58:13 INFO]: [INFO] Started initialization.
[00:58:13 ERROR]: [NPCLib] Failed to initiate. Your server's version (v1_8_R3) is not supported
[00:58:13 INFO]: [INFO] Loading classes...
[00:58:13 INFO]: [INFO] NMS version: v1_8_R3
[00:58:13 INFO]: [INFO] Loaded classes
[00:58:13 INFO]: [INFO] Initialized event callers.
[00:58:13 INFO]: [INFO] Initialized event listeners.
[00:58:13 INFO]: [INFO] Initialized commands.
[00:58:13 INFO]: [INFO] Storage Type: YAML
[00:58:13 INFO]: [INFO] Successfully loaded PremiumHub (5.2.2-BETA)

this is in my log, using this version of spigot : 
[00:58:46 INFO]: This server is running CraftBukkit version git-Spigot-db6de12-18fbb24 (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)
[00:58:46 INFO]: You are 1718 version(s) behind

https://i.eazyftw.com/9PGikJS

Happens sometimes when loading NPC.

When spawning more than 3 NPC's sometimes only a certain amount of them load.

Hi there,

I just created NPC's for my server and stored them inside a config (NPC ID, Location, skinvalue, skinsignature etc..) but I would like to know if it's possible to update the text above the head of the NPC (this is my playercount for BungeeCord), and if it's possible, how can I do that? Same for; how to destroy them? Cause in events I can get the NPC ID en check if it's in my config but in methods i can't.

I hope u can help me.

Kind regards,
Franck

Describe the bug
It is saying that the method doesn't exist, and errors out.

NPCLib usage option
1 (Shade npclib-plugin.jar in to your plugin.)

NPCLib JAR name
npclib-plugin-2.0.1-SNAPSHOT.jar

Server version
Paper version git-Paper-641 (MC: 1.13.2) (Implementing API version 1.13.2-R0.1-SNAPSHOT)
You are running the latest version

To Reproduce
Create a NPC using the Lib.

Expected behavior
It would create the npc w/ no errors.

Screenshots

[06:14:04 WARN]: Exception in thread "Thread-51" java.lang.NoSuchMethodError: net.jitse.npclib.NPCLib.createNPC(Ljava/util/List;)Lnet/jitse/npclib/api/NPC;
[06:14:04 WARN]: at net.vast.pvp.modules.npc.DJCreepz.lambda$onEnable$1(DJCreepz.java:31)
[06:14:04 WARN]: at net.jitse.npclib.api.skin.MineSkinFetcher.lambda$fetchSkinFromIdAsync$0(MineSkinFetcher.java:47)
[06:14:04 WARN]: at java.lang.Thread.run(Thread.java:748)

Other info

[06:14:04 INFO]: [net.vast.pvp.VastPvP] [NPCLib] Enabled for MC v1_13_R2
[06:14:04 INFO]: [net.vast.pvp.VastPvP] [NPCLib] Attempting to inject into netty

Loads fine. I think?

Hi, got this error when i join and move:

[20:07:41 ERROR]: Could not pass event PlayerMoveEvent to CsLobby v1.0.1
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot.jar:git-Spigot-21fe707-e1ebe52]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-21fe707-e1ebe52]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot.jar:git-Spigot-21fe707-e1ebe52]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:270) [spigot.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.PacketPlayInFlying.a(SourceFile:126) [spigot.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.PacketPlayInFlying$PacketPlayInPosition.a(SourceFile:57) [spigot.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.PlayerConnectionUtils$1.run(SourceFile:13) [spigot.jar:git-Spigot-21fe707-e1ebe52]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_242]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_242]
        at net.minecraft.server.v1_8_R3.SystemUtils.a(SourceFile:44) [spigot.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:715) [spigot.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:374) [spigot.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:654) [spigot.jar:git-Spigot-21fe707-e1ebe52]
        at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:557) [spigot.jar:git-Spigot-21fe707-e1ebe52]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
Caused by: java.lang.NoSuchFieldError: hasTeamRegistered
        at net.jitse.npclib.nms.v1_8_R3.NPC_v1_8_R3.sendShowPackets(NPC_v1_8_R3.java:67) ~[?:?]
        at net.jitse.npclib.internal.NPCBase.show(NPCBase.java:163) ~[?:?]
        at net.jitse.npclib.listeners.PlayerListener.handleMove(PlayerListener.java:98) ~[?:?]
        at net.jitse.npclib.listeners.PlayerListener.onPlayerMove(PlayerListener.java:68) ~[?:?]
        at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source) ~[?:?]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_242]
        at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_242]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot.jar:git-Spigot-21fe707-e1ebe52]
        ... 15 more
>

Hello,

when im shading your plugin into mine for the library then the plugin.yml gets overrided by yours.
So i would suggest to add a module like npclib-library without spigot dummy stuff

Describe the bug
Upon joining, NPC IDs are temporarily visible in the tablist display. Their IDs are shown as player names.

NPCLib usage option
Plugin installation with API usage by my own plugin.

NPCLib JAR name
npclib-plugin-2.1-SNAPSHOT.jar (Planning on updating soon)

Server version
PaperSpigot 1.8.8 CraftBukkit version git-PaperSpigot-"4c7641d" (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)

To Reproduce

1. Create NPC
2. Call NPC#show in PlayerJoinEvent.
3. Press TAB when joining and see IDs in tablist.

Expected behavior
No NPC IDs are visible in tablist since they are not normal players.

Screenshots
If you need a screenshot of the issue I can provide it. However, it's quite trivial, and wouldn't be very informative.

Additional context
I am using my own Skript addon to call NPC#show when a player joins. The effect should be the same, however, whether it is Skript or a normal Java plugin which calls NPC#show.

All other NPCLib features work as expected.

11:49:53 [INFORMACIÓN] [CleusGamer201] <-> ServerConnector [Lobby] has connected 11:50:08 [GRAVE] [CleusGamer201] <-> DownstreamBridge <-> [Lobby] - encountered exception java.lang.IllegalArgumentException: Team 09e2bc9b88 already exists in this scoreboard at com.google.common.base.Preconditions.checkArgument(Preconditions.java:191) at net.md_5.bungee.api.score.Scoreboard.addTeam(Scoreboard.java:73) at net.md_5.bungee.connection.DownstreamBridge.handle(DownstreamBridge.java:206) at net.md_5.bungee.protocol.packet.Team.handle(Team.java:122) at net.md_5.bungee.netty.HandlerBoss.channelRead(HandlerBoss.java:104) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:323) at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310) at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:426) at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:278) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1434) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:965) at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:163) at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:656) at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:591) at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:508) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:470) at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:909) at java.lang.Thread.run(Unknown Source) 11:50:08 [INFORMACIÓN] [CleusGamer201] disconnected with: §fIllegalArgumentException : Team 09e2bc9b88 already exists in this scoreboard @ com.google.common.base.Preconditions:191 #I' have conected after it, 18 minutes later kicked me again with the same errror

I'm using Spigot-1.8.8 with BungeeCord Last Build,

Some times when you are left from the range vision and goes to the npc kick the player with this exception. And when i used npc.show(player, true); the npc do not appears and the player is in the range vision

PD: Sorry for my bad english!

A method to refresh the hologram above NPC's head.

Version: 2.0.1-SNAPSHOT

First thing I wanted to mention is that I got an error on serverstart:
[ERROR] NPCLib Failed to initiate. Your server's version (v1_13_R2) is not supported

I suspect that the problem may lie here? I don't know why I get this error though since you say your plugin api supports 1.8 - 1.14.4

Server log: https://pastebin.com/2TggBrhU
Code: https://pastebin.com/mmATSWAS

I debugged a little bit and I noticed that npc is still null even after this line:
npc = npcLib.createNPC(Arrays.asList(name));

So my guess is that something is going wrong there.

I hope you can help me with my issue

Regards Bjarne

How do i setup the plugin??? iam a noob.. i know
i've found the jar file but when i import it and reload my server i dont get a folder called NPCLib

It would be great if skins could be loaded from disk.
At the moment I'm running into issues with NPC's skins not loading when creating multiple NPC's on server start and showing when a player joins (NPC's created without the MineSkin fetcher load fine). However if I recreate the NPC's while the player is on the server they load fine, most of the time.

NPCLib usage option
1

NPCLib JAR name
npclib-plugin-2.0.1-SNAPSHOT.jar

Server version
Spigot 1.8.8

To Reproduce

private NPCLib library;

@Override
public void onEnable() {
    this.library = new NPCLib(this);
}

Additional context

[11:17:27 INFO]: [LeafSK] Enabling LeafSK v2.0.4
[11:17:27 INFO]: NPCLib Attempting to inject into netty
[11:17:27 ERROR]: Error occurred while enabling LeafSK v2.0.4 (Is it up to date?)
java.lang.RuntimeException: Cannot invoke method static java.util.List net.minecraft.server.v1_8_R3.ServerConnection.access$0(net.minecraft.server.v1_8_R3.ServerConnection)
        at com.comphenix.tinyprotocol.Reflection.lambda$getTypedMethod$0(Reflection.java:231) ~[?:?]
        at com.comphenix.tinyprotocol.TinyProtocol.registerChannelHandler(TinyProtocol.java:189) ~[?:?]
        at com.comphenix.tinyprotocol.TinyProtocol.<init>(TinyProtocol.java:86) ~[?:?]
        at net.jitse.npclib.listeners.PacketListener$1.<init>(PacketListener.java:43) ~[?:?]
        at net.jitse.npclib.listeners.PacketListener.start(PacketListener.java:43) ~[?:?]
        at net.jitse.npclib.NPCLib.<init>(NPCLib.java:53) ~[?:?]
        at com.leaf.Leaf.onEnable(Leaf.java:49) ~[?:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:321) ~[paper.jar:git-PaperSpigot-"4c7641d"]
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:332) [paper.jar:git-PaperSpigot-"4c7641d"]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:407) [paper.jar:git-PaperSpigot-"4c7641d"]
        at org.bukkit.craftbukkit.v1_8_R3.CraftServer.loadPlugin(CraftServer.java:359) [paper.jar:git-PaperSpigot-"4c7641d"]
        at org.bukkit.craftbukkit.v1_8_R3.CraftServer.enablePlugins(CraftServer.java:318) [paper.jar:git-PaperSpigot-"4c7641d"]
        at net.minecraft.server.v1_8_R3.MinecraftServer.s(MinecraftServer.java:408) [paper.jar:git-PaperSpigot-"4c7641d"]
        at net.minecraft.server.v1_8_R3.MinecraftServer.k(MinecraftServer.java:372) [paper.jar:git-PaperSpigot-"4c7641d"]
        at net.minecraft.server.v1_8_R3.MinecraftServer.a(MinecraftServer.java:327) [paper.jar:git-PaperSpigot-"4c7641d"]
        at net.minecraft.server.v1_8_R3.DedicatedServer.init(DedicatedServer.java:267) [paper.jar:git-PaperSpigot-"4c7641d"]
        at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:563) [paper.jar:git-PaperSpigot-"4c7641d"]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_221]
Caused by: java.lang.reflect.InvocationTargetException
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_221]
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_221]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_221]
        at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_221]
        at com.comphenix.tinyprotocol.Reflection.lambda$getTypedMethod$0(Reflection.java:229) ~[?:?]
        ... 17 more
Caused by: java.lang.NullPointerException
        at net.minecraft.server.v1_8_R3.ServerConnection.access$0(ServerConnection.java:63) ~[paper.jar:git-PaperSpigot-"4c7641d"]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_221]
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_221]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_221]
        at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_221]
        at com.comphenix.tinyprotocol.Reflection.lambda$getTypedMethod$0(Reflection.java:229) ~[?:?]
        ... 17 more

?

`[ERROR] Could not pass event PlayerLoginEvent to MineSkyWars v1.0

org.bukkit.event.EventException

at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]

at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]

at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]

at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]

at net.minecraft.server.v1_8_R3.PlayerList.attemptLogin(PlayerList.java:456) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]

at net.minecraft.server.v1_8_R3.LoginListener.b(LoginListener.java:118) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]

at net.minecraft.server.v1_8_R3.LoginListener.c(LoginListener.java:54) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]

at net.minecraft.server.v1_8_R3.NetworkManager.a(NetworkManager.java:231) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]

at net.minecraft.server.v1_8_R3.ServerConnection.c(ServerConnection.java:148) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]

at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:814) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]

at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:374) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]

at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:654) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]

at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:557) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]

at java.lang.Thread.run(Thread.java:813) [?:1.8.0_212]

Caused by: java.lang.NullPointerException

at sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) ~[?:1.8.0_212]

at sun.reflect.UnsafeQualifiedObjectFieldAccessorImpl.get(UnsafeQualifiedObjectFieldAccessorImpl.java:38) ~[?:1.8.0_212]

at java.lang.reflect.Field.get(Field.java:393) ~[?:1.8.0_212]

at com.comphenix.tinyprotocol.Reflection$1.get(Reflection.java:149) ~[?:?]

at com.comphenix.tinyprotocol.TinyProtocol.getChannel(TinyProtocol.java:265) ~[?:?]

at com.comphenix.tinyprotocol.TinyProtocol.access$11(TinyProtocol.java:259) ~[?:?]

at com.comphenix.tinyprotocol.TinyProtocol$5.onPlayerLogin(TinyProtocol.java:160) ~[?:?]

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_212]

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_212]

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_212]

at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_212]

at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]

... 13 more`

I've getting this error after update the NPCLib library from the v1.4.2 to the current version

https://i.imgur.com/shgmS13.png

Describe the bug
Unable to create NPCs. Reflection is unable to locate the correct constructor.

NPCLib usage option
3

NPCLib JAR name
2.4.1 Plugin shaded into JAR

Server version
PaperSpigot-4c7641d (aka; paper-443 for 1.8.8)

To Reproduce
Create an NPC using any of the create methods.

Expected behavior
n/a

Screenshots

> [06:07:18 ERROR]: [ACF] Caused by: java.lang.IllegalStateException: Unable to find constructor for class net.minecraft.server.v1_8_R3.EntityArmorStand ([class net.minecraft.server.v1_8_R3.WorldServer]).
> [06:07:18 ERROR]: [ACF] at com.comphenix.tinyprotocol.Reflection.getConstructor(Reflection.java:279)
> [06:07:18 ERROR]: [ACF] at net.jitse.npclib.hologram.Hologram.createPackets(Hologram.java:117)
> [06:07:18 ERROR]: [ACF] at net.jitse.npclib.hologram.Hologram.<init>(Hologram.java:92)
> [06:07:18 ERROR]: [ACF] at net.jitse.npclib.nms.v1_8_R3.NPC_v1_8_R3.createPackets(NPC_v1_8_R3.java:39)
> [06:07:18 ERROR]: [ACF] at net.jitse.npclib.internal.NPCBase.create(NPCBase.java:132)
> [06:07:18 ERROR]: [ACF] at net.gravitas.gravitasapi.npcs.CustomNPC.build(CustomNPC.java:201)

Additional context
We're using Java 11-OpenJ9.
The issue also appeared on our 1.14.4 instances, but was fixed as it was a custom Spigot build, simply by adding a new constructure using WorldServer instead of World (see below).

    // custom constructure to allow NPCLib to correctly target a constructor
    public EntityArmorStand(WorldServer world, double d0, double d1, double d2) {
        this(EntityTypes.ARMOR_STAND, world);
        this.setPosition(d0, d1, d2);
    }

    public EntityArmorStand(World world, double d0, double d1, double d2) {
        this(EntityTypes.ARMOR_STAND, world);
        this.setPosition(d0, d1, d2);
    }

I expect this issue is due to Java 11 and the Reflection class not accepting superclasses as a valid option.

Add Armor to NPC's and Possibly Entity NPC's as an option.

(add label enhancements)

I would have done it myself but I keep getting errors when trying to copy the plugin. (Things aren't importing)

Describe the Bug
Console error on server startup. NPE on ChunkUnloadEvent.

NPCLib Usage Option
Lazy way; plugin install.

NPCLib Jar Name
npclib-plugin-2.1-SNAPSHOT.jar

Server version
Paper 1.8.8:
CraftBukkit version git-PaperSpigot-"4c7641d" (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)

To Reproduce
I'm not exactly sure how to reproduce this error. I've been using NPCLib for a few days now without any kind of errors. Also, I know I don't listen to ChunkUnloadEvent.

My plugin hooks into the NPCLib API. However, this error occurred without any calls to NPCLib, besides lib = new NPCLib(this.main);

Expected Behaviour
No console errors.

Screenshots
Pastebin of the error

Other info
ArimSK is the name of my plugin. I don't listen to ChunkUnloadEvent. No calls to the API except initialising it. Happens multiple times as soon as startup finishes.

Describe the bug
Clear and concise description is: The support for NPCLib in 1.14.4 using Spigot throws error. (They works correctly in 1.8.8 and 1.15.2 the hologram is a visible armorstand only) But my problem is the 1.14.4 error when load the library.

NPCLib usage option
Usage: 1

NPCLib JAR name
Lastest Jar.

Server version
server is running CraftBukkit version git-Spigot-56f8471-6567017 (MC: 1.14.4) (Implementing API version 1.14.4-R0.1-SNAPSHOT)

Screenshots
[18:52:03] [Server thread/ERROR]: Error occurred while enabling KBFFA v4.0 (Is it up to date?) java.lang.RuntimeException: Cannot invoke method static java.util.List net.minecraft.server.v1_14_R1.ServerConnection.access$0(net.minecraft.server.v1_14_R1.ServerConnection) at com.comphenix.tinyprotocol.Reflection.lambda$0(Reflection.java:231) ~[?:?] at com.comphenix.tinyprotocol.TinyProtocol.registerChannelHandler(TinyProtocol.java:183) ~[?:?] at com.comphenix.tinyprotocol.TinyProtocol.<init>(TinyProtocol.java:85) ~[?:?] at net.jitse.npclib.listeners.PacketListener$1.<init>(PacketListener.java:42) ~[?:?] at net.jitse.npclib.listeners.PacketListener.start(PacketListener.java:42) ~[?:?] at net.jitse.npclib.NPCLib.<init>(NPCLib.java:54) ~[?:?] at dev.cleusgamer201.kbffa.Main.listeners(Main.java:189) ~[?:?] at dev.cleusgamer201.kbffa.Main.onEnable(Main.java:89) ~[?:?] at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[Server.jar:git-Spigot-9de398a-9c887d4] at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:352) [Server.jar:git-Spigot-9de398a-9c887d4] at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:417) [Server.jar:git-Spigot-9de398a-9c887d4] at org.bukkit.craftbukkit.v1_14_R1.CraftServer.enablePlugin(CraftServer.java:461) [Server.jar:git-Spigot-9de398a-9c887d4] at org.bukkit.craftbukkit.v1_14_R1.CraftServer.enablePlugins(CraftServer.java:375) [Server.jar:git-Spigot-9de398a-9c887d4] at net.minecraft.server.v1_14_R1.MinecraftServer.a(MinecraftServer.java:449) [Server.jar:git-Spigot-9de398a-9c887d4] at net.minecraft.server.v1_14_R1.DedicatedServer.init(DedicatedServer.java:258) [Server.jar:git-Spigot-9de398a-9c887d4] at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:776) [Server.jar:git-Spigot-9de398a-9c887d4] at java.lang.Thread.run(Unknown Source) [?:1.8.0_241] Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_241] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_241] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_241] at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_241] at java.lang.invoke.MethodHandleImpl$BindCaller$T/20968219.invoke_V(Unknown Source) ~[?:?] at com.comphenix.tinyprotocol.Reflection.lambda$0(Reflection.java:229) ~[?:?] ... 16 more Caused by: java.lang.NullPointerException at net.minecraft.server.v1_14_R1.ServerConnection.access$0(ServerConnection.java:41) ~[Server.jar:git-Spigot-9de398a-9c887d4] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_241] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_241] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_241] at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_241] at java.lang.invoke.MethodHandleImpl$BindCaller$T/20968219.invoke_V(Unknown Source) ~[?:?] at com.comphenix.tinyprotocol.Reflection.lambda$0(Reflection.java:229) ~[?:?] ... 16 more

Hey, why spigot 1.8 r3 is not supported ? Can you make an update for this version ?

I have people test my plugins for me, and in PaperSpigot 1.12.2, the holograms are super high up.

https://cdn.discordapp.com/attachments/565965947421065246/568856421890785291/JPEG_20190419_195213.jpg