NPC disappears about npclib

[JitseB]

No, NPCLib is a free resource and I will treat it as such. I’ll only work on it in my spare time. If you would like this issue to be solved sooner. You could always try to help me find the issue yourself and create a PR! :)

[JitseB]

Hi there, thanks for opening this issue ticket!
To help you any further, please provided me with the following information:

• What code are you using the manipulate and spawn the NPC?
• After about how long does the NPC disappear?
• What usage option did you use? (you didn't fill that in in the template)

There's a reason why I ask all the things in the template, next time you create an issue ticket, please follow them and don't remove questions you thing are unnecessary. 😛

[Exception426]

https://hasteb.in/ijetusog.java
My Code

Sometimes the NPC doesn't go away sometimes there is no set time.

[JitseB]

So, first you see it and then it disappears? The hologram is still visible, just not the NPC, right?

[Exception426]

Recognize both. And yes at the beginning I see him talking to BGHDDevelopment and they said I should create a problem

[Exception426]

Both will disappear *
sorry my english is bad. Im from germany

[JitseB]

Oh that’s actually a good thing. That’d mean it’s in the auto hiding system somewhere.
I’ll think about this problem for a bit, I’m rather busy tomorrow. I’ll have some time again the day after that.

[Exception426]

Hm okay. Thanks man.

[JitseB]

Note to self: The issue might exist because when the player gets in proximity of the NPC, its autospawn. NPC#spawn checks whether the player can actually see it using the dotproduct of the look direction. This might result in the system thinking it shouldn’t be testing for anymore.
Then the UUID of the player is in the shown set, but not in the autohide set anymore.

I think I have found the problem, but I’ll debug more in the day after tomorrow. 👍

[Exception426]

Can you fix the problem today?

[Exception426]

It would be important for me but you also have a life so please take your time as soon as possible

[JitseB]

What's the view-distance in your server.properties set to?

[Exception426]

10

[Exception426]

What does that have to do with it?

[Exception426]

Ahh it works with view-distance: 16!

[JitseB]

Yeah, there's a slight issue with the auto-hiding system. I can't seem to figure it out now. I'll continue on it tomorrow.
Turns out I have added some partial check in the player listener, but have not yet implemented these in the NPC class. Resulting in this strange behavior.

[Exception426]

Okay.

[Exception426]

The problem is back! **

[JitseB]

The issue should be fixed in v2.5.2-SNAPSHOT. You can download it here: https://github.com/JitseB/NPCLib/releases/tag/2.5.2-SNAPSHOT

I ended up reworking the entire auto-hiding system, I found some issues that gave false-positives; should be solved now.

If your issue does come up again, feel free to comment here. Then I'll reopen the ticket.

Have a good day!