Unable to find constructure w/ JDK11-OpenJ9 about npclib

[JitseB]

Solved. Will soon post a release with the fix.

[RealGatt]

Upon further research, the issue seems to be due to SlimeWorldManager as it creates a new World object ( example )

Not sure if this is something that is fixable on your end.

[RealGatt]

I've forked NPCLib and attempted to fix it.

Reflection.ConstructorInvoker entityArmorStandConstructor = null;
        try{
            System.out.println("Method 1 Attempt " + worldClass.getName());
            entityArmorStandConstructor = (version.isAboveOrEqual(MinecraftVersion.V1_14_R1) ?
                    Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass, double.class, double.class, double.class) :
                    Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass));
            System.out.println("Method 1");
        }catch (Exception e){
            System.out.println("Method 1 Failed");
            try {
                worldClass = worldClass.getSuperclass();

                System.out.println("Method 2 Attempt " + worldClass.getName());

                entityArmorStandConstructor = (version.isAboveOrEqual(MinecraftVersion.V1_14_R1) ?
                        Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass, double.class, double.class, double.class) :
                        Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass));

                System.out.println("Method 2");
            }catch (Exception e2){

                System.out.println("Method 2 Failed");
                if (Bukkit.getPluginManager().getPlugin("SlimeWorldManager") != null){

                    try {
                        worldClass = Reflection.getUntypedClass("com.grinderwolf.swm.nms." + NPCLib.getVersionName() + ".CustomWorldServer");

                        worldClass = worldClass.getSuperclass().getSuperclass();

                        System.out.println("Method 3 Attempt " + worldClass.getName());

                        entityArmorStandConstructor = (version.isAboveOrEqual(MinecraftVersion.V1_14_R1) ?
                                Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass, double.class, double.class, double.class) :
                                Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass));

                        System.out.println("Method 3");
                    }catch (Exception e3){
                        System.out.println("Failing silently... or not");
                    }
                }
            }
        }

Using the above code I was able to get the NPCs' to spawn with SlimeWorldManager. The main portion of the code is getting the SuperClass of the WorldServer object thats retrieved.

        Reflection.ConstructorInvoker entityArmorStandConstructor = null;
        try{
            entityArmorStandConstructor = (version.isAboveOrEqual(MinecraftVersion.V1_14_R1) ?
                    Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass, double.class, double.class, double.class) :
                    Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass));
        }catch (Exception e){
            try {
                worldClass = worldClass.getSuperclass();

                entityArmorStandConstructor = (version.isAboveOrEqual(MinecraftVersion.V1_14_R1) ?
                        Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass, double.class, double.class, double.class) :
                        Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass));
}

Should fix the issue.

Now I'm getting a new issue with non 1.8 clients on a 1.8 server; they get kicked with an ArrayIndexOutOfBoundsException: 6 error. The same issue that #58 is getting

[JitseB]

I'll see what I can do about this. With your fix it should be the same issue as found in #58.
Are you using any sort of server proxy? E.g. BungeeCord?

[RealGatt]

We're running Waterfall w/ ViaVersion on the Proxy & locally on the 1.8 servers.

If you go onto the server w/ a 1.8 client it works fine, but on any other version it crashes with that error. I don't know enough about packets to properly diagnose the issue myself

[JitseB]

Issue #58 has been solved. I'll add your additions to the library so you can use your JDK of choice.
Hopefully I'll have an update posted by the end of the day.

[JitseB]

https://github.com/JitseB/NPCLib/releases/tag/2.4.2-SNAPSHOT