jiuka / checkmk_win_adsync

Checkmk extension for Windows Azure AD Connect sync service

Checkmk extension for Azure AD Connect

Description

This Plugin and check can monitor the Azure AD Connect Sync Service

Screenshots

Services

Metrics

Development

For the best development experience use VSCode with the Remote Containers extension. This maps your workspace into a checkmk docker container giving you access to the python environment and libraries the installed extension has.

Directories

The following directories in this repo are getting mapped into the Checkmk site.

• agents, checkman, checks, doc, inventory, notifications, pnp-templates, web are mapped into local/share/check_mk/
• agent_based is mapped to local/lib/check_mk/base/plugins/agent_based
• nagios_plugins is mapped to local/lib/nagios/plugins

Continuous integration

Local

To build the package hit Crtl+Shift+B to execute the build task in VSCode.

pytest can be executed from the terminal or the test ui.

Github Workflow

The provided Github Workflows run pytest and flake8 in the same checkmk docker conatiner as vscode.

checkmk_win_adsync's Issues

Issue with US vs DE Date

Hi,
found an issue with the date parsing in

checkmk_win_adsync/checks/win_adsync_scheduler

Line 49 in 65bd8ca

parsed[key] = time.strptime(value, "%d.%m.%Y %H:%M:%S")

the agent returns the date in US notation:
ValueError (time data u'6/4/2020 2:32:19 PM' does not match format '%d.%m.%Y %H:%M:%S')

<<<win_adsync_scheduler:sep(0):encoding(cp437)>>>


AllowedSyncCycleInterval : 00:30:00
CurrentlyEffectiveSyncCycleInterval : 00:30:00
CustomizedSyncCycleInterval : 00:05:00
NextSyncCyclePolicyType : Delta
NextSyncCycleStartTimeInUTC : 6/4/2020 3:02:19 PM
PurgeRunHistoryInterval : 1.00:00:00
SyncCycleEnabled : True
MaintenanceEnabled : True
StagingModeEnabled : False
SchedulerSuspended : False
SyncCycleInProgress : False

<<<win_adsync_connector:sep(59):encoding(cp437)>>>
sx.onmicrosoft.com - AAD Delta Import;success;8.504;06/04/2020 14:32:43;
sx.onmicrosoft.com - AAD Delta Synchronization;success;1.297;06/04/2020 14:32:48;
sx.onmicrosoft.com - AAD Export;success;31.864;06/04/2020 14:33:20;
example.com Delta Import;success;13.296;06/04/2020 14:32:34;
example.com Delta Synchronization;success;3.406;06/04/2020 14:32:47;
example.com Export;completed-export-errors;0.11;06/04/2020 14:33:21;

any idea for a convinient way to catch this?
thanks Matthias

Does this work with Azure AD Connect v2?

MSFT recently announced they will stop supporting AADConnect v1 in the near future, does this check work with AADConnect v2?