jkorf / binance.net Goto Github PK

Hello,
I was trying lot of things but i just cannot compile the project.
I have following errors:

Severity Code Description Project File Line Suppression State
Error CS0246 The type or namespace name 'WebRequest' could not be found (are you missing a using directive or an assembly reference?) Binance.Net(netstandard2.0) D:\Users\Dawid\Desktop\Binance.Net-master\Binance.Net\Implementations\Request.cs 8 Active
Error CS0246 The type or namespace name 'WebRequest' could not be found (are you missing a using directive or an assembly reference?) Binance.Net(netstandard2.0) D:\Users\Dawid\Desktop\Binance.Net-master\Binance.Net\Implementations\Request.cs 10 Active
Error CS0246 The type or namespace name 'WebHeaderCollection' could not be found (are you missing a using directive or an assembly reference?) Binance.Net(netstandard2.0) D:\Users\Dawid\Desktop\Binance.Net-master\Binance.Net\Implementations\Request.cs 15 Active
Error CS0246 The type or namespace name 'WebHeaderCollection' could not be found (are you missing a using directive or an assembly reference?) Binance.Net(netstandard2.0) D:\Users\Dawid\Desktop\Binance.Net-master\Binance.Net\Interfaces\IRequest.cs 7 Active
Error CS0534 'TraceTextWriter' does not implement inherited abstract member 'TextWriter.Write(char)' Binance.Net(netstandard2.0) D:\Users\Dawid\Desktop\Binance.Net-master\Binance.Net\Logging\TraceTextWriter.cs 7 Active
Error CS0246 The type or namespace name 'WebResponse' could not be found (are you missing a using directive or an assembly reference?) Binance.Net(netstandard2.0) D:\Users\Dawid\Desktop\Binance.Net-master\Binance.Net\Implementations\Response.cs 9 Active
Error CS0246 The type or namespace name 'WebResponse' could not be found (are you missing a using directive or an assembly reference?) Binance.Net(netstandard2.0) D:\Users\Dawid\Desktop\Binance.Net-master\Binance.Net\Implementations\Response.cs 11 Active

It looks like missing System.Net namespace but it is not. I think the solution is simple but I cannot find it.

I have Visual Studio 2017, Windows 8.1

Hi is there a LOT_SIZE calculator method in Binance.net?

Hi there,

Using Binance.NET to build a simple trading app on Visual Studio. I'm getting a code error -1021 when I call GetAccountInfo, thought it was my code first but the same call worked about an hour ago. Can you help? Thanks in advance!

Hi JKorf

Is this behaviour expected?

I am using your app and it looks like its consolidated the orders into days with no way to break them out into individual sell/buy orders. The bottom image is from the binance app.

When I call the client.GetAccountInfoAsync();

I am getting error:

"Timestamp for this request was 1000ms ahead of the server's time."

In PlaceOrder price argument cast to string with coma, but should with dot. Pls fix it.

I could do with some help with my code here, I'm sure I am missing something. I run the below code in a windows form, but I do not get anything fed back to the debug. I have set the API keys in the default and get a listen key back.

    public void UserStream()
    {
        using (var client = new BinanceClient())
        using (var socketclient = new BinanceSocketClient())
        {
            var successStart = client.StartUserStream();
            System.Diagnostics.Debug.WriteLine(successStart.Data.ListenKey);
            var successAccount = socketclient.SubscribeToAccountUpdateStream(successStart.Data.ListenKey, (data) =>
            {
                foreach (var value in data.Balances)
                {
                    System.Diagnostics.Debug.WriteLine(value.Asset + " = " + value.Free + " = " + value.Locked + " = " + value.Total);

                }
            });
        }
    }

all I see in the output is my listen key and the below;
'BinanceTestApi.exe' (CLR v4.0.30319: BinanceTestApi.exe): Loaded '

It fails on all private calling methods listed below.

using (var client = new BinanceClient(_BINANCE_API_KEY, _COINBASE_API_SECRET))
            {
client.SetApiCredentials(_BINANCE_API_KEY, _COINBASE_API_SECRET);
client.AutoTimestamp = true;
// Gets all open orders for specified symbol
                var openOrders = client.GetOpenOrders("LTCBTC");
                // Gets all orders for specified symbol
                var allOrders = client.GetAllOrders("LTCBTC");
                // Gets information about your account
                var accountInfo = client.GetAccountInfo();
                // Gets all trades for specified symbol
                var myTrades = client.GetMyTrades("LTCBTC");
                // Gets your deposit history
                var depositHistory = client.GetDepositHistory();
                // Gets your withdraw history
                var withdrawalHistory = client.GetWithdrawHistory();
            }

Hello,
I think i have a small Problem or i missunderstand the client.Get24HPrice?
First -> var price24h = client.Get24HPrice(getcoin);
Then i get all the Information from the client.Get24hPrice...
But the Price from the API is verry different as from the Binance...

thank you :)

I get an error that says the server time and request time have a difference of 1000ms.

Hi, Thanks for this package! just what i need, but i'm getting the following error as soon as i try and use the client:

CS0012 The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.

i have updated to VS 2017 and downloaded .NET Core 2.0 but still get the same error. Im not a C# expert so forgive me if this is a trivial issue.
Thanks from a grateful user.

Been using this for a few weeks, and it works great. However the symbol-pair MTHBTC always fails to retrieve orders.

It seems as though the API is mandating a TimeInForce parameter to be sent into the Client.PlaceTestOrder function even when the OrderType.Market enum is used. This is causing the Binance API to send back the error message below:

Code = -1106
Message = "Parameter 'timeInForce' sent when not required."

If you use OrderType.Limit, this issue does not occur.
Thanks!

Unit tests need to be made for the sockets methods
Extend existing unit tests

Currently only supports .Net 4.5 and 4.6, working on more

08:22:36:288 | Error | Couldn't open socket stream: Method not found: 'System.Threading.Tasks.Task`1 WebSocket4Net.WebSocket.OpenAsync()'.
08:22:36:370 | Info | Disposing socket client, closing sockets

been working fine untill the update, wierd.

Hi again JKorf

Could you confirm the following code works

    private Binance.Net.Objects.BinanceStreamAccountInfo accountinfo;
    public Binance.Net.Objects.BinanceStreamAccountInfo AccountInfo
    {
        get
        {
            return accountinfo;
        }

        set
        {
            accountinfo = value;
        }
    }




            BinanceDefaults.SetDefaultApiCredentials(lblAPIKey.Text, lblSecret.Text);
            using (var client = new BinanceClient())
            using (var socketclient = new BinanceSocketClient())
            {
                var successStart = client.StartUserStream();
                var successAccount = socketclient.SubscribeToAccountUpdateStream(successStart.Data.ListenKey, (data) =>
                {
                    AccountInfo = data; **<--- seems to skip this completely??**
                });

                socketclient.UnsubscribeFromAccountUpdateStream();
            }

I think your library doesn't like stop limit orders

Also there are new order types

https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.md

Good job though (Y)

how to use websocket data in another method

`var successKline = socketClient.SubscribeToKlineStream("bnbbtc", KlineInterval.OneMinute, (data) =>
{
// it is possible here
});

//need here
`

Hi love you wrapper.
Im a little stuck on getting GetExchangeInfoAsync for specific coin for its STEP_SIZE

Anychance of a little example.

Thanks

Greetings;
I would like to use it in an MVC application, but when I run tests in Global.asax it works fine in an Actionresult and it does not give me a value.
I waited for about 1 hour to test it, but nothing happened.
What is the implementation way on the MVC side?

public ActionResult GetBinanceAccount() { var assetList = new List<BinanceAssets>(); using (var client = new BinanceClient("key", "secret")) { client.AutoTimestamp = true; var accountInfo = client.GetAccountInfo(); foreach (var item in accountInfo.Data.Balances) { var asset = new BinanceAssets { Symbol = item.Asset, Free = item.Free, Locked = item.Locked, Total = item.Total }; assetList.Add(asset); } } var model = assetList; return PartialView(model); }

Hi there,

Having some issues getting prices for an app I'm building, whenever I do the GetAllPrices call at the beginning, it returns as successful, but the array is empty. Can you help?

EDIT: just to note it was working a couple of days ago, just not today for some reason

Thanks!

Sorted it. Thanks for your work.

Hi JKorf

is it possible to get the BTC value of each coin and a total of all coins? Similar to
https://www.binance.com/userCenter/balances.html

I want to get these balance totals when i start my app (without any changes). It looks like you cant get them unless you get a response from SubscribeToAccountUpdateStream. The problem is you only get a response if Binance detects a change.

Am i missing a way to get these values? Or is this something missing from Binance.Net.

edit - attached image just in case you don't have access to the above link.

and

System.InvalidCastException: Unable to cast object of type 'System.Int64' to type 'System.String'.
at Binance.Net.Converters.OrderTypeConverter.<>c__DisplayClass5_0.b__0(KeyValuePair2 v) at System.Linq.Enumerable.Single[TSource](IEnumerable1 source, Func`2 predicate)
at Binance.Net.Converters.OrderTypeConverter.ReadJson(JsonReader reader, Type objectType, Object existingValue, JsonSerializer serializer)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.DeserializeConvertable(JsonConverter converter, JsonReader reader, Type objectType, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, Object target)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings)
at Binance.Net.BinanceSocketClient.OnUserMessage(String data)
at Binance.Net.BinanceSocketClient.b__30_1(Object o, MessageReceivedEventArgs s)
at WebSocket4Net.WebSocket.OnDataReceived(Byte[] data, Int32 offset, Int32 length)
at SuperSocket.ClientEngine.SslStreamTcpSession.d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.ThreadPoolWorkQueue.Dispatch()

I need to check Fills of my TakeProfit order that was filled in whole. I can't see this data in any Orders endpoint in Binance API, so I guess, I need to use myTrades endpoint for this.

The problem is that in Binance API docs there is OrderId field returned when I query for myTrades and Binance.Net does not return this field and I can't match trades with my order.

Is it a bug or should I query this data different way?

seems they have added a clause error now.

Version 3.0.7
I try with console app it run, but try with GUI action not callback. Tests with 2012 and 2017 all have the same results

var socketClient = new BinanceSocketClient(socketClientOptions);
// Streams
var successDepth = socketClient.SubscribeToDepthStream("bnbbtc", (data) =>
{
// handle data
});

I am sorry to be posting here but I dont know what else to do. I am experimenting with this project and I cannot get the simplest thing to work.

I have downloaded the source from Github and created a second project in the solution with a reference to the Binance.net project. In my blank Windows Forms VB project I have only the following:

    Public Sub New()
        ' This call is required by the designer.
        InitializeComponent()

        ' Add any initialization after the InitializeComponent() call.
        Using client As New BinanceClient()
            Dim ping = client.Ping
        End Using
    End Sub

Regardless of what method I call, eg. client.Ping, client.GetAllPrices, etc., it hangs at the first call. If I press pause in the debugger after calling Ping, the code is waiting at line 128 in BinanceClient.cs

public BinanceApiResult<bool> Ping() => PingAsync().Result;

I have tried the following:

• Turning off firewall
• Using C# instead of VB code
• Changing frameworks, currently on 4.7.1, although the framework in Binance.net properties is greyed and cannot be changed
• Using Nuget to install Binance.net instead of the project
• Tried VS2017 then VS2015

I am so confused... Any tips on how to get started would be greatly appreciated!

Hello,
I have a small Question, is it Possible to get only the newest Trade Infos from a specific Symbol in a Console Application?

what i mean,
---> var myTrades = client.GetMyTrades("XVGBTC", 10, "Here; LAST 1 HOUR newest Results");

So the Symbol is XVGBTC, last 10 or more Results/Trades in the Last 1 hour..
Because with "10-max number of Results" its only the oldest Trades from the specific Symbol, why not the newest? Or is my thinkig wrong? ;x

Been trying to get a working async of the klines, I get it to display the results but not get the new ones in.

Using QueryOrder the returned results always have the Price variable set to 0. I had to use GetMyTrades and traverse the results to get the price. It would be much better if QueryOrder would return the correct price result so it could be used to query a single order ID.

Some methods expect orderIds to be long and some int. As per Binance API specs it should be long

All calls are no longer working with the base address: https://www.binance.com . For example https://www.binance.com/api/v1/ping gives an error but with https://api.binance.com/api/v1/ping

Can you make the base address adjustable or simple cahnge it to https://api.binance.com ?

Why after calling this function socked is closed ?

var Openoderd = socketClient.SubscribeToUserStream(successStart.Data.ListenKey, (data) =>
                 {
                     
                     
                 },
                (orderInfoUpdate) =>
                {

                    
                   foreach (var ds in orderInfoUpdate.Symbol)
                        Console.WriteLine(ds);

                });

i was wondering if theres a simple way of regaining connect after loss of internet.

Hello,
im not the best c# programmer, im very new here... i cant "read" the full Balance, or the Balance from a single Coin in BTC/XY Coin...
i can only get the Count or Capacity..?
With accountInfo.Data.Balances.Count/Capacity, but how //BTC/Xy Coin?
thank you :)

Hi,
The issue I faced was with Trades stream. BinanceStreamTrade.BuyerIsMaker was always True, so my guess was that it is picking from "M" field in JSON. The way I proove it is simple (see below). Unfortunately, it looks like there is no fix from Newtonsoft (JamesNK/Newtonsoft.Json#815). May be having below solution will be ok for your releases, anyway it's up to you. This issue may popup some other places too, but so far I notices only this.

public class BinanceStreamTrade: BinanceStreamEvent
{

...
// added this so it will pick M, and m will be where it should be.
// I have no idea why it works, but...
[JsonProperty("M")]
public bool Ignore { get; set; }
[JsonProperty("m")]
public bool BuyerIsMaker { get; set; }

I can not download release 2.3.4, I am using vs 2015 vers 14 update 3.
can you share compiled DLL library ..

I have treid all NETFramework,Versions from 2.0 to 4.7.1 without any luck.

below is the output log:

GET https://www.nuget.org/api/v2/Packages(Id='Binance.Net',Version='2.3.4')
GET https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/Packages(Id='Binance.Net',Version='2.3.4')
OK https://www.nuget.org/api/v2/Packages(Id='Binance.Net',Version='2.3.4') 905ms
Error finding repository for 'https://www.nuget.org/api/v2/curated-feeds/microsoftdotnet/': An error occurred while retrieving package metadata for 'Binance.Net.2.3.4' from source 'Microsoft and .NET'.
A task was canceled.
Resolved actions to install package 'Binance.Net.2.3.4'
GET https://www.nuget.org/api/v2/Packages(Id='Binance.Net',Version='2.3.4')
OK https://www.nuget.org/api/v2/Packages(Id='Binance.Net',Version='2.3.4') 1392ms
Install failed. Rolling back...
Package 'Binance.Net.2.3.4' does not exist in project 'BinanceBot'
Package 'Binance.Net.2.3.4' does not exist in folder 'c:\users\ashraf\documents\visual studio 2015\Projects\BinanceBot\packages'
Could not install package 'Binance.Net 2.3.4'. You are trying to install this package into a project that targets '.NETFramework,Version=v2.0', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
========== Finished ==========

When any socket is closed we can't reopen it , because there's no notification in Socket.Close to Binance.net users
For this i think we need to change "Subscribe" functions to return BinanceStream instance instead of StreamId like this exemple:

public BinanceApiResult<BinanceStream> SubscribeToKlineStream(string symbol, KlineInterval interval, Action<BinanceStreamKline> onMessage)
     {
         symbol = symbol.ToLower();
         var socketResult = CreateSocket(BaseWebsocketAddress + symbol + KlineStreamEndpoint + "_" + JsonConvert.SerializeObject(interval, new KlineIntervalConverter(false)));
         if (!socketResult.Success)
             return new BinanceApiResult<BinanceStream>() {Error = socketResult.Error};

         socketResult.Data.Socket.OnMessage += (o, s) => onMessage(JsonConvert.DeserializeObject<BinanceStreamKline>(s.Message));

         log.Write(LogVerbosity.Debug, $"Started kline stream for {symbol}: {interval}");
         return new BinanceApiResult<BinanceStream>() { Data = socketResult.Data, Success = true };
     }

After a while, I get this error permanently. Earlier there was "AutoTimestamp", which alternative is now

Is it possible to change the default hostname for binance API? With the ongoing issue with the servers right now....it won't let me use your API. I have to use host us.binance.com as www.binance.com ain't working due to a DDOS attack going at their cloud provider....

Thanks

Hello JKorf,

I need some help in using web socket, I am getting below response.
and what event will be triggered on new data arrival ! basically how to consume the data.

Thanks in advance.

Output Log:

05:54:45:618 | Error | Socket error The requested name is valid, but no data of the requested type was found.
The thread '' (0x1ca8) has exited with code 0 (0x0).
The thread '' (0x1c1c) has exited with code 0 (0x0).

The Code:

   Dim _binClient As BinanceClient
    Dim _socketClient As BinanceSocketClient

    Dim result As BinanceStreamKline = Nothing

    If APIKEY IsNot Nothing OrElse APISECRET IsNot Nothing Then
        BinanceDefaults.SetDefaultApiCredentials(APIKEY, APISECRET)
        BinanceDefaults.SetDefaultMaxRetries(3)
        BinanceDefaults.SetDefaultLogOutput(Console.Out)
    Else
        Exit Sub
    End If

    Try
           _binClient = New BinanceClient
            Dim ping As BinanceApiResult(Of Boolean) = _binClient.Ping()
        If Not ping.Success Then
            MsgBox("Ping not responding")
            Exit Sub
        End If

        _socketClient = New BinanceSocketClient
        _socketClient.SubscribeToKlineStream("xrpbtc", KlineInterval.OneMinute, Function(data)
                                                                                       Console.WriteLine("ok")
                                                                                    Return Nothing
                                                                                End Function)
    Catch ex As Exception
        MsgBox(ex.Message)
    End Try

•   RateLimits	Count = 3	System.Collections.Generic.List<Binance.Net.Objects.BinanceRateLimit>
  

•   [0]	{Binance.Net.Objects.BinanceRateLimit}	Binance.Net.Objects.BinanceRateLimit
    Interval	Minute	Binance.Net.Objects.RateLimitInterval
    Limit	1200	int
    Type	Requests	Binance.Net.Objects.RateLimitType
  

•   [1]	{Binance.Net.Objects.BinanceRateLimit}	Binance.Net.Objects.BinanceRateLimit
    Interval	Second	Binance.Net.Objects.RateLimitInterval
    Limit	10	int
    Type	Requests	Binance.Net.Objects.RateLimitType
  

•   [2]	{Binance.Net.Objects.BinanceRateLimit}	Binance.Net.Objects.BinanceRateLimit
    Interval	Day	Binance.Net.Objects.RateLimitInterval
    Limit	100000	int
    Type	Requests	Binance.Net.Objects.RateLimitType
  

Should be

•   RateLimits	Count = 3	System.Collections.Generic.List<Binance.Net.Objects.BinanceRateLimit>
  

•   [0]	{Binance.Net.Objects.BinanceRateLimit}	Binance.Net.Objects.BinanceRateLimit
    Interval	Minute	Binance.Net.Objects.RateLimitInterval
    Limit	1200	int
    Type	Requests	Binance.Net.Objects.RateLimitType
  

•   [1]	{Binance.Net.Objects.BinanceRateLimit}	Binance.Net.Objects.BinanceRateLimit
    Interval	Second	Binance.Net.Objects.RateLimitInterval
    Limit	10	int
    Type	**Orders**	Binance.Net.Objects.RateLimitType
  

•   [2]	{Binance.Net.Objects.BinanceRateLimit}	Binance.Net.Objects.BinanceRateLimit
    Interval	Day	Binance.Net.Objects.RateLimitInterval
    Limit	100000	int
    Type	**Orders**	Binance.Net.Objects.RateLimitType
  

Json convert error with data:
{"e":"24hrTicker","E":1520341252749,"s":"AEBTC","p":"-0.00000540","P":"-2.671","w":"0.00019750","x":"0.00020220","c":"0.00019680","Q":"46.09000000","b":"0.00019490","B":"68.00000000","a":"0.00019650","A":"585.12000000","o":"0.00020220","h":"0.00020760","l":"0.00018600","v":"460572.91000000","q":"90.964L","f":"0.00000000","l":"0.00000000"},{"a":"NAV","f":"0.00000000","l":"0.00000000"},{"a":"VIBE","f":"0.00000000","l":"0.00000000"},{"a":"LUN","f":"0.00000000","l":"0.00000000"}

90.964L could not case to decimal TotalTradedQuoteAssetVolume

Hi JKorf

I have made really good use of your code but there is one thing i am stuck on.

You give us the BestAskPrice and BestBidPrice, but how do we know which one to display as the current price? do i need to read the trade history to know which way the trade went?

Thanks in advance and keep up the good work! :)

The project not open on VS2015, the project format is in VS2017
Provide VS2015 SLN/CSPROJ

Unless I'm missing something, the current implementation of BinanceSymbolFilter makes them fairly useless, for example, how am I supposed to access the properties I need for Lot Size?

{
  "filterType": "LOT_SIZE",
  "minQty": "0.00100000",
  "maxQty": "100000.00000000",
  "stepSize": "0.00100000"
},

It looks like after one of the releases subscription to streams are going longer? Or previously when you put to log something like"03:39:04:262 | Info | Started kline stream for wavesbnb: OneMinute" wasn't really a truth. Currently what im seeing is subscribing to all symbols klines took 5-6 minutes. Previously I saw (according to the log) it was much much faster, Please advise.