Comments (2)
The schema files provided by Amazon use the same request and response type definitions and they have the same required values even though in reality in many cases, they're only required in the requests and missing from responses. I'm not sure what the best solution to this is.
The current solution is to remove the required fields on a case by case basis when we refactor the schema, but this also removes it for the request too. Another option is to just ignore the required list in responses, but the downside here is that we make more values nullable that is required. A third option is to keep a list somewhere of which required fields in requests are not required in responses.
from selling-partner-api.
Option 3 would definitely be best from a developer experience standpoint, but would take some additional work to update and maintain. I think I'm unlikely to get around to implementing that feature anytime soon, so for now I'm going to stick to just removing the fields, but if anyone else wants to set that up, I'm happy to review the PR.
from selling-partner-api.
Related Issues (20)
- Maintainer's note: I am short on time to maintain this library. Contributions welcome! HOT 2
- Request should contain exactly one of SpdTrackingDetailInput or LtlTrackingDetailInput HOT 2
- Possibility to save the accesstoken like the old callback Function onUpdateCredentials and give the accessToken to speed up the Calls HOT 2
- Problem with GetCatalogItem HOT 2
- issues since 5 may on amazon JP with feeds HOT 2
- date parameters should use DateTimeInterface rather than DateTime HOT 2
- The latest upstream version of catalogItems_2022-04-01.json breaks the OpenApiParser HOT 5
- Missing TaxCollection field in OrderItems response HOT 1
- OrdersV1 - OrderAcknowledgement items should be OrderAcknowledgementItem HOT 3
- Cannot Access PII Data in getOrders Method in v6 HOT 3
- ProductPricingV20220501 CompetitiveSummaryResponseBody HOT 1
- Response of reportsV20210630->getReport uses different date format HOT 3
- Error 400 when trying to call getMyFeesEstimates on productFeesV0 HOT 1
- Custom UserAgent in v6 HOT 1
- ItemSearchResults __construct fails, if the response misses the pagination information HOT 3
- Problem with Result ProductFeeV0 - Unknown DateTime format HOT 2
- No Data Returned HOT 2
- Wrong Timezone for Datetime Deserializer HOT 4
- Need AWD Models / Requests / Responses HOT 3
- Docs on how to get started with the library needs to be updated HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from selling-partner-api.