jmadureira / netdata-cookbook Goto Github PK

Due to the need for writing unit tests for netdata_install resource (issue #24) and due to the overall moving to resources in netdata-cookbook I propose to rewrite unit tests according to example of the ark cookbook.
This includes adding new cookbook for specs:
spec/fixtures/cookbooks/netdata_spec
And moving tests to:
spec/unit/resources/
This will correlate to Chef's policy on the path for unit tests and will correlate with integration tests.

Same changes should be applied as in #32

Please make it easy to set some configuration knobs (without overwriting the entire netdata.conf file). Primarily setting bind to so it's not listening publicly.

Following on the request made by Frans-Jan van Steenbeek (see #23 ) to release a new version of the cookbook supporting binary installations there are a couple of things I wanted to add to the discussion:

• This should be a minor release since new features will be added.
• Even though this feature already includes integration tests a request was made to @salsa-dev to create a pull request with chef specs for additional safety.

As such I have no problem in releasing version 0.4.0 as is. If anyone has anything to add please do so.

@nictrix could you, please, explain why you added pessimistic dependencies for 'apt' and 'yum-epel' in metadata.rb by the 3212c18 in #14 ?

This creates dep conflicts in old chef-repos.

Can we use simple depends ?

depends 'yum-epel'
depends 'apt'

I'm using the netdata_config resource to try to generate a netdata.conf file. I use the following in a recipe called configure.rb which is being called in the .kitchen.yml:
`netdata_config 'web' do
configurations(
'bind to' => 'localhost'
)
end

netdata_config 'test' do
configurations(
'text goes' => 'here'
)
end`

My netdata.conf comes out with only a web section. I can see that the recipe definitely overwrites the original netdata.conf. I haven't been able to get it to properly create more than one section though. Running on cent6.7.

Support for Chef 12 client and ChefDK 1 will be discontinued.

https://blog.chef.io/2018/02/16/preparing-for-chef-14-and-chef-12-end-of-life/
https://www.chef.io/eol-chef12-and-chefdk1/
https://docs.chef.io/platforms.html

In #22 we discovered that the netdata cookbook requires compat_resource dependency and decided to support Chef 12 until EOL in #24

Here is the issue to follow along the life of Chef 12 in netdata cookbook.