jneufeld / clines Goto Github PK

Creating an array of structs to track the stats for each one is a waste of memory and makes things more complicated than they need to be. Use one struct for the current file's stats and one struct for the global stats. This is simpler and more efficient.

A dedicated tests directory with more elaborate test files would make testing more thorough. Test files can be popped into their own subdirectories and run from the main directory.

Python is nice, I use it now. Add support for Python files!

Your code is vulnerable to buffer overflow. Instead of using a dynamically expanding buffer to read in the line, you use a static array of size 256 with no bounds checking.

Also, consider using the function fgets. It basically does that reading in loop for you.

If you'd like, I'll fork it and submit a patch.