Message of the Day (MOTD) not sent about mud-server

[joshgit]

It looks like you merged everything. Maybe I should have warned you. I did no testing. I wanted to comment more, but my pull request has disappeared. I have next to no familiarity with github, but it does seem convenient.

That event thing looked bad, so I did rip it out. Now, the main class should be looping through the clients to pull input out of them, in theory. I haven't revisited that yet, though. Feel free to undo everything until I fix things/do any real testing.

You are quite zealous with your use of synchronized and instance of.

[jnharton]

Oh, yeah. I have a backup from before the initial merge. You know in case I get too fed up with constant change and want to look at a clean version of the original before all this got started (with all it's constituent flaws... :P). A warning would have been nice (testing would be a good idea as well -- I use Eclipse to code, you?), sorry if I rushed into that. Most of what I was able to understand from the diffs seemed to be positive change, even if it isn't exactly the way I might do it. I wanted to do so before you tacked on more than I could chew in terms of understanding what you did.

When I do something that resolves the pull request normally, GitHub seems to automatically close it. I can see a list of closed pull requests I think, can you?

My impression of the Event thing was that was an appropriate way to do it. It basically amounted to there a being a method defined that the Server class would look for initially? and then invoke each time a client connected. Maybe not the best way, but a way. Part of this is that I started writing this thing in Processing (http://www.processing.org/) which is a sort of Java IDE in a sense, but offers it's own libraries that you use instead of directly using standard Java libraries (the stuff from sun,etc). I think it was meant to simply doing things that might normally be a bit more complicated. It was even subclassed from PApplet (the parent for all Processing "sketches") originally, which is why I have a utils class that had a basic implementation by me of some of the function from functions from the processing library. I removed the extends and had to replace the functionality that I didn't have access to anymore. I was using their net library for this and I had been reluctant to mess with it since I don't have a perfect understanding of how to replace it.

[jnharton]

Synchronized is used because a few things are modified in more than one place and it was the easiest solution at the time to prevent concurrent modification exceptions and other such things. Not sure about the instanceof, I'm sure there was a reason when I wrote it.

[jnharton]

RESOLVED, was a problem with loadBytes function not returning the byte array