Problem with concurrent modification regarding the collection of client objects the server holds about mud-server

[jnharton]

For now, I'm going to switch that specific piece of code to use the function that gets a Client array (which I added back in ago in a recent commit under the alternate function name getClients_alt() )

[joshgit]

You can't modify a collection while iterating over it. This is a better fix:

    public Vector<Client> getClients() {
    return new ArrayList<Client>(clients);
}

It's almost always better to use collections and this just copies the current one.

[jnharton]

Do point out if I misunderstand. The thing is that it's possible to try to modify them and that could happen, and would then throw an exception. How is that an improvement? True it's a collection, but I can iterate over an array as well.

[joshgit]

You can iterate over either, especially since they are copies. It's only bad if you modify the original collection.  But working with arrays might mean you later want to modify it and can't.  Working with an ArrayList means you get all of the functionality of an array and an arraylist at essentially no cost, including things like contains().

---

From: Jeremy Harton [email protected]
To: jnharton/mud-server [email protected]
Cc: joshgit [email protected]
Sent: Friday, February 1, 2013 9:01 PM
Subject: Re: [mud-server] Problem with concurrent modification regarding the collection of client objects the server holds (#7)

Do point out if I misunderstand. The thing is that it's possible to try to modify them and that could happen, and would then throw an exception. How is that an improvement? True it's a collection, but I can iterate over an array as well.
—
Reply to this email directly or view it on GitHub.

[jnharton]

issue ought to be re-evaluated post merge.