GithubHelp home page GithubHelp logo

ratio's People

Contributors

jobatabs avatar

Watchers

 avatar

ratio's Issues

Code Review (Koodikatselmointi)

Project downloaded 29.4.2023 (12:45).

Software Requirements Specification is clear and well-laid out and it even includes a plan for the graphical user interface, great!

While the software is somewhat simple, it has an excellent build structure, and module names are logical. All classes follow a unified naming style and most of the classes and functions have already the Docstring documentation included, nice! Awesome Class Diagram included within the software documentation!

Some modules and/or functions are missing documentation (see "calculations.py", probably just because it's a work-in-progress). While I think the specified module (calculations) is simple enough to be understood rather quickly, I'd suggest keeping the documentation uniform to match the course standards; why is the module important, and what purpose does it serve?

In general, it's easy and satisfying to read the software code, everything is written out so well! It's easy to understand the functionality of any specific code and debugging is just that much easier. All tests run successfully with 100% coverage, excellent!

If you wish to strive for the maximum points, I'd suggest implementing the long-term memory functionality you've mentioned in the Software Requirements Specification. 4 points out of the total 24 are still determined by the complexity of long-term memory functionality.

Overall, the code is top-notch and it's safe to say it meets the course's quality requirements without trouble. Good job, keep it going!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.