Comments (12)
A thought: if you're alright with it, we could port Android's Base64 over and use that (to minimize work of re-implementing base64 encoding). It's also licensed under Apache 2.0.
from joda-convert.
I'd be happy to see a pull request to replace the base64 use with a package scoped utility class. I don't want to add any dependencies on other projects however. Ideally, I'd like to have all the code in Joda-Convert under my own copyright for simplicity (which preludes simply porting code owned by someone else without their permission).
from joda-convert.
Excuse my ignorance, but what difficulties are introduced by using code from another copyright (but is open sourced)?
from joda-convert.
Those companies that examine projects look more deeply when there are multiple licenses involved - its not just Apache 2 that matters, but the copyright notices. It also prevents me from upgrading the code to a different license, say a future Apache 3. It would just be nicer to have a from-scratch implementation, but perhaps we have to start by copying code from Apache Commons.
from joda-convert.
Does the output have to be Base64? I can't find an output format specified anywhere. If it doesn't matter, would your org.joda.convert.factory.ByteObjectArrayStringConverterFactory work? It's not as compact a format, but already meets your authorship/license requirements.
from joda-convert.
I've implemented a Base64 encode/decode
from joda-convert.
Thanks! It helps iOS users, too:
$ j2objc -d /tmp/joda -classpath ~/.m2/repository/com/google/guava/guava/18.0/guava-18.0.jar -sourcepath src/main/java `find src/main/java -name *.java`
translating src/main/java/org/joda/convert/AbstractTypeStringConverter.java
translating src/main/java/org/joda/convert/AnnotationStringConverterFactory.java
translating src/main/java/org/joda/convert/EnumStringConverterFactory.java
translating src/main/java/org/joda/convert/factory/BooleanArrayStringConverterFactory.java
translating src/main/java/org/joda/convert/factory/BooleanObjectArrayStringConverterFactory.java
translating src/main/java/org/joda/convert/factory/ByteObjectArrayStringConverterFactory.java
translating src/main/java/org/joda/convert/factory/CharObjectArrayStringConverterFactory.java
translating src/main/java/org/joda/convert/factory/NumericArrayStringConverterFactory.java
translating src/main/java/org/joda/convert/factory/NumericObjectArrayStringConverterFactory.java
translating src/main/java/org/joda/convert/FromString.java
translating src/main/java/org/joda/convert/FromStringConverter.java
translating src/main/java/org/joda/convert/FromStringFactory.java
translating src/main/java/org/joda/convert/JDKStringConverter.java
translating src/main/java/org/joda/convert/MethodConstructorStringConverter.java
translating src/main/java/org/joda/convert/MethodsStringConverter.java
translating src/main/java/org/joda/convert/ReflectionStringConverter.java
translating src/main/java/org/joda/convert/RenameHandler.java
translating src/main/java/org/joda/convert/StringConvert.java
translating src/main/java/org/joda/convert/StringConverter.java
translating src/main/java/org/joda/convert/StringConverterFactory.java
translating src/main/java/org/joda/convert/ToString.java
translating src/main/java/org/joda/convert/ToStringConverter.java
translating src/main/java/org/joda/convert/TypedAdapter.java
translating src/main/java/org/joda/convert/TypedStringConverter.java
translating src/main/java/org/joda/convert/TypeStringConverter.java
translating src/main/java/org/joda/convert/TypeTokenStringConverter.java
Translated 26 files: 0 errors, 0 warnings
There are a few test failures, which are likely due to problems with j2objc's JRE emulation.
from joda-convert.
@jodastephen would it be possible to get an official release on Maven Central with this fix 962dd4c?
We are trying to get joda-convert easily usable in Gradle projects shared across Android and iOS, and this commit is currently the blocker:
https://travis-ci.org/j2objc-contrib/j2objc-common-libs-e2e-test/jobs/82347638
Thanks!
from joda-convert.
@jodastphen - Thanks for your work on this. Can I echo the request from @advayDev1 for an official release with the fix. This'll make it much easier to use it on iOS using Google's J2ObjC (Java to Objective-C translator).
from joda-convert.
Corrected name:
@jodastephen - Thanks for your work on this. Can I echo the request from @advayDev1 for an official release with the fix. This'll make it much easier to use it on iOS using Google's J2ObjC (Java to Objective-C translator).
from joda-convert.
v1.8 released
from joda-convert.
@jodastephen - thanks for the new release.
@advayDev1 - let's give this a whirl...
from joda-convert.
Related Issues (20)
- Support Guava TypeToken
- Test error at org.joda.convert.test1.Test1Class HOT 2
- Why does FromStringConverter.convertFromString have a Class param? HOT 2
- TestJDKStringConverters::test_InetAddress is too restrictive in its expected output HOT 1
- Guava dependency is not optional at runtime
- Superclass-searching in findAnyConverter results in invalid conversions HOT 4
- Cannot convert Class representing primitive type
- Add Automatic-Module-Name HOT 1
- Move project to Java 8 HOT 1
- Dynamic Java 8 code extends Guava code HOT 1
- Remove direct dependency on Guava
- Add JPMS module-info
- Include Guava code directly avoiding reflection
- Fails with 'Two methods are annotated' when the `@ToString` method is a specific implementation of a generic interface HOT 1
- Using latest version with Android, results in broken build HOT 2
- String replacement doesn't work HOT 9
- Configure renames by configuration
- Migrate LGTM.com installation from OAuth to GitHub App
- if fullName is "[B" then is could be resolved by Class.forName(fullName) but is not resolvable using loader.loadClass(fullName)
- Support Java SE 8 primitive Optional classes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from joda-convert.