joelroxell / borsdata-sdk Goto Github PK

• /v1/instruments/{id}/reports/{reporttype}
• /v1/instruments/{id}/reports

Hey Joel, really nice client/sdk here. I was thinking about creating something similar earlier although primarily with pandas DataFrames result sets. Could be implemented as a method kwarg here I guess. I think it would be super valuable as most python users will be using pandas with the API anyway.

Or if this lib should be kept with minimal dependencies then maybe a pandas wrapper lib for this. What do you think?

• instruments
• instruments/updated

Code:
from borsdata_sdk import BorsdataAPI
borsdata = BorsdataAPI(myApiKey)
instruments = borsdata.get_instruments()

Error:
----> [3] instruments = borsdata.get_instruments()
TypeError: init() got an unexpected keyword argument 'stockPriceCurrency'

Message from borsdata support:
Hej,

Det är Python libet du använder som har problem med att vi lagt till fler parametrar i Json,
Det borde fungera att lägga till i Json men ditt Python lib kan inte hantera detta.
Då detta är 3d-part så behöver du själv lägga in dessa två värden i Instruments filen,

https://borsdata.se/news/orginalrapportvaluta

Mvh
Henrik

• branches
• countries
• markets
• sectors

When my account was compromised a spam issue was created in this repo. I sincerely apologize. Cleaning up such issues via script.

The API seems to set it, but from the swagger it does not seem to be an available parameter.

Swagger: https://apidoc.borsdata.se/swagger/index.html

• instruments/{insid}/kpis/{kpiId}/{reporttype}/{pricetype}/history
• instruments/{insid}/kpis/{kpiId}/{calcGroup}/{calc}
• instruments/kpis/{kpiId}/{calcGroup}/{calc}
• instruments/kpis/updated

Stated in your Readme, but is not found when applied. Would be awesome to have!

• instruments/StockSplits

Please add support for 20 years history recently available in the API. See APIUpdate

Probably a very minor change. I tested by adding the line
params.update({'maxcount': 20})
at line 138 to update the get_instrument_stock_price method for instance and that seemed to do the trick for that method.

• instruments/{insid}/stockprices
• instruments/stockprices/last