joemrcoffee / ournoteorganizer Goto Github PK

If there are duplicate tasks with the same content associated with the same post it can cause an issue in the comment section.

Root cause: the look up for the task is done based on the content of the comment not a unique ID. This is because the comment collection and the tasks collection are separate from each other with the comment being created at the same time the task is created.

This is a minor issue which most users would not come across, but if say the task creation form is resubmitted it can throw an issue there the tasks displays in the viewpost page multiple times based on how many duplicates there are. Basically number of duplicates^2.

Need to consider how to get the unique ids associated with the comments and tasks. Likely easiest to grab the unique ID on task creation, then insert that with the comment.

Hello 👋

I run a security community that finds and fixes vulnerabilities in OSS. A researcher (@michaellok001) has found a potential issue, which I would be eager to share with you.

Could you add a SECURITY.md file with an e-mail address for me to send further details to? GitHub recommends a security policy to ensure issues are responsibly disclosed, and it would help direct researchers in the future.

Looking forward to hearing from you 👍

🟢 This report is most likely not a false positive, you can take the report seriously.

(cc @huntr-helper)