joerg65 / tedee_lock Goto Github PK

First off, thanks for this integration - it's working really well.

The one issue I've found is that there seems to be some inconsistency with the "pullstring support" state and the supported_features attribute.
In my case, the lock does not have pullstring enabled, and the attribute correctly reports that. However, in this section of the code, the supported_features is hard-coded to report the value 1:

    @property
    def supported_features(self):
        return SUPPORT_OPEN

Unless I misunderstood the documentation, the SUPPORT_OPEN means, opening the latch, which is the same thing... so this value is wrong (it should be 0 in my case, and not 1).

The impact of this is that some lovelace cards will show an "Open" button if they see that value as 1 - for example, the Mushroom Lock card does this (the button obviously does nothing, but it should not be there in the first place...)

After updating to the new lock.py the lock attributes are not available anymore

A rollback brings back the attributes, but also the device_state_attributes error message.

Core 2021.12.10 on HA OS virtual machine.

Could you please use the HACS repository structure so that this extension can be easily loaded using HACS? Thanks!

In future versions of HA the manifest.json needs a version key.

2021-03-03 22:22:17 WARNING (MainThread) [homeassistant.loader] No 'version' key in the manifest file for custom integration 'tedee'. This will not be allowed in a future version of Home Assistant. Please report this to the maintainer of 'tedee'

Hi, would it be possible to expose battery level / battery charging as entity not as attribute? It would make it easier to add this information on dashboard.

Hi, I would like to ask if you plan to add feature which would allow to only lock the door. O would like to be sure that because of some bug my door will not be opened remotely.

I guess it would be easiest to handle this on token level (it would have right only to lock), but I haven't seen there this option.