johnabassian / blesmol Goto Github PK

the service should be able to respect changes to settings without having to restart.

Int64 Blesmol.Core.Units.ConvertFromBytes(Int64 bytes, Unit unit) will throw a DivideByZeroException if the unit parameter is supplied with a Unit.Percentage value.

implement best practices for registry reading and manipulation, e.g. properly dispose opened keys.

DriveStatus instance is not found and so current time is sent instead of the AlertingStartTime property:
SendAlerts(..., AlertingDrives.FirstOrDefault(x => x.DriveName == driveInfo.Name)?.AlertingStartTime ?? DateTime.Now, ...);

this is because the DriveInfo instance is initialized with a different name than what is used to look it up:
String driveName = driveInfo.Name.Replace(@":\", "");
if (!alerting) AlertingDrives.Add(new DriveStatus() { DriveName = driveName, Alerting = true, AlertingStartTime = DateTime.Now });
SendAlerts(..., AlertingDrives.FirstOrDefault(x => x.DriveName == driveInfo.Name)...);