jojomo96 / minishell Goto Github PK

• #50
• fix pipes combined with and and or

unset -TEST ➡️ 2
unset TES;T ➡️ 127
export --TEST=123 ➡️ 2

issue for all the leak related stuff
exspecially the stuff we can't fix with ft_malloc

ToDos

External

• getcwd() mallocs

Internal

• ft_init_split_state() mallocs
• strjoin in ft_process_file
• itoa in handle_shlvl
• split in ft_export_print
• itoa in close fds

Strdup

• in ft_handle_split
• in ft_split_on_delim
• in ft_env_get
• in ft_init_wildcard_data
• in ft_handle_env_variable
• encase_outer_quotes

Malloc in GC

• check for proper malloc protection in gc, where normal malloc has to be used

• #55
• #99
• #44
• #89

currently only executed leafs get expanded

bash-3.2$ ./srcs/
bash: ./srcs/: is a directory
bash-3.2$ echo $?
126

currently 127

bash export technically supports += which joins the previous with the new entry

if a env expands inside the redirect, it is not allowed to contain spaces. I think ...

bash-3.2$ export test='c d e f'
bash-3.2$ echo a >> test$test
bash: test$test: ambiguous redirect
bash-3.2$ echo a >> $test
bash: $test: ambiguous redirect
bash-3.2$ echo a&& (echo a >> $test )
a
bash: $test: ambiguous redirect

to clear

• ?
• *
• double quotes
• single quotes

• $? last exit code
• $ENV the value of the env if given, otherwise empty string
• * all files in current dir
• ~
• other wildcards using * like *.c (only for current working dir)
• should probably remove the outer most quotes after expanding

unlike just hitting enter, this should error

bash-3.2$ ""
bash: : command not found
bash-3.2$ echo $?
127

add check to see if there is actually a tree, otherwise just read again

👋 minishell ➜ 
zsh: segmentation fault  ./minishell

In the Shell

• ctrl+C displays a new prompt on a new line.
• ctrl+D exits the shell
• #39

In Heredoc

always reset everything before and after heredoc

• ctrl+C leaves heredoc
• ctrl+D does nothing if something typed, leaves if current line empty
• ctrl+\ does nothing

echo "cat lol.c '|' cat > lol.c"

should just be one echo

>> '$USER'

create file even if left side is empty

input:

echo test1		test2

expected:
test1 test2 (ein space)

currently:
test1 test2 (zwei tabs)

/ls should be treated as direct path, and therefore not work

Current

stuck in first cat, CTRL+C continues with the other stuff

👋 minishell ➜ cat | cat | ls
DEBUG: New node created: Leaf:          arg[0]: cat 
DEBUG: New node created: Node:          |
DEBUG: New node created: Leaf:          arg[0]: cat 
DEBUG: New node created: Node:          |
DEBUG: New node created: Leaf:          arg[0]: ls 
DEBUG: Executing command: cat
DEBUG: /bin/cat

^C
👋 minishell ➜ DEBUG: Executing command: cat
DEBUG: Executing command: ls
DEBUG: /bin/cat
DEBUG: /bin/ls
Makefile    b           b c d       ho baum     includes    libft       minishell   obj         srcs        subject.pdf test

Expected

1. outputs ls output
2. enter twice and it leaves

bash-3.2$ cat | cat | ls
Makefile    b           b c d       ho baum     includes    libft       minishell   obj         srcs        subject.pdf test


bash-3.2$ 

echo hi | cat < Makefile 

should print Makefile contents not "hi". in this case the redirect should have priority over the pipe

this is supposed to work. the value is 4=2

export NEW=4=2
env | grep 4=2

exports prints a list of all exports (even the ones that were not assigned) -> thus there needs to be a second copy of envs for this

bash-3.2$ env
  PWD=/Users/flfische/core/minishell
  SHLVL=1
  _=/usr/bin/env
bash-3.2$ export   
  declare -x OLDPWD
  declare -x PWD="/Users/flfische/core/minishell"
  declare -x SHLVL="1"
bash-3.2$ export test
bash-3.2$ export
  declare -x OLDPWD
  declare -x PWD="/Users/flfische/core/minishell"
  declare -x SHLVL="1"
  declare -x test
bash-3.2$ env
  PWD=/Users/flfische/core/minishell
  SHLVL=1
  _=/usr/bin/env

ls|cat Makefile|<wc -l

returns 0 instead of 1

redirect in is stuck afterwards and enter segfaults the shell

add a wrapper for execve

Input

echo a && echo b c

if export happens without value (but =) there should be an = in the env.

export USER=
env | grep USER

currently only adds USER not USER=

/bin/echo 42 > /dev/null > /dev/null > /dev/null > /dev/null > tmp_redir_out

should result with 42 in the tmp_redir_out file. currently it gets created but is empty