jonbo / node-steam-webapi Goto Github PK

Currently, you have to put all code that might need WebAPI into the callback to Steam.ready. This is inconvenient and not technically necessary, since existing methods don't change.

I propose to add an ability to pass prepared JSON from GetSupportedAPIList to the library, thereby avoiding the need to download it dynamically every time. For example, Steam.ready could accept the parsed JSON instead of the callback.

Leaving out certain steamObj parameters while using the getOwnedGames method results in thrown Errors.

/node_modules/steam-webapi/index.js:129
throw new Error("Missing required field: "+key);
Error: Missing required field: include_appinfo

/node_modules/steam-webapi/index.js:129
throw new Error("Missing required field: "+key);
Error: Missing required field: include_played_free_games

/node_modules/steam-webapi/index.js:129
throw new Error("Missing required field: "+key);
Error: Missing required field: appids_filter

Is this intended behavior? Documentation for getOwnedGames states: 'Free games are excluded by default.'

We are occasionally seeing connection timeout errors.

Will node-steam-webapi still be in a usable state after this, or do we need to handle it?

 Error: connect ETIMEDOUT xxx_redacted_valve_ip_xxx:443
   File "util.js", line 874, in Object.exports._errnoException
   File "util.js", line 897, in exports._exceptionWithHostPort
   File "[as oncomplete] (net.js", line 1063, in TCPConnectWrap.afterConnect

The current version you have for the library has issues with vulnerabilities. Please update the version and republish to npm

Problem:

The 'getPublishedFileDetails' method requires the key 'publishedfileids[0]' with the [0] included.

Code

const Steam  = require('steam-webapi');
Steam.key = apikey;
Steam.ready(function(err) {
	if (err) throw (err);

	var steam = new Steam();

	steam.getPublishedFileDetails({"itemcount": "1", "publishedfileids[0]": "835533549"}, function(err, data) {
		if (err) throw (err);
		console.log(data);
	});
}

Result:

"Missing required field: publishedfileids"

Code 2:

//Changed object key
{"itemcount": "1", "publishedfileids": "835533549"}

Result 2:

"HTTP 400 Bad Request"

Cause:

paramName = paramName.replace("[0]","");

Commenting out this line located in 'getParams' in the index.js file will make the request work as intended, returning the full request body properly. I have not made a PR because I do not know if removing that line will break other methods or not.

Hi,

I'm following your examples word for word but I get the Unresolved function or method resolveVanityURL() in Webstorm and when I run the program I get TypeError: Object [object Object] has no method 'resolveVanityURL' in the console.

I also couldn't find any function named resolveVanityURL or any such function in index.js in the root folder of the project. Is that still how the api is accessed?

Hi,

I don't see the ISteamMicroTxn interface in the list, or in the response to retrieveSteamAPIMethods(). Is there some reason why this interface isn't supported? (since it's all auto-generated).

Thanks

Could you give examples such as getting games from dota2 with certain heroes?

Or just more examples in general?

Some steam methods exist on multiple interfaces, e.g.:

ISteamMicroTxn.initTxn
ISteamMicroTxnSandbox.initTxn

How do you select between the two with this wrapper? (as it seems to omit the interface name).