jonofmac / vpw_analyzer Goto Github PK

Trying to close the script often times causes the program to crash or hang.

I believe this is due to the serial thread not receiving the command to close and causing a hang-up.

Would be nice to add some timestamp support

No data is received with OBDLink MX bluetooth devices.

The issue is because the OBDLink MX device does not seem to have new lines enabled by default.

Create a VPW message class to store messages in, rather than these convoluted arrays

Right now, the software opens the port and sends off commands. Sleep delays help with higher latency connections. Need to write functions to check the response from these requests to improve responsiveness and do some error checking

Threading needs to be reworked to properly hand data between the threads.

Right now the forked thread directly calls the UI thread's functions. Normally this would cause issues, but somehow it works in python... The correct way would be to use a queue to safely pass data between the threads. This should also improve performance.

Seems to be an issue where duplicate messages are not always properly getting recognized as duplicates or the message pointer from the summary to the message ID field is incorrect.

Currently vpw_analyzer does not have the ability to send messages.

This is primarily due to the fact that the ELM327 command set does not allow a graceful way to send a message without risking losing a message incoming.

The basic process to send a message while datalogging with a ELM327 device is this:

1. Configure device
2. Enter AT MA (monitor all) mode to see all bus traffic (vpw_analyzer's primary mode)
3. Cancel AT MA mode
4. Configure desired headers
5. Send message
6. Device waits some amount of time to see if it gets a response to the specified headers (ignoring other traffic)
7. Enter AT MA mode to continue seeing messages

Steps 3-6 mean that there's a window of time that messages can (and most probably will) be dropped. This is an inherent weakness with the standard ELM327 commands.

Some more advanced devices (OBDX VT Pro) offer additional modes to allow transmission while receiving messages. The decision needs to be made to support both modes or only the safer OBDX modes.