Comments (4)
Changed it to:
A negative lookahead won't work. The node version is wrong in package.json, it should be 8.6 I think.
And it hasn't errored yet. I don't know if my fix will break anything though.
Are you saying all of the unit tests passed?
from data-store.
@jonschlinkert haven't run unit tests, but it worked to temporarily fix my project.
from data-store.
Before change:
store
create
✓ should create an instance of Store
1) should create a store with the given `name`
✓ should initialize a store with the given defaults
set
2) should `.set()` a value
✓ should `.set()` an object
3) should `.set()` a nested value
4) should save data that is added directly to `storedata`
union
5) should add and arrayify a new value
6) should uniquify duplicate values
7) should union an existing value
has
8) should return true if a key has a value
9) should return true if a nested key has a value
hasOwn
10) should return true if a key exists
11) should work with escaped keys
12) should return true if a nested key exists
get
13) should `.get()` a stored value
14) should `.get()` a nested value
union
15) should `.del()` a stored value
del
16) should delete stored values
17) should delete a nested stored value
18) should ignore nested properties that do not exist
19) should delete multiple stored values
json
20) should use the indent value defined on ctor options
3 passing (22ms)
20 failing
...all the fails are because
SyntaxError: Invalid regular expression: /(?<!\\)\./: Invalid group
at split (index.js:392:26)
at set (index.js:438:10)
at Store.set (index.js:73:7)
at Context.<anonymous> (test/test.js:167:13)
after:
store
create
✓ should create an instance of Store
✓ should create a store with the given `name`
✓ should initialize a store with the given defaults
set
✓ should `.set()` a value
✓ should `.set()` an object
✓ should `.set()` a nested value
✓ should save data that is added directly to `storedata`
union
✓ should add and arrayify a new value
✓ should uniquify duplicate values
✓ should union an existing value
has
✓ should return true if a key has a value
✓ should return true if a nested key has a value
hasOwn
✓ should return true if a key exists
1) should work with escaped keys
✓ should return true if a nested key exists
get
✓ should `.get()` a stored value
✓ should `.get()` a nested value
union
✓ should `.del()` a stored value
del
✓ should delete stored values
✓ should delete a nested stored value
✓ should ignore nested properties that do not exist
✓ should delete multiple stored values
json
✓ should use the indent value defined on ctor options
22 passing (24ms)
1 failing
1) store hasOwn should work with escaped keys:
AssertionError [ERR_ASSERTION]: false == true
+ expected - actual
-false
+true
at Context.<anonymous> (test/test.js:158:7)
from data-store.
I eliminated the regex negative lookbehind that caused the error. Thanks for creating the issue
from data-store.
Related Issues (20)
- TypeError: Class constructor Store cannot be invoked without 'new' HOT 2
- store.set() key with dot dymbol HOT 1
- Inconsistency of undefined HOT 1
- Delete object inside array HOT 1
- error while using del method in typescript HOT 1
- Does store.load() delete the data?
- store.clear into store.set into store.load deletes whole store HOT 2
- Create optional lock file for use of the data-store by external process HOT 7
- Release Notes ? HOT 1
- Retrieving data-store HOT 1
- deprecated isObject HOT 1
- decreated isObject HOT 1
- NPM owner HOT 3
- v4.1.0 has not been published to npm HOT 6
- How can stored values be updated? HOT 1
- Does not seem to save new data, but reverts back to old data. HOT 6
- Data-store wont save anything. HOT 2
- How to pass a variable as key
- Depends on 2 high severity vulnerabilities
- Data store not reading correctly the file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from data-store.