GithubHelp home page GithubHelp logo

joomla-projects / plg_content_joomlarrssb Goto Github PK

View Code? Open in Web Editor NEW
10.0 14.0 18.0 174 KB

Social sharing plugin for the joomla.org websites using Ridiculously Responsive Social Sharing Buttons

PHP 62.33% JavaScript 33.43% CSS 2.73% Shell 1.50%
joomla joomla-plugin social-share

plg_content_joomlarrssb's Issues

Email sharing doesn't seem to be behaving correctly

When you click on the email share button and are using Outlook, you get the Title with + instead of spaces and a body call that stays in the subject line.

Changing line 25 of /plugins/content/joomlarrssb/tmpl/default.php
from
<a href="mailto:?subject=<?php echo urlencode($article->title); ?>body=<?php echo urlencode($itemURL); ?>">
to
<a href="mailto:?subject=<?php echo ($article->title); ?>&amp;body=<?php echo urlencode($itemURL); ?>">

Appears to fix this.

Use the API :)

Instead of using getimagesize in the plugin use the wrapper in the Image API (\Joomla\CMS\Image\Image::getImageFileProperties)

Wrong basepath?

Hi there,
we have an issue on j.org/3 that the /3 is shown twice
<meta http-equiv="og:url" content="http://repository.joomla.org/3/3/161-the-revolution-in-joomla-ux-improvements">

Don´t know if there is a misconfiguration or bug. Please help :-)

URLs not shortened

While sharing the election results, I noticed that URLs are not shortened anymore
index

icons in mobile view

Hi, the icons in the mobile view plugin are not fully displayed. Can you fix it?
mobile

Enabling this plugin breaks the articles api endpoint in 4.0.3

I like this little plugin and it works well for me. I realise it has limited scope but it does break the API for me.

Steps to reproduce

  1. Clone, build and install this plugin in a Joomla 4.0.3 site
  2. Enable it
  3. Call the articles API endpoint for your site using postman - /api/index.php/v1/content/articles with a correctly set token
  4. Expected result a list of articles in JSON
  5. Actual result 500 error
  6. Disable the plugin and run the query again
  7. Actual result a list of articles in JSON

everything.php log
`#
#
#Date: 2021-10-04 21:14:48 UTC
#Software: Joomla! 4.0.3 Stable [ Furaha ] 12-September-2021 10:39 GMT

#Fields: datetime priority clientip category message
2021-10-04T21:14:48+00:00 CRITICAL 86.27.156.11 error Uncaught Throwable of type ArgumentCountError thrown with message "Too few arguments to function PlgContentJoomlarrssb::onContentPrepare(), 3 passed in [...]libraries/src/Plugin/CMSPlugin.php on line 285 and exactly 4 expected". Stack trace: #0 [...]libraries/src/Plugin/CMSPlugin.php(285): PlgContentJoomlarrssb->onContentPrepare('com_content.art...', Object(stdClass), NULL)
#1 [...]libraries/vendor/joomla/event/src/Dispatcher.php(486): Joomla\CMS\Plugin\CMSPlugin->Joomla\CMS\Plugin{closure}(Object(Joomla\Event\Event))
#2 [...]libraries/src/Application/EventAware.php(111): Joomla\Event\Dispatcher->dispatch('onContentPrepar...', Object(Joomla\Event\Event))
#3 [...]api/components/com_content/src/View/Articles/JsonapiView.php(196): Joomla\CMS\Application\WebApplication->triggerEvent('onContentPrepar...', Array)
#4 [...]libraries/src/MVC/View/JsonApiView.php(128): Joomla\Component\Content\Api\View\Articles\JsonapiView->prepareItem(Object(stdClass))
#5 [...]api/components/com_content/src/View/Articles/JsonapiView.php(151): Joomla\CMS\MVC\View\JsonApiView->displayList()
#6 [...]libraries/src/MVC/Controller/ApiController.php(275): Joomla\Component\Content\Api\View\Articles\JsonapiView->displayList()
#7 [...]api/components/com_content/src/Controller/ArticlesController.php(78): Joomla\CMS\MVC\Controller\ApiController->displayList()
#8 [...]libraries/src/MVC/Controller/BaseController.php(730): Joomla\Component\Content\Api\Controller\ArticlesController->displayList()
#9 [...]libraries/src/Dispatcher/ApiDispatcher.php(59): Joomla\CMS\MVC\Controller\BaseController->execute('displaylist')
#10 [...]libraries/src/Component/ComponentHelper.php(389): Joomla\CMS\Dispatcher\ApiDispatcher->dispatch()
#11 [...]libraries/src/Application/ApiApplication.php(423): Joomla\CMS\Component\ComponentHelper::renderComponent('com_content')
#12 [...]libraries/src/Application/ApiApplication.php(110): Joomla\CMS\Application\ApiApplication->dispatch()
#13 [...]libraries/src/Application/CMSApplication.php(278): Joomla\CMS\Application\ApiApplication->doExecute()
#14 [...]api/includes/app.php(54): Joomla\CMS\Application\CMSApplication->execute()
#15 [...]api/index.php(31): require_once('[...]...')
#16 {main}`

Icons

what can i do with the buttons?
I don't like that the buttons span the entire width of the container. an icon alone would suffice.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.