GithubHelp home page GithubHelp logo

hook's People

Contributors

agirton avatar jordansinger avatar kounelios13 avatar paulmillr avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

hook's Issues

add events

instead of always reloading the page, add events, so we could add custom behaviour

License?

Hello,

I noticed neither the website or the code tells me which license this is released.

Can you tell us if is GPL, MIT, BSD?

Thank you.

Infinite reloading

My page will reload infinitely, I'm using chrome on ubuntu.

How to reproduce:

Faster WebKit detection

Instead of adding a whole $.browser function, you could replace it with a one-liner:

/webkit/.test(navigator.userAgent.toLowerCase());

It will be faster and smaller in terms of bytes.

Shouldn't fire when scrolled up from bottom

Hook should really only fire the reload when you're already at the top and try to scroll up. Not sure if you can detect that on all browsers but it works in OS X Chrome.

progressive enhancement

Great functionality. I would just suggest that you inject the #hook div instead of hardcoding empty divs in your html markup.

Simple implementation, as is:

$('body').prepend('<div class="hook" id="hook"><div class="hook-loader"><div class="hook-spinner"></div></div></div>').find('#hook').hook();

$.browser alternative

Looking through the code, it uses $.browser() for webkit, however this is no longer in jQuery as of 1.9 due to it being deprecated. jQuery suggests using feature detection (like Modernizr) as an alternative, but surely the code could check for the useragent rather than needing to pull in an entire library for a rather small purpose?

EDIT: Looked through again, and didn't notice the alternative code. D'oh! :-)

Issue with full screen video

Anytime a video on my site goes full screen then hookjs is called and refreshes the page.

I am using Drupal with a custom hook js module, and videojs for display
example: This link

Performance isn't great

This uses jQuery-based animation without leveraging requestAnimationFrame, so the computation uses CPU instead of GPU.

Have you considered leveraging CSS Transitions instead? They're well-supported and are fully GPU-accellerated.

iOS 7 (maybe all) Doesn't work unless you scroll from the very top

It seems using the newest version, I could not get this to fire. Then I tried pulling from the top of the browser (right below the address bar) and it works. Very strange, I tried with a previous version of Hook and it works like intended. Perhaps the is a bug in the latest version?

I have a basic bootstrap page up with hook (http://medinastudios.com/test/)

Trying pulling it down, it only seems to work when you pull next to the top nav bar.

Retina/Hi-DPI assets?

You're using a PNG and a GIF, which are fine for devices with a pixel-density-ratio: 1.0, but don't support Hi-DPI/Retina displays very well. Have you considered using vector assets instead? Either SVG or an icon-based web font?

License?

Your CSS file says "Copyright [...] All Rights Reserved."

This means that nobody is allowed to use it, legally. You need to give it a license so that people know the terms under which they're legally allowed to use it.

I would recommend against free-software (GPL-related) licenses, and instead recommend an open-source license (Apache 2.0, New BSD, MIT, etc.).

License

Hi there, I'm looking to use hook.js but I'm wondering about the license attached to it.
Can you tell under which license your code is available? And add it to the repo?

Thanks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.