josdemmers / diablo4companion Goto Github PK

I have weapon which base has +Critical Strike Damage, it also have the same affix, it keeps switching green circle form one to other
see recording
http://g.recordit.co/yJlNzvplSP.gif

Currently the scan seems to only happen when mouse is moved, it would be good to have this also happen when using a controller.

Hello,

I am trying your tool as we speak, and I think it can be very helpful !
While using it, I had a few ideas on how it could be improved:

• Allow to prioritize the affixes (dragging & dropping them as a list) and display the priority in the overlay

• provide us with a link where we can send our own screenshots so you can add them to the next release
• replace the "_" with spaces when you research : I am guessing the search is based on the screenshot name. If I have "all_stats.png", it would be nice to be able to search "all stats"
• I'm unsure why there is two image folders but if possible, merge the normal and light image folders
• Maybe a disclaimer should be added to the README if there is any risk using the tool ? I know Blizz isn't too nice with 3rd party softwares

Thanks again for this tool !

on lucky hit chance affix spelled "lucky hit change" which breaks it.

Hi, I don't know if they just haven't been implemented yet, but I noticed some affixes are missing and not available as choices to search on tooltips. For example, on my twisting blades Rogue, there's no option to search for "Ranks of shadow imbuement", "Energy cost reduction", or "Ranks of the Weapon Mastery passive"

Hi,

would it be possible to have multiple gear affix presets being active at the same time?
Currently I am playing a Stormclaw Druid build. And ofc I want to identify gear upgrades for that build easily.
But at the same time, I want to start collecting gear for another build, which needs different affixes.
So when only having one gear affix active, I could miss an item of the other preset.

A way to accomplish this could be, that each preset has a number attached. And this number is displayed at the green bubbles. So I easily could spot if that item is helpful for build 1 or build 2.

Cheers

@josdemmers Selecting the damage reduction affix shows as green on distant and close enemies affix as well, solved it by changing the damage reduction image to this with blank space below, any other better/easier ways to fix this? 1440p preset

The green / red indicators are not showing up, as soon as the Occultist trading window is opened. No matter which tab is selected.

When the Occultist window is closed, it works again.

When font size is set to large the words "Legendary X" such as "Legendary Amulet" or "Legendary Gloves" are split across 2 lines making it impossible to create a new resolution preset.

An additional highlight marker if an Affix roll is good.
For exaple, the +# mana Affix can roll from 3 – 9 . If the Affix roll is >7 then add another identifier.
So with the existing Diablo4Companion format you could add another dot marker if the roll is good.
Just an idea.

Thanks

hi! i got resolution 3440:1440, sdr, medium fonts. base on 1440p_SMF_en
I dont selected any resistance in any item, and i selected intelligence for weapon, next see scrinshots...

in boots i see poison res but not see mana cost(i selected mana cost)

and i dont see ball lightning and total armour(non selected only fire res):

P.S. please add auto-update for image folder when set screenshots for affix/aspect, i need restart app for set it...

first i would thank you for this campanion app for Diablo 4 , its amazing especially the newer version its working as intended.

But i did notice some high CPU usage when Overlay is enable which makes its impossible to play while the overylay is on.

Show button if got X+ good affix

Or just always show button for fast search item on trade.

Might be worth to work together with the guys over at https://github.com/inn3rvoice/inventory_alpha

Has some very similar features, as well as a database of scanned items for trading and/or reference.

(I'm not affiliated in any way, I just like both projects)

Hello
I just saw this report. Do you think this also applies to your software? Because that would mean you could get banned by using D4 Companion right now, right?

Missing Rank of Blood Lance

Example :
Helms : Life on Kill
Gloves : +ranks to rapid fire / crit strike with imbued skills / crit % vs injured
Boots : Energy Cost Reduction

I will try to add them via the wiki guide

Now the demand of users in mainland China is particularly large, will the author consider withdrawing from the Simplified Chinese version?

What exactly am I missing here?

I had it work once the other day, but now it doesn't. Shows up in the debugger but nothing in the actual overlay.
My resolution is 1080p but it still worked with the 1440-lite mode before.

I had been using 1.14 without any problems, then upgraded to 1.15 and then 1.16 without playing Diablo. Started up Diablo again and DIablo Compnaion doesn't seem to work any more.

It doesn't put the green or red dots on my tooltips any more.

It runs, but can't seem to find the tooltips on the screen. It also sometimes doesn't seem to be able to capture the screen, or at least it doesn't update the capture shown in the window looking at the debug screen.

For example, it will show my character with my inventory open, but when I mouse over an item and the tooltip pops up, Diablo Companion still shows just my character's inventory, with no tooltip open. This is viewing Diablo Companion's debug menu.

FInally, when it does seem to attempt to look for a tooltip, it displays a rectangle on the debug menu that consists of the right third or half of my character pane, when the tooltip is to the left of my character.

I'm running 3440 X 1440, medium font, non-Hdr, on Windows 10, using images I've snipped myself, that used to work with older versions of the program.

This latest version also couldn't find my screen images directory until I stuck a "p" in my existing directory name. I only added it because I noticed that the predefined resolutions had a "p" in them. Nothing on the roll your own resolution wiki mentions that, nor any other required changes to the stuff in the Images directory.

Thanks in advance!

Hey man,

as you can see here

the affixes for druid totems are not getting recognized. Any idea why?

Hello, i'm playing Diablo 4 on a 42' full HD TV.
I followed the instructions, selecting full HD smf en preset, then importing a Gear preset from max roll (infinimist import Is not working, so i used corpse explosion instead), enabled overlay and controller support but the green/Red dots are not appearing next to affixes.
May the different DPI of a TV be the problem?

it's still crashing and some affix are not detected.

logging.log

trying to put together a barb build here and it seems there is a lot of missing affixes like life on kill ranks of death blow stuff like that is there a way we can add to the list of affixes?

When using keyboard shortcuts to switch configurations, the name of the current configuration is displayed on the overlay layer

Just updated to V2.3 and now there is no tooltip dots showing up, worked before updating.

Hover function does not work when using controller. Works as expected when mouse is used.

OS: Win 10 Pro
Controller: Xbox controller using wireless adapter (non-blutooth)

The app is crashing on startup.

Faulting application name: D4Companion.exe, version: 2.3.0.0, time stamp: 0x64b06a5d
Faulting module name: KERNELBASE.dll, version: 10.0.22621.2715, time stamp: 0x10f6a783
Exception code: 0xe0434352
Fault offset: 0x000000000006565c
Faulting process id: 0x0x3790
Faulting application start time: 0x0x1DA1ED8BA33DCE9
Faulting application path: C:\Users\XXX\Desktop\Diablo4Companion_v2.3.0.0\D4Companion.exe
Faulting module path: C:\WINDOWS\System32\KERNELBASE.dll
Report Id: c6d5123e-b330-411c-a83d-753205599668
Faulting package full name:
Faulting package-relative application ID:

Hey, nice work but I noticed that class specific affixes are missing.

This is a list of affixes missing for bone spear necro build:

+X to Bone Spear
Maximum Essence
5. Lucky Hit: Up to 5% Chance to Restore Primary Resource
6. Lucky Hit: Up to % Chance to Slow
Essence Cost Reduction
+xx Ranks to Corpse Tendrils
+xx Ranks to Evulsion
Critical Strike Damage with Bone Skills

One general one:

% Total Armor

How do we report affixes so you can implement them?

One of the preferred affixes for a couple of my items is:

Lucky Hit: Up to a 5% Chance to
Restore +XX% Primary Resource
[YY.Y - ZZ.Z]%

XX, YY and ZZ are variable.

It shows up as 3 lines on my screen resolution/font size.

Using a rectangular clip of from one of my items, of the complete 3 line text, D4 Companion has no trouble recognizing it as a "green dot" affix on that item. On another item with the same affix, but different values for XX, YY and ZZ, however it shows up as a "red dot" affix.

I've tried just using the first two lines, but that still doesn't work, implying that it's the XX% that's causing the image comparison to fail.

I've tried just using "Primary Resource", but that causes both items to display the red dot.

I've also tried adjusting the Affix Similarity Threshold up and down, with the highest and lowest value still failing.

The two items are a focus and a pair of gloves, if that makes a difference.

My screen resolution is 3440X1440, Medium Font, non-HDR.

Is it possible to use a non-rectangular clipping region, to omit the XX part from the clip?

Is there another way to make this work the way I want it to, without creating a clip with every conceivable percentage for XX and making each clip active for the items with this desired affix?

The "Heal" version of this affix is identical in format, with "Heal" replacing "Restore" as the first word on the second line, meaning I can't just clip the first line and use it.

Thanks for a neat time-saving helper!

Hello @josdemmers , is it possible to scan all inventory or does it only work when you hover over an item and it's tooltip is shown ? Thank you

Hi,
thank you very much for this useful tool. Really helps and minimizes the time needed to spend in town identifying the 99% of cracp loot.

One question though:

I normally play with the font scale ingame set to small. I noticed that D4C is not working with the 1440p preset, as it requires font scale set to medium.

Would it mean, that I would need to recreate every .png file for affixes, aspects etc so it would work with small font scale?

Wouldn't it be possible for you to handle this internally? You provide an option where the user sets its font scale. There is no need to create new .png files. The ones provided have 100%, which means medium. If the user set another font scale you take the images and scale them down or up, depending if small or large font scale is set ingame.

Cheers,
smoo

@josdemmers First of all nice idea and pretty good job so far! I have found some minor issues and wanted to let you know.

1. When ever you activate stats like damage because you want to track +Damage % you will also get positiv results for stats like "damage with xy". Sure Diablo4Companion only scans for the word "damage" when having the damage option activated but it should scan the other damage stats first which should not be displayed to correctly display those affixes that the user has activated.
2. The same problem occurs with some "damage reduction" modifiers and also the "movement speed" affixes on boots (where "movement speed for" gets true while only "movement speed" is checked.

The scanning appears to be only happening to part of the display or something else is wrong? i have the resolution set to 1080 with text at medium, i tried in windowed and windowed fullscreen, it will show the overlay for all the items equipped in the slots-helm,armor,gloves,pants,boots,weapon.

then the inventory slots only the first row slots get scanned (minus last 2 all the way to right). if i put an item in the first upper left slot it shows the overlay, then i move that item to the next slot over, it shows the overlay still. but move it to the last slot and the overlay no longer will show.
same happens if i move the item to the middle row or bottom in the inventory.

any idea what could be happening?

EDIT: oh i also tried messing with resolution scaling and messing with windows scalling even though windows scalling should have no affect on games.

Is it possible to help you with coding?

When hovering over the next item the dots from the previous item are still there until the new dots for the currently hovered item appear.

Also is it possible to make the recognition a lot faster? I thought about creating multiple threads for scanning the items - and also keeping the affixes from the images in memory so they don't have to be loaded every time. Or why is it actually taking so long until the dots appear? Is the image recognition so slow?

I think it would be great to have an option to only scan items with Item Power of 800 or greater. So if an item is less than 800 Item Power then don't do scan for any affixes etc

Can other languages ​​be recognized?

Is there a file where one can configure which affixes can be selected? - Would be cool to do so, because some of the affixes seem to be missing.

Is there a possibility to add a toggle to not have mappings.json overwritten when updating the images. Mostly to stop situations such as #56 where affixes get completely swapped by mistake and that sort of thing.

Hello,

I actively use your program and am deeply impressed. However, there are one or the other error and I hope that there will be a solution for it in the future.

1. You can't add specific affixes to the bow symbol because the program doesn't recognize it.
   

2. I then changed the totem category to Crossbow so that I could use specific affixes for it.
   

3. I hope there will be a solution for this and I wanted to ask if it is possible to let the program say that it is only allowed to identify unique images. As in the example, I only put Damage Reduction in, but everything that has Damage Reduction in its name is then also recognized by the program, which you don't always want... There should be a clear image recognition so that there is a difference between "Damage Reduction" and "Damage Reduction from Distant enemies" I've thought so much about how I can trick the program, but it doesn't work.
   

I would be very happy about an answer, thank you very much.

Everything is fine when I sort my backpack with mouse but when browsing with controller, the layout doesn't appear

When launching D4Companion.Updater.exe

Tools makes some wrong



Affixes are all matched but tool show red dots
Idn why,how to fix it

I believe it was in an older version but has since gone missing. Was planning to set it as red to differentiate from base move speed but was unable to locate it.

A zip with images for the earth bear landslide caster druid build from IcyVeins

Earth_Bear_Landslide_Caster_Druid.zip

Example:
Rogue, Helm, " Ranks of Poison Imbuement " its not there ? Did i miss something ?

When selecting "% Movement Speed" it seems to also give a green dot next to "% Movement Speed after killing an elite"

Firstly, I am not an English-speaking user, and my window ratio is relatively unusual (3456x1200), so my issue may not be common for everyone.

When I am using it, only equipped items can be recognized, which is very strange. I don't know where the problem is coming from.

Regarding the recognition of affixes and dot-affixes_X, I have tried cropping the image myself to achieve better recognition results. For users who cannot use the presets, it is not a good experience to replace them one by one. Perhaps you could add a tab in the DEBUG interface for re-capturing existing affixes? For example: 1. Select the affix. 2. Click the replace button, and the program starts monitoring clipboard events. 3. The user manually takes a screenshot. 4. The program pops up a preview and a prompt asking whether to replace it.

These are my user experiences, and I hope they are useful to you. Thank you for sharing your ideas.

I unpacked the latest release, configured it with a profile (item rarity doesn't stick when i select rare), downloaded the 1080p profile and set it. Then in-game i hovered over the button for the overlay. Then i hovered over any item just to see that no overlay is visible. Then i checked the debug tab to see but there wasn't anything either. Tried some different values at the slider to no avail.
Do i have to create a own config or should it work out of the box?