Formating and code action not working as expected (elixir) about null-ls.nvim

[jalberto]

Error executing vim.schedule lua callback: ...packer/start/plenary.nvim/lua/plenary/async_lib/util.lua:176: Oneshot channel can only send once
running generators for method NULL_LS_CODE_ACTION
"apps/vlui/lib/sb/search.ex" 54L, 1511C [w]
received LSP formatting request
running generators for method NULL_LS_FORMATTING
spawning command mix with args:
{ "format", "-" }
error output: nil

[jose-elias-alvarez]

A little bit confused about this one, since LSP formatting won't show up under code actions (both for actual LSPs and null-ls). However, it should work when you run vim.lsp.buf.formatting() and select null-ls, so something else is going on. To verify, do you have mix available on your $PATH, and does mix format work as expected from the command line?

I just tried it out on an Elixir file from a sample repo and it seems to work fine, so it could be a config issue. Could you post your full null-ls config?

[arjuns500]

I also have the issue.

I can confirm that running :lua vim.lsp.buf.formatting() in the menu does not format. However, using the default language server which has formatting capabilities, the formatting works.

Running the formatter from the path also works, and formats the file correctly.

Configuration: https://github.com/systemctl603/neovim-config

[jose-elias-alvarez]

@systemctl603 Can you post your debug output? Your config seems fine. Also, can you verify that you see null-ls when you run :LspInfo?

[arjuns500]

Debug output

running generators for method NULL_LS_DIAGNOSTICS
running generators for method NULL_LS_DIAGNOSTICS
running generators for method NULL_LS_DIAGNOSTICS
received LSP formatting request
running generators for method NULL_LS_FORMATTING
spawning command prettier with args:
{ "--stdin-filepath", "$FILENAME" }
error output: nil
output: nil
received edits from generators
{}
successfully applied edits

Results of :LspInfo

[jose-elias-alvarez]

Thanks! I see that you're on Windows, and so I suspect this is related to #95. @jalberto Are you also on Windows?

As I said there, I'm going to see if I can get some help on this from the Neovim Matrix chat, but since I don't know anything about Windows and don't have access to a Windows setup to test this on, there's not much I can do without a Windows user who's familiar with uv.spawn.

[jose-elias-alvarez]

Not sure if this is the same issue that was closed by 07fd5ab, but could you try updating to the latest version and see if it makes a difference?

[jalberto]

Sorry for the late reply.
I am on Linux and if I run the forma tin CLI it works as expected.
Also, I noticed something, 1st time I select null-ls do nothing, but if I repeat the command and select again null-ls, then it works as expected.

[jose-elias-alvarez]

Thanks for confirming. I'm testing this out a bit more and I can see that mix format has some unusual behavior. Could you quickly verify whether another formatter (e.g. Prettier) is working as expected?

[jalberto]

Yes, prettier seems to be working as expected (at least on html)

…

On Mon, 9 Aug 2021 at 12:01, Jose Alvarez ***@***.***> wrote: Thanks for confirming. I'm testing this out a bit more and I can see that mix format has some unusual behavior. Could you quickly verify whether another formatter (e.g. Prettier) is working as expected? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#84 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYMVZOA3ANAMV2XN7ZKFLT36Q43ANCNFSM5BTU5ENQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[jose-elias-alvarez]

Got it. I can see that mix format has a weird interaction with the way null-ls spawns processes and gets their output, and I have to determine whether it's a bug in my implementation, Neovim / luv, or the formatter itself, so this might take a bit.

[jose-elias-alvarez]

@jalberto When you get a chance, could you please try this branch of the plugin and see if mix works for you?

[jalberto]

`✗ Failed to update jose-elias-alvarez/null-ls.nvim/fix-spawn-stdout` Seem Packer doesn't like that branch

…

On Mon, 9 Aug 2021 at 17:55, Jose Alvarez ***@***.***> wrote: @jalberto <https://github.com/jalberto> When you get a chance, could you please try this branch <https://github.com/jose-elias-alvarez/null-ls.nvim/tree/fix-spawn-stdout> of the plugin and see if mix works for you? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#84 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYMV2YTFEUEZIY4GART7DT372KVANCNFSM5BTU5ENQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[jose-elias-alvarez]

For Packer I think you need to set the branch like this:

use({ "jose-elias-alvarez/null-ls.nvim", branch = "fix-spawn-stdout" })

You might also need to comment out the plugin, uninstall it, and then re-install it to get the new branch to work (though I think Packer might have fixed this).

[jalberto]

Removing/adding did the trick! It seems to be working now at 1st trigger Thanks!

…

On Mon, 9 Aug 2021 at 18:13, Jose Alvarez ***@***.***> wrote: For Packer I think you need to set the branch like this: use({ "jose-elias-alvarez/null-ls.nvim/", branch = "fix-spawn-stdout" }) You might also need to comment out the plugin, uninstall it, and then re-install it to get the new branch to work (though I think Packer might have fixed this). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#84 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYMV2EA2DO2BRMJNUEUY3T375CVANCNFSM5BTU5ENQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[jose-elias-alvarez]

Great! I need to review and merge another PR first, but once I do, I'll merge the fix-spawn-stdout branch and close this issue.

[jalberto]

Thanks for the fixing and your time :)

…

On Mon, 9 Aug 2021 at 18:34, Jose Alvarez ***@***.***> wrote: Great! I need to review and merge another PR first, but once I do, I'll merge the fix-spawn-stdout branch and close this issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#84 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYMV4YI7YN52J7DJF66CLT377QDANCNFSM5BTU5ENQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[jose-elias-alvarez]

Fix merged in b4a11d8.