josephlivengood / conquerjs Goto Github PK

• Setup dependencies
• .babelrc
• webpack.config.js
• NPM scripts to build and watch files in dev
• MULTIPLE ENTRY POINTS (webpack)
• EMBEDDED STYLESHEETS ? (webpack)
• Proposed packaging/structure:

Boilerplate/
  app/
  client/
    app/
      commonComponents/
        */
          index.jsx
      scenes/
        */
          components/
            */
              index.jsx
          style.css
          index.jsx
  public/
    views/
      *.pug
    js/
      *.entry.js
    style/
      *.css

Doesnt reflect React structure impl.

• Fix readme file structure
• Simplify sections and link to other .md
• Create a file just to document usage of dependencies and add ons
• Update contributing.md for suggesting features and how to set up dev enviro and guidelines for PRs
• Update installation to reflect needing to build-react before you can start the server

It may be time to get this implemented in a beta branch to test if it'll be worth it in the project. (Or to provide a base with which we can make a tutorial to impli on the boilerplate if the end-user wishes)

We need to determine what kind of data is sent back and in what circumstances can it differ (such as for some users having an array of photos versus another have a single single in the field)

Also, looks like Google doesn't return email in the current scope used and GitHub can have email set to private and not return.

• Retrieve email of user from Google without req email permissions to view messages/settings/ect
• Handle absent photo fields with a basic ||
• Handle private email from GitHub

Create content of Readme with:

• - Info on project structure and methodology
• - How to install
• - How to set up (including auth secrets)
• - How to build
• - How to run tests
• - How to make tests
• - How to run

Optional

• - How to contribute (until we split into its own file)
• - How to host, maintain, and monitor performance

Public is now deployed.

• We need the landing page to have some general info and features, as well as a link to this repo!

Issue #25 's video would be useful to put on this page!

• Determine best license for repository.

MIT?

Currently 24 codacy code style issues.

• Missing semicolons
• Console.logs (we should remove that linting most likely)
• Strategies use ConstructorCase in place of camelCase right now
• Expected property shorthand. (object-shorthand) when using res.render

Commit said changes to branch fix/codacy-code-style

https://www.codacy.com/app/JosephLivengood/Boilerplate/dashboard?bid=4115858

Handle unexpected auth return data.

Both need usage explained or links since its in the project now.

• font-awesome

• bootstrap-social

We need a way to either initiate the database connection for NPM test commands or to disable the attempt to so we can purely test routes ect. Most likely .ENV variable to set test/production or allow test runner to start database connection and have multiple NPM test commands to allow user to choose if they want to use DB or not.

Need to create a home page for the boilerplate with a simple good looking login (as modular as the server to be easily expanded)

Possible dependencies:

• Bootstrap-social (lightweight stylesheet to format social login buttons for most all services, easy to create and uniform enough to make dynamically based on a single list of just the social strat names)

Documentation of current impl and how to expend is NEEDED asap

• Current structure / why
• How to adjust for a single page app
• How to add new entry points in webpack.config.js / why
• Look into getting feedback and potentially impl optional react router in a separate version/tag/branch POSTPONED

MOVE THIS TO THE AUTH CALLBACK, DUH!

• 60 second video proving that's all it takes to completely impl a new auth strat from the back to the front react view with no prior coding needed.

Fairly positive I can get this done at a casual pace in 60 seconds

1. npm install twitter-passport
2. Add strat file (basically c+p from all others with with 'twitter' instead of 'github' used
3. Add strat to strat reducer
4. Add 'twitter' to react authlist (then based on that single entry/word alone, the button and everything is dynamically generated)

• Document usage in this project

Currently this is created in both impl of strategies. We need to create 1 common config that ALL impl will use to prevent mistakes when we add more strategies and also to make changing the initial user document MUCH easier (and avoid further mistakes).

id: profile.id,
name: profile.displayName || 'John Doe',
photo: profile.photos[0].value || '/resources/profile/default.jpg',
email: profile.emails[0].value || '',
created_on: new Date(),
provider: profile.provider || '',
role: 'user'

Also, no mongoose.

This wouldn't leave a good impression on that minority of users or new to developing and not realizing the power of Chrome 🥇

Possibilities?