joshooaj / posh-xprotectmobile Goto Github PK

Hi Josh,

I am using the Lets Encrypt certificates also for the other servers and for the streaming media certificate. The renewal script block in the SetupLetsEncrypt.ps1 renews the certificate only for the mobile server. Would it be possible to modify this line in the script so it will update all certificates in the VMS:

$newCert | Set-XProtectCertificate -VmsComponent MobileServer -Force -UserName $ServiceAccountName -RemoveOldCert -ServerConfiguratorPath $ServerConfiguratorPath -ErrorAction Stop

Another feature request that would be really great to have: I used the BackConnectionHostnames registry script to use the certificate for the other servers. Can you include (if possible) the steps you described in this link to the LetsEncrypt fully automated script:
https://supportcommunity.milestonesys.com/s/question/0D53X0000A7RkgPSQS/securing-existing-xprotect-2022r1-installation?language=en_US

So this will renew the certificate for all the servers and the streaming media.
Thanks!

Is your feature request related to a problem? Please describe.
Hi! I already have DDNS set up and working and have no need for DynDNS.

Describe the solution you'd like
Would it be possible to add a configuration option for running the certificate automation without needing to using DynDNS or needing to specify DynDNS credentials? As far as I see, the credentials are passed to New-PACertificate with the DnsPlugin flag. If -DnsPlugin isn't specified Posh-ACME will assume Manual-mode instead

Describe alternatives you've considered
For my use case I probably could edit the module code before installing the modules but I believe that this feature would benefit this project. I also could try to make a pull request but I'm very new to scripting in PowerShell.

Windows 10 Pro (21H2)

Start-LECertSetupUsingDynu
Domain name: ***
E-mail address for renewal notifications: ***
Dynu Client ID: ***
Dynu Secret: ***
Setting Execution Policy to RemoteSigned
Testing certificate request against staging server
New-PACertificate : Cannot bind parameter because parameter 'ErrorAction' is specified more than once. To provide
multiple values to parameters that can accept multiple values, use the array syntax. For example, "-parameter
value1,value2,value3".
At C:\Program Files\WindowsPowerShell\Modules\Posh-XProtectMobile\0.6\Public\Install-CertificateAutomation.ps1:39
char:17
+ ... New-PACertificate -force $domain -AcceptTOS -Contact $con ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : InvalidArgument: (:) [New-PACertificate], ParameterBindingException
+ FullyQualifiedErrorId : ParameterAlreadyBound,New-PACertificate

Workaround:
Remove the "-ErrorAction Stop" from the two calls to New-PACertificate in C:\Program Files\WindowsPowerShell\Modules\Posh-XProtectMobile\0.6\Public\Install-CertificateAutomation.ps1