joshualat / ohm-zset Goto Github PK

You may want to note that gem 'ohm-zset', :require => 'ohm-zset' is required in Gemfile to hint Bundler correctly.

Also, I think

gem.add_dependency 'uuidtools'
gem.add_dependency 'sourcify'

is needed in the gemspec.

Thanks for the gem.

error: can not load file ohm/set

in Gemfile add below
gem "ohm-zset", "> 0.5"
gem "uuidtools", "> 2.1.3"
gem "sourcify", "~> 0.5.0"

Modern versions of ruby show these warnings:
ohm-zset-0.5/lib/ohm-zset.rb:151: warning: found = in conditional, should be ==
ohm-zset-0.5/lib/ohm-zset.rb:171: warning: found = in conditional, should be ==
ohm-zset-0.5/lib/ohm-zset.rb:298: warning: found = in conditional, should be ==
ohm-zset-0.5/lib/ohm-zset.rb:309: warning: found = in conditional, should be ==
ohm-zset-0.5/lib/ohm-zset.rb:327: warning: found = in conditional, should be ==

At those spots in the code

weights = [1.0] * sets.length if weights = []

which overwrites weights always, should instead be

weights = [1.0] * sets.length if weights == []