GithubHelp home page GithubHelp logo

Comments (9)

Canopix avatar Canopix commented on August 26, 2024

I'm trying to reproduce this bug but I am not able to see it on Windows.
It's already fixed?

from guppy.

AWolf81 avatar AWolf81 commented on August 26, 2024

@Canopix This issue is still present. The component in question is Titlebar. You need at least two projects in Guppy and then reduce the screen height until the first item is close to the top edge of the window.

In the screenshot below I've added a border to the titlebar to make it visible:
grafik

Not sure why it is there & invisible. There is a comment in the component like following:

The title bar in this app is invisible, and yet it still needs to be defined,
as it constitutes the "draggable" area of the window.

But I don't know what draggable area means. Is this a Mac thing? On Window this is not needed or am I missing something? @joshwcomeau

The Titlebar component is used in App.js I've commented it and I haven't noticed any difference beside that the sidebar buttons are clickable.

from guppy.

Canopix avatar Canopix commented on August 26, 2024

Thanks, @AWolf81
I tried reducing the screen height from the top and from the bottom, and this is the result:
h0Jx32W

from guppy.

AWolf81 avatar AWolf81 commented on August 26, 2024

@Canopix Then scroll the sidebar (mousewheel or scrollbar) so that the icon is close to the top menubar - like in my screenshot.
After hovering you should notice that the mouse icon is not changing and dragging is not possible.

from guppy.

Haroenv avatar Haroenv commented on August 26, 2024

I think the titlebar should be only present on platforms without window chrome (i.e. only Mac)

from guppy.

AWolf81 avatar AWolf81 commented on August 26, 2024

@Haroenv thanks, I think now I understand why it is there. It is adding the three dots on Mac as window bar, right?
So adding a conditional render will fix this issue. By changing line App.js:l39 to {isMac && <Titlebar />} it should be fixed.
isMac can be imported from platform.service

@Canopix if you like you can add this and check if it's fixing the issue? Mac os testing will be done during PR.

from guppy.

Haroenv avatar Haroenv commented on August 26, 2024

the three dots are native I think, but the title bar component is there to make sure you can drag the window all along the top

from guppy.

Canopix avatar Canopix commented on August 26, 2024

@AWolf81 Issue fixed, I did that you mentioned about it.
There is a new PR now 😄

from guppy.

melanieseltzer avatar melanieseltzer commented on August 26, 2024

Closed in #383

from guppy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.