jpgothro / portfolio

Portfolio of projects I built

Portfolio

Portfolio of projects I built

Scaffolding for the Repository

• Creating the first versions of files
• Using Normalize.css version 4.1.1 file from https://necolas.github.io/normalize.css/

Structural revisions

• Revised the Stylesheet into SMACSS styles.
• Modified the main page to include separate project entries, using details/summary
• Create JS file for handling constructing Project entries.
• Created a temporary input data file (JS) to populate the project section.

Big Issue RESOLVED! By Erica Hendricks

• Thanks to Erica for getting me to use CSS to style the project state when details are shown.

Refactoring (Class 9)

• Added a date field to project data for display and use in stats.
• Modified Handlebars template to allow for date data.
• Using the array method, reduce, when building stats.
• Eliminated CDNs and all vendor code is in vendor folder.
• Added more comments in code explaining functionality.
• All encapsulated by IIFE's.

portfolio's Issues

Scripts

Thank you for commenting out your code. Makes it easy to follow. Your code looks really good!

Add icons

As per our discussion, pull in the icons from icomoon that you would like to use.

Color scheme

From issue #23

• Colors: you may want to think about group of colors that go together (color pairs), instead of picking a couple colors independently. Try: https://www.materialpalette.com/

Footer

Ideally the footer (copyright, project completion information) should be stuck to the bottom of the page.

Implement nav items for mobile

Nav items are not appearing for mobile devices, neither icons nor menu. Fix it!

RWD

When on a small screen, labels for links at the top of the page are spilling over outside of their containers.

handleProjectDetails CSS

Try using CSS to solve this. I'm unclear on why the javascript is needed.
It seems more like a styling issue.

More CSS - spacing

• I'd like to see more space above and below the header text that reads "Portfolio of Projects"
  -I'd like to see less space below the text that reads "Projects by John", and maybe also more space above it so that it visually hangs together with the list of projects.
  -I'd like the list of projects (title, and the triangle) to be bigger; anything you can do to make it obvious that it's clickable may also be good.
  -Colors: you may want to think about group of colors that go together (color pairs), instead of picking a couple colors independently. Try: https://www.materialpalette.com/

Styling details/summary

Figure out whether the details/summary elements can be styled based on whether it's open or not.

JSON

Your JSON object looks awesome!

Confirm color scheme

Is the mobile color scheme workable? Change if not.

Add explanatory comments

Your code is relatively straight forward to follow. However, you might consider adding comments to your code to indicate what each function is doing and the the source of the arguments/parameters. (e.g. they're coming from the project array vs. a Project object).

It might be useful to you in the future to explain why you made certain decisions as well.

CSS issues

line 3 of module.css reads: "/* begin with mobile formatting first */". You may want to delete this.

Where is the favicon for codefellows coming from? You may want to track it down and replace it with your personal favicon.

Consider using images/screenshots of your projects on your details view of your projects page.