jpippy / nvidia-widgets Goto Github PK

What steps will reproduce the problem?
1. calling void UIContext::keyboard(unsigned char k, int x, int y) more than 32 
times without redrawing causes the problem

    m_keyBuffer[m_nbKeys] = k;
    m_nbKeys++;

BugFix: 

    if(m_nbKeys>30) return;
    m_keyBuffer[m_nbKeys] = k;
    m_nbKeys++;

What steps will reproduce the problem?
1. Try to compile this library. 

What is the expected output? What do you see instead?

It should compile but it doesn't... 

The error is in the 3rd line of the this function void 
GLUIPainter::drawTextureView()

This line doesn't compile. Because GLunit is 32-bit but texID is a const void* 
which is 64-bit on a  
64-bit machine. And the compiler will report an error here. 

GLuint lTexID = reinterpret_cast<GLuint> ( texID );


What version of the product are you using? On what operating system?
Snow Leopard

Please provide any additional information below.

N/A

What steps will reproduce the problem?
run the example

What is the expected output? What do you see instead?
it redraws all the time. This drains laptop battery life.

What version of the product are you using? On what operating system?
osx. Latest svn version.

Please provide any additional information below.
Maybe one could implement a version that is only redrawing when the mouse 
button is pressed. Of 
course hovering effects are not possible with this, or one would have to work 
with a timer.

Provide our own font rendering code instead of relying on GLUT.

(excuse my fuzzy memory, i should have reported earlier, and that code is a
tad too baroque for what it does)

In doLineEdit at line 757 and 768, memmoves are incorrectly guarded and if
m_focusCaretPos > textLength bad karma ensues.

kubuntu 11.10
32 bit
nvidia card 220gt
on make get the following error:
make
[ 25%] Building CXX object 
src/nvwidgets/CMakeFiles/nvwidgets.dir/nvWidgets.cpp.o
[ 50%] Building CXX object 
src/nvwidgets/CMakeFiles/nvwidgets.dir/nvGLWidgets.cpp.o                        


In file included from 
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/nvGLWidgets.cpp:26:0:       


/home/adispi/Downloads/nvidia-widgets/src/nvglutils/nvShaderUtils.h: In 
function ‘GLuint nv::LinkGLSLProgram(GLuint, GLuint)’:
/home/adispi/Downloads/nvidia-widgets/src/nvglutils/nvShaderUtils.h:106:19: 
warning: format not a string literal and no format arguments [-Wformat-security]
In file included from 
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/nvGLWidgets.cpp:26:0:
/home/adispi/Downloads/nvidia-widgets/src/nvglutils/nvShaderUtils.h: In 
function ‘GLuint nv::LinkGLSLProgram(GLuint, GLuint, GLint, GLint, GLint, 
GLuint)’:
/home/adispi/Downloads/nvidia-widgets/src/nvglutils/nvShaderUtils.h:143:19: 
warning: format not a string literal and no format arguments [-Wformat-security]
[ 75%] Building CXX object 
src/nvwidgets/CMakeFiles/nvwidgets.dir/nvGlutWidgets.cpp.o
Linking CXX shared library libnvwidgets.so                                      


[ 75%] Built target nvwidgets                                                   


[100%] Building CXX object 
src/nvwidgets/examples/CMakeFiles/example.dir/example.cpp.o
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp: In 
function ‘void doUI()’:                                                     


/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:139:54:
 warning: format ‘%f’ expects argument of type ‘double’, but argument 3 
has type ‘int’ [-Wformat]
Linking CXX executable example
CMakeFiles/example.dir/example.cpp.o: In function `display()':                  


/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:43: 
undefined reference to 
`glutSwapBuffers'
CMakeFiles/example.dir/example.cpp.o: In function `idle':
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:48: 
undefined reference to `glutPostRedisplay'
CMakeFiles/example.dir/example.cpp.o: In function `main':
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:155: 
undefined reference to `glutInit'
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:156: 
undefined reference to `glutInitWindowSize'
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:157: 
undefined reference to `glutInitDisplayMode'
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:158: 
undefined reference to `glutCreateWindow'
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:175: 
undefined reference to `glutDisplayFunc'
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:176: 
undefined reference to `glutMouseFunc'
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:177: 
undefined reference to `glutMotionFunc'
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:178: 
undefined reference to `glutPassiveMotionFunc'
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:179: 
undefined reference to `glutIdleFunc'
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:180: 
undefined reference to `glutKeyboardFunc'
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:181: 
undefined reference to `glutSpecialFunc'
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:182: 
undefined reference to `glutReshapeFunc'
/home/adispi/Downloads/nvidia-widgets/src/nvwidgets/examples/example.cpp:184: 
undefined reference to `glutMainLoop'
../libnvwidgets.so: undefined reference to `glutBitmapCharacter'
../libnvwidgets.so: undefined reference to `glutGetModifiers'
../libnvwidgets.so: undefined reference to `glutBitmapWidth'
../libnvwidgets.so: undefined reference to `glutBitmapHelvetica12'
collect2: ld returned 1 exit status
make[3]: *** [src/nvwidgets/examples/example] Error 1
make[2]: *** [src/nvwidgets/examples/CMakeFiles/example.dir/all] Error 2
make[1]: *** [all] Error 2
make: *** [all] Error 2

What steps will reproduce the problem?
1. Downloaded latest SVN on OSX leopard
2. Configure and Make
3. execute 'example' from build/src/nvwidgets/examples/example

What is the expected output? What do you see instead?
The fellow should pop up a GL window and show stuff happening. The console
reports back to me "GLEW initialization failed"

What version of the product are you using? On what operating system?
Latest SVN. OSX 10.5 leopard.

Please provide any additional information below.
Is it just me?

Because
void UIContext::endPanel()
{
    endFrame();
    endGroup();
}
assumes both are on stack but UIContext::beginPanel does
        if (isUnfold && *isUnfold)
        {
            beginFrame( flags, Rect(0, 0, r.w, r.h) ); 
            return true;
        }
        else
        {
            endGroup();
            return false;
        }
said stack is smashed.
My simple solution was to define GroupFlags_InternalSkipFrame = 0x10000, 
        if (isUnfold && *isUnfold) {
            beginFrame(flags, Rect(0, 0, r.w, r.h));
            return true;
        }
        else {
            beginFrame(flags | GroupFlags_InternalSkipFrame, Rect(0, 0, 0, 0));
            return false;
        }
then have that flag propagated through UIContext::beginGroup and finally
void UIContext::endFrame()
{
    endGroup();
    if (!(m_groupStack[m_groupIndex + 1].flags &
GroupFlags_InternalSkipFrame)) 
        m_painter->drawFrame( m_groupStack[m_groupIndex + 1].bounds,
m_groupStack[m_groupIndex + 1].margin, 0);
}
so that no residual frame would get drawn when panel is collapsed.

This is an enhancement/feature request.

Since this is an open library, I'd like the ability to extend the widgets
of the UIContext class in nvwidgets.h without having to necessarily rewrite
some of the current private functions. That is, change some of the private
functions to be protected:

static bool UIContext::overlap(const Rect & rect, const Point & p);
bool UIContext::hasFocus(const Rect & rect);
bool UIContext::isHover(const Rect & rect);

Just so that if a user of the library only wants to add a couple widgets or
recombine them... rewriting the mouse calls and duplicating mouse data
wouldn't be necessary. You'd have to move some of the mouse data from
private to protected as well. 

Other functions are more intricately laced with the class and
understandably should be rewritten in the case that an inherited context is
being used...

Also, I understand that if I start adding to the classes, I have to be
ready for these functions to totally be changed or removed, and possibly it
will hurt development if someone wants to change them and a lot of people
use an older class interface. Soooooo..... this is just a request. See what
you guys think about it.


As an example, I want to add tablet support to the library... and then make
a couple redo's of the widgets to make them support pressure and tilt
changes. Perhaps that gives you an idea of what would be done... and what
might need to be added.

What steps will reproduce the problem?
1. Enter a capitalized letter in a LineEdit widget (pushing Shift key)  

What is the expected output? What do you see instead?
Crash. seems due to wrong m_focusCaretPos value

What version of the product are you using? On what operating system?
1.0.0

Please provide any additional information below.

nvWidgets.dll should not depend on GLEW.