jpotts18 / android-mvp Goto Github PK

I have implemented your example and tried to integrate dagger2 example from https://github.com/codepath/android_guides/wiki/Dependency-Injection-with-Dagger-2 .

However, I couldn't find a way to get "netComponent", which was build on Application class, from interactor class.
My main intention is to use retrofit object in "interactor" class. Should I pass it as a parameter or is there a more elegant way?

DaggerLoginPresenterComponent class is missing in https://github.com/jpotts18/android-mvp/tree/2-synchronous-login-mvp/app/src/main/java/io/jpotts18/android_mvp/domain/login

Awesome video tutorial btw, if you have any more elaborate tutorial on MVP, please suggest.

hi, I watched your youtube video and I really liked it so I try to clone the project you made available. I just wanted to let you know that for cloning the instruction you wrote gave me an error

Cloning into 'android-mvp'...
Warning: Permanently added the RSA host key for IP address '19x.xx.xxx.129' to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I used instead
git clone https://github.com/jpotts18/android-mvp

and it worked.

Thanks for nice brief on MVP. This has been a topic to discuss for last 2 years.

Well, Retrofit1.9 has lot of sphagetti code, So I have made pull#16 request for upgradation to Retrofit2.0.2 which is stable.
Also added diagramatic representation https://github.com/jpotts18/android-mvp/wiki/Diagramatic-representation

Thanks,
Raju

While making changes I found incorrect edittext ids.. so I have fixed that as in:
0c75ef4

@jpotts18
Thanks for nice brief on MVP. This has been a topic to discuss for last 2 years.

Well, Project has Retrofit1.9 related sphagetti code, So I have made pull#18 for upgradation Retrofit to v2.0.2 which is stable. Due to this, there will lot of code changes are required which I have covered and tested. Everything works fine.
I've also added diagram in Wiki to simplify understanding: https://github.com/jpotts18/android-mvp/wiki/Diagramatic-representation
Just thought I'd raise a quick question to get your thoughts.

Thanks,

In the 2-synchronous-login-mvp branch, you forgot to include android-apt plugin as a dependency.

For anyone facing this issue, just add
classpath 'com.neenbedankt.gradle.plugins:android-apt:1.8' to your app's build.gradle - not in the module dependencies.

Recently I started reading a lot about MVP and I want to get into practicing my projects with it.

However I am not able to correctly understand where should Rx + Retrofit code go? I think it should be in Model Layer via Interactors but still can you help me understand?

Also what happens with the RX callback? the onNext(), onCompleted() and onFailure() passes data back to Presenter or do we implement listeners? Also should we decouple Rx callbacks further?

While making changes I found missing retrofit dependency.. so I fixed as in :
github.com//pull/18/commits/9d131ce4c7b776ffe737bab2c61d21f539610ddb