jptaranto / typey Goto Github PK

Maybe I'm doing it wrong, but my typefaces are ignoring font-style. I tried like this:

$typefaces: (
    menu: (
        font-family: $helvetica,
        weight: bold,
        case: uppercase,
        font-style: italic,
    ),
);

Just in case, I tried with style: italic; too. Either way, the definition isn't appearing in CSS. Is a typeface supposed to accept font-styles?

I'm using Typey 1.0.3.

I would like to make use of Typey in a CSS framework using NPM. While the framework does not modify Typey, I cannot include a minified version *.css because of license restrictions (the CSS framework is MIT licensed while Typey is GPLv2).

Is there a particular reason you chose the GPLv2 license for Typey?

Sometimes we must have different font-size for mobile and desktop resolutions. Will be cool to include breakpoints feature.

Hi,

I would to replace Compass Vertical Rhythms by Typey but:

• Do I install libsass 3.3.0 / ruby-sass 3.3.0 ? Because I already have gulp-sass (with the node-sass dependency) and it seem not to work
  What I did:
  in my application.scss >> @import 'typey';
  in my gulpfile.js >>
  basePaths.node_modules + 'typey/stylesheets'
  and

 includePaths: [].concat(
                        assetsPath.gems
                        //assetsPath.node_modules
                        ),

• How to test if typey work ?
• I don't find how to override the default settings. Do I need to create a scss file in my project to do so ?

Thanks

There hasn't been any changes to the code base in a while and I know this code is being used in production, so I'd recommend tagging a 1.0.0 release. Congrats!

But, please merge #7 first. :-)

Currently I have my font size/line-height set at 16/24 and my method set to 'ratio'. With this set-up I can use '@include margin-bottom(1);' and it will output the margin-bottom to 24px/1.5rem (as expected). However, when I hit a higher breakpoint and increase my font size to 18 at 1.5 (18/27) the margin-bottom remains at 24px/1.5rem instead of matching the new line-height.

The Rem is correct but the pixel fallback is still 24px. Am I doing something wrong? or is this the expected outcome?

Just a suggestion. Consider adding 'color', 'style' and 'letter-spacing' as accepted properties in the '$typestyles' map.