jrossignol / contractconfigurator Goto Github PK

There needs to be a utility class for reading in orbital information. This would be used by both the Kerbal spawner and Vessel spawner code to determine where they go. This would also be needed by the Fine Print integration code for creating waypoints.

Well ok, I'm not sure if the targetBody is still given. Errors are displayed in log while starting ksp, but contracts are generated in game.

Shouldn't be spamming CheckVessel calls for every OnUpdate.

We missed to add defaults :D

New parameter for specifying orbital details:

• OrbitalInclination
• OrbitalEccentricity
• OrbitalApoapsis
• OrbitalPeriapsis

Like HasCrew, but counts empty seats.

Ability to spawn a Vessel, similar concept to Kerbal spawning, but the Vessel needs to come from a .craft file.

Add a weight to the contract type to use in the selection process.

Add new requirements for having min/max values for funds, science and reputation.

Need to do some fixing up of VesselParameterGroup to handle more than just a simple parent-child relationship.

Build a system for using expressions in config node values.

Once orbit kerbals/vessels are working, need to support spawning them on the surface.

Need a system in which you can make VesselParameterGroup be attached to a very specific vessel. This may also be implemented as a child parameter.

Alt-F9 brings up the quickload menu. Bad choice for the debug hotkey. Rebind to either F11 or F12.

Design a rocket with < 4t weight should be valid.

The ability to create configuration that disables contract types - it looks like the list of valid contract types is public in the Squad code, so I should be able to modify it (just need to figure out the right time to do it).

If needed, should enhance the persistent data store to allow storing config nodes.

Launchclamps should be a hardcoded exception for HasPartModule: ModuleGenerator.

LaunchPad, VAB Main Building don't work with there displayed names.
But I allready fixed it! :)

Need to load CONTRACT_TYPE nodes in possible different places:

• Main menu
• load of game
• a hot key

Let DuoDex know if there are any requested additions for CoherentContracts.

Parameters for specifying the vessel's weight.

Just got the idea. Don't know this could work. Would be nice!

To fully support waypoints, expecting to need:

• ContractBehaviour for generating waypoint(s)
• ContractParameter for being with x distance of a waypoint

This could be an easy way to do remote tech parameters? Might be too kludgey.

Need a behaviour which can change the ownership of a vessel (typically the vessel that has completed the contract) to something different. This can be used to allow a satellite launch contract where the player is no longer allowed to do anything with the satellite after launch (because the agency now owns it). It's also necessary to prevent the player from messing things up if you want to do a follow up contract on that same vessel.

Should work like this:

// Example - orbit the Mun for 10 days
PARAMETER
{
    // Parameter is completed when all child parameters have been completed for the specified duration
    type=Duration
    duration=10 days

    PARAMETER
    {
        type=ReachSituation
        situation=Orbit
        disableOnStateChange=false
    }
    PARAMETER
    {
        type=ReachDestination
        targetBody=Mun
        disableOnStateChange=false
    }
}

When 0.90 comes out, will need a new ContractRequirement for having a facility upgrades/not upgraded to a certain level (or range, assuming there's a numeric value).

hasPartParameter does have problems loading specific parts (found one: SCANsat_Scanner from SCANsat) logs "[Error]: ContractConfigurator: 'SCANsat_Scanner' is not a valid Part." in ConfigNodeUtil.ParsePart

• Definitly know that part is later loaded correctly (shows up in techtree and is useable)
• SCANsat_Scanner is the name not the title, checked it often enough.

No clue why this isn't loaded, got desperate enough to try leaving out the underscore

Parameter that starts a countdown timer.... when it hits zero, the contract fails.

The ContractConfigurator.version file isn't valid JSON (there's some commas missing). KSP-AVC doesn't seem to mind, but CKAN/NetKAN is a little bit more strict.

I don't seem to see any exception contracts, need to look into if this is an issue.

Not sure how to phrase this: After contract 'Annual Review- Year 1' is completed, 'Annual Review- Year 2' has to wait a year before becoming available.

Add a field to specify a "cooldown" duration for the ContractComplete requirement.

Add integration to RemoteTech:

• Parameter for HasConnection - verifies that a vessel has connectivity back to KSC
• Want to be able to support a contract that involves setting up a network of satelites - need to be able to specify the orbit, but also be able to say that the X satellites are Y degrees apart. Need to think about how this needs to be implemented.
• Requirement to say "has connectivity to <celestial_body> might be interesting if possible.

Need to make sure that minCount <= maxCount. For the case where maxCount = 0, just set minCount = 0.

Make sure everything makes sense, documentation matches code.

Provide wrappers to the Fine Print parameters. Figure out a way to make the dependency conditional (ie. don't break if Fine Print isn't installed and the FP parameters aren't being used).

Orbit specifiers - may need a combination of parameter and behaviour.

When a duration is used, and the previous "winner" for VesselParameterGroup stops meeting its parameter obligations, another winner is selected out of the pool of valid winners. Currently what happens is the first one is picked - rather than the one that is currently closest to meeting the duration bit.

EVA Kerbals can't seem to do waypoints. :(

Add a parameter of the form:

Contract X: Not complete

this will allow for mutually-exclusive contracts.

Some parameters would benefit from the ability to invert, in particular the Reach ones. This would lead to the ability to do things like have Destination: Not Kerbin

Requirement to allow contracts to only be offered withing a given date window. This could be used to have contracts that are only available when a given transfer window is open.

Add support for auto-generating contract description (backstory). Look into exposing parameters to the user (Mindset, etc.), or possibly allow it to be derived from ContractParameters.

Create a new parameter that spawns a Kerbal. This Kerbal should be "inheritable" by child parameters that require a Kerbal (ie. RecoverKerbal, BoardAnyVessel).

Need to do a full requirements pass and make sure some are not rechecked (ie. ReachSpace).

Credit scerion in the changelog for finding it.

I think 0.0 speed is valid. I'm trying to make a contract who needs the player to hover in a place with 0-5m/s maximum speed. Havn't tested if this is working with minSpeed = ~0.0001 or floats will get to exactly zero(ed) in any time.

Same as CompletedContract, but for failures.