Comments (9)
We could add a field to the info.ini?
from bot.
What kind of field? I guess we need to add .mainfile to the API for this feature to work?
from bot.
Maybe something like
checkMainFiles: > 1.2
On Mon, Apr 6, 2015 at 1:58 PM, Dmitriy Akulov [email protected]
wrote:
What kind of field? I guess we need to add .mainfile to the API for this
feature to work?—
Reply to this email directly or view it on GitHub
#32 (comment).
from bot.
Nah, too much work to maintain. I think we need to add it to the API, then your bot could simply parse it and only throw errors when there is no mainfile
override file. What do you think?
from bot.
@megawac Our API now supports this http://api.jsdelivr.com/v1/jsdelivr/libraries?name=imagesloaded
Each version has its own mainfile parameter as well.
from bot.
The main difficulty (besides finding time) is supporting both .mainfile
(#10) and this. For instance if the user changes the mainfile (jsdelivr/jsdelivr#5927), its difficult to determine if that affects a folder with a .mainfile
. One possible workaround would be to have the API include a flag for each version if a .mainfile
is set
from bot.
@megawac Can we include this feature into v2? Can you make sure we dont forget this?
from bot.
This can also be added to v1. Either way, it should be a simple fix
On Fri, Jul 17, 2015 at 4:16 AM, Dmitriy Akulov [email protected]
wrote:
@megawac https://github.com/megawac Can we include this feature into
v2? Can you make sure we dont forget this?—
Reply to this email directly or view it on GitHub
#32 (comment).
from bot.
Lets add it only to v2, there has to be motivation to switch to v2.
from bot.
Related Issues (20)
- Unable to update package because of case sensitivity? HOT 1
- Bot failes very often HOT 7
- Bot failing with SSL error HOT 1
- UTF-8 encoded files seems be interpreted as binary HOT 12
- Failed to warn about deleted files HOT 2
- Merge a pull request with squash option HOT 3
- Delete branch whenever a pull request is closed/merged
- Setup jsdelvr-bot for testing proposes on Heroku? HOT 4
- info.ini error where info.ini is present (again) HOT 2
- .html (on theme/github.html) seems odd to want to host
- info.ini error where info.ini is present (once again)
- Bot will sometime attempt to merge PRs too quickly HOT 3
- Folder structure changes reported incorrectly HOT 2
- Add an option to request re-check HOT 4
- Allow non-lowercase chars HOT 1
- bot says files have been modified HOT 1
- bot is not happy with minification
- Can't write the author's name properly due to non-ascii characters rule
- How to retain subdir within basePath
- Structure check way to strict HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bot.