jshanley / motivejs Goto Github PK

Update the Chord constructor so that it returns the new motive.noteCollection type.

The data structures for the fifths and intervals primitives have a lot of overlap, and most of the time they are used in combination rather than separately. It might make more sense to combine them into a single model.

Right now, for notes that do not have an octave assigned Note.type === 'note' and for those that do have an octave assigned Note.type === 'pitch'.

It would make more sense to separate them into two different classes.

A NoteCollection wraps an array of notes, so it should give some useful shortcut methods for manipulating that array, and returning different representations of it.

For now, it should include these methods:

• .contents to return the underlying array
• .each to iterate over the collection
• .contains to test if a certain note is present
• .add to add a note
• .remove to remove a note
• .map to map the underlying array
• .names as a shortcut to mapping the note names

having motive.Note and motive.note side-by-side is confusing.

constructors for Note, Interval and Chord should have their own home.

motive.constructors might work

Note and Chord objects should have a built-in method that outputs a string using unicode characters for accidentals, as well as symbols for major-7-type (delta), diminished and half-diminished chords (circle and slashed-circle). Also, it would be excellent to include superscripted chord types and extensions.