Comments (3)
Thanks for the information! This module purely follows the RFC, though.
You can find information regarding the specification in the references section https://github.com/jshttp/content-disposition/blob/master/README.md#references
The RFC says a trailing semicolon is not valid (and I copied the ABNF you can read into the comments of this module).
I would say to let them know they have buggy headers and you may want to apply that regular expression to responses you know have buggy headers before trying to parse.
from content-disposition.
I figured you'd say that, but browsers do "forgive" trailing semicolons and parse the header to supply correct filenames when downloading - so maybe it should be an option.
In any case - the information is here for someone to find it when wanting to know how to avoid those nasty semicolons :-)
from content-disposition.
Yea, I know they forgive a lot of things in a lot of ways (though there are various things Firefox has been trying to tighten, since being too forgiving ends up leading to bugs in parsing). Currently this module is primarily used to format a the header (so you can generate actually valid headers; too many people think they can just get away with string concatenation because "it's not that hard") and the parse is being dual-used to parse and validate.
I think if there is some kind of new major version releases that does more forgiving parsing, we need to take a survey of the Internet to determine what is actually the common mistakes in the header values to even understand what we need to parse, otherwise how can we come up with a parser?
from content-disposition.
Related Issues (20)
- Allow for Non-Standard Charset Name HOT 1
- Feature request: browser support HOT 13
- BUG: "attachment; [email protected]" fails HOT 2
- invalid parameter format with filename*= HOT 2
- Is it safe to use with aws-sdk? HOT 8
- Generate ext-parameter when utf8 and latin1 representations don't match HOT 14
- filename* is not supported HOT 2
- filename not support chinese is become `????.epub` HOT 3
- Usage in browser. path and safe-buffer modules HOT 3
- should decode the header value HOT 1
- Possibly address other control characters in header HOT 2
- Doesn't work anymore if path package is installed HOT 8
- Tests using deep-equal won't fail HOT 1
- No matching version found for [email protected]. HOT 1
- Will this package ever hit a major version? HOT 1
- ISO-8859-1 (`ByteString`) is confused with ASCII string HOT 5
- Remove use of Node.js modules HOT 3
- Allow to be built with webpack, use only some features. HOT 1
- Problems with supporting Cyrillic alphabet HOT 5
- Certain languages can't be matched correctly by the Regular Expression EXT_VALUE_REGEXP like en-US or zh_cn HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from content-disposition.