jsimmons / mongrel2-lua Goto Github PK

Hi,

I get this weird error, when I try to install using the guide fromhttp://tir.mongrel2.org/wiki/install.html:

luarocks install mongrel2-lua-1.6.1.rockspec                                                                    /tmp|16:01:04

Error: Directory v1.6 not found inside archive v1.6.1

For 1.6 we need to add a versioned rockspec rather than pulling out of trunk every time.

Title says it all. :-) Per HTTP spec the status code and status text is separated by just a space, not CRLF. Just remove the extra CRLF from HTTP_FORMAT and everything is ok.

When Mongrel2 drops release 1.6, the required version of ZeroMQ should be updated to 2.1.4+. Note that 2.1.6 should not be used due to a known bug (zeromq/libzmq#206). At the time of this writing 2.1.7 has not been tested with Mongrel2.

Hey josh, there's a 1 line fix for the m2 config stuff that is breaking configs with multiple hosts:

diff --git a/config.lua b/config.lua
index d535b18..8e219f0 100644
--- a/config.lua
+++ b/config.lua
@@ -67,7 +67,7 @@ end
 local function db_select(db, name, predicate)
     local query
 
-    if data then
+    if predicate then
         local conditions = {}
         for k, v in pairs(predicate) do
             local condition = ('%s = %s'):format(k, sql_tostring(v))

Thanks.

Support for tnetstrings needs to be added.

Example should shows "is_disconnect()" function usage. The current version of example is incorrect. Try:

1. start mongrel
2. connect with curl
3. kill curl
4. start example
5. example in infinite loop now

We have some documentation in the code, but nothing external and complete.

Especially worrisome for the config stuff.